Re: [PATCH V1 2/3] ALSA: hda: add bus callback for address translation

[Takashi Iwai <tiwai@suse.de>]

On Thu, 30 Oct 2025 12:09:27 +0100,
joakim.zhang@cixtech.com wrote:
> 
> From: Joakim Zhang <joakim.zhang@cixtech.com>
> 
> This patch adds bus callback for address translation, for some
> SoCs such as CIX SKY1 which is ARM64, HOST and HDAC has different
> memory view, so need to do address translation between HOST and HDAC.
> 
> Signed-off-by: Joakim Zhang <joakim.zhang@cixtech.com>
> ---
>  include/sound/hdaudio.h     |  3 +++
>  sound/hda/core/controller.c | 25 +++++++++++++++++++------
>  sound/hda/core/stream.c     | 17 ++++++++++++++---
>  3 files changed, 36 insertions(+), 9 deletions(-)
> 
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index 4e0c1d8af09f..61b41a014f4a 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -293,6 +293,9 @@ struct hdac_bus {
>  	const struct hdac_bus_ops *ops;
>  	const struct hdac_ext_bus_ops *ext_ops;
>  
> +	/* address translation from host to hdac */
> +	dma_addr_t (*addr_host_to_hdac)(struct hdac_bus *bus, dma_addr_t addr);

This should be rather added to hdac_bus_ops instead.

Or, we can just add addr_offset field in hdac_bus instead of yet
another callback.  Then the change would be simpler.


thanks,

Takashi