* [PATCH] ALSA: core: Fix style issues in sound/core/device.c
@ 2025-11-17 3:28 jempty.liang
2025-11-17 16:22 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: jempty.liang @ 2025-11-17 3:28 UTC (permalink / raw)
To: perex, tiwai; +Cc: linux-sound, linux-kernel, jempty.liang
This patch fixes blank line and trailing whitespace issues in
sound/core/device.c as reported by checkpatch.pl.
Signed-off-by: jempty.liang <imntjempty@163.com>
---
sound/core/device.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/core/device.c b/sound/core/device.c
index cdc5af526739..207dbc8c3242 100644
--- a/sound/core/device.c
+++ b/sound/core/device.c
@@ -47,6 +47,7 @@ int snd_device_new(struct snd_card *card, enum snd_device_type type,
/* insert the entry in an incrementally sorted list */
list_for_each_prev(p, &card->devices) {
struct snd_device *pdev = list_entry(p, struct snd_device, list);
+
if ((unsigned int)pdev->type <= (unsigned int)type)
break;
}
@@ -130,7 +131,7 @@ EXPORT_SYMBOL_GPL(snd_device_disconnect);
void snd_device_free(struct snd_card *card, void *device_data)
{
struct snd_device *dev;
-
+
if (snd_BUG_ON(!card || !device_data))
return;
dev = look_for_dev(card, device_data);
@@ -147,6 +148,7 @@ static int __snd_device_register(struct snd_device *dev)
if (dev->state == SNDRV_DEV_BUILD) {
if (dev->ops->dev_register) {
int err = dev->ops->dev_register(dev);
+
if (err < 0)
return err;
}
@@ -190,7 +192,7 @@ int snd_device_register_all(struct snd_card *card)
{
struct snd_device *dev;
int err;
-
+
if (snd_BUG_ON(!card))
return -ENXIO;
list_for_each_entry(dev, &card->devices, list) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: core: Fix style issues in sound/core/device.c
2025-11-17 3:28 [PATCH] ALSA: core: Fix style issues in sound/core/device.c jempty.liang
@ 2025-11-17 16:22 ` Takashi Iwai
2025-11-18 9:43 ` jempty.liang
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2025-11-17 16:22 UTC (permalink / raw)
To: jempty.liang; +Cc: perex, tiwai, linux-sound, linux-kernel
On Mon, 17 Nov 2025 04:28:16 +0100,
jempty.liang wrote:
>
> This patch fixes blank line and trailing whitespace issues in
> sound/core/device.c as reported by checkpatch.pl.
>
> Signed-off-by: jempty.liang <imntjempty@163.com>
Thanks for the patch. We don't apply a coding-only fix (especially
about only white-space) unless it's tied with some other real fix or
changes, because it'd bright merely more noises in the history.
That said, if you have more fix or a code change patch that is applied
to the code path, put such a cleanup as a preliminary work in the
series, and we'll happily take it together.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: core: Fix style issues in sound/core/device.c
2025-11-17 16:22 ` Takashi Iwai
@ 2025-11-18 9:43 ` jempty.liang
0 siblings, 0 replies; 3+ messages in thread
From: jempty.liang @ 2025-11-18 9:43 UTC (permalink / raw)
To: tiwai; +Cc: imntjempty, linux-kernel, linux-sound, perex, tiwai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-18 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-17 3:28 [PATCH] ALSA: core: Fix style issues in sound/core/device.c jempty.liang
2025-11-17 16:22 ` Takashi Iwai
2025-11-18 9:43 ` jempty.liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox