Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: sof_es8336: Fix headphone GPIO inversion logic
@ 2025-12-17 15:51 Tagir Garaev
  0 siblings, 0 replies; only message in thread
From: Tagir Garaev @ 2025-12-17 15:51 UTC (permalink / raw)
  To: cezary.rojewski, pierre-louis.bossart, broonie
  Cc: liam.r.girdwood, peter.ujfalusi, linux-sound, linux-kernel,
	Tagir Garaev

The headphone GPIO should be set to the inverse of speaker_en.
When speakers are enabled, headphones should be disabled and vice versa.

Currently both GPIOs are set to the same value (speaker_en), causing
audio to play through both speakers and headphones simultaneously
when headphones are plugged in.

Tested on Huawei Matebook (BOD-WXX9) with ES8336 codec.

Fixes: commit_sha ("ASoC: Intel: sof_es8336: add headphone GPIO
support")
Signed-off-by: Tagir Garaev <tgaraev653@gmail.com>
---
 sound/soc/intel/boards/sof_es8336.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c
index 774fff58d..fce50fd9f 100644
--- a/sound/soc/intel/boards/sof_es8336.c
+++ b/sound/soc/intel/boards/sof_es8336.c
@@ -120,7 +120,7 @@ static void pcm_pop_work_events(struct work_struct *work)
 	gpiod_set_value_cansleep(priv->gpio_speakers, priv->speaker_en);
 
 	if (quirk & SOF_ES8336_HEADPHONE_GPIO)
-		gpiod_set_value_cansleep(priv->gpio_headphone, priv->speaker_en);
+		gpiod_set_value_cansleep(priv->gpio_headphone, !priv->speaker_en);
 
 }
 
-- 
2.52.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-12-17 15:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 15:51 [PATCH] ASoC: Intel: sof_es8336: Fix headphone GPIO inversion logic Tagir Garaev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox