From: Hsieh Hung-En <hungen3108@gmail.com>
To: Mark Brown <broonie@kernel.org>, linux-sound@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Hsieh Hung-En <hungen3108@gmail.com>
Subject: [PATCH v2 1/5] ASoC: es8328: Fix DAC deemphasis control handling
Date: Sat, 31 Jan 2026 00:00:13 +0800 [thread overview]
Message-ID: <20260130160017.2630-2-hungen3108@gmail.com> (raw)
In-Reply-To: <20260130160017.2630-1-hungen3108@gmail.com>
The DAC deemphasis control updated the hardware before updating the cached
state, causing the previous setting to be applied.
Update the cached deemphasis state first and then apply the setting.
Also check and propagate errors from es8328_set_deemph() in hw_params().
Signed-off-by: Hsieh Hung-En <hungen3108@gmail.com>
---
sound/soc/codecs/es8328.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c
index 38340f292282..46868b7924a0 100644
--- a/sound/soc/codecs/es8328.c
+++ b/sound/soc/codecs/es8328.c
@@ -163,12 +163,11 @@ static int es8328_put_deemph(struct snd_kcontrol *kcontrol,
if (es8328->deemph == deemph)
return 0;
+ es8328->deemph = deemph;
ret = es8328_set_deemph(component);
if (ret < 0)
return ret;
- es8328->deemph = deemph;
-
return 1;
}
@@ -530,7 +529,9 @@ static int es8328_hw_params(struct snd_pcm_substream *substream,
return ret;
es8328->playback_fs = params_rate(params);
- es8328_set_deemph(component);
+ ret = es8328_set_deemph(component);
+ if (ret < 0)
+ return ret;
} else {
ret = snd_soc_component_update_bits(component, ES8328_ADCCONTROL4,
ES8328_ADCCONTROL4_ADCWL_MASK,
--
2.34.1
next prev parent reply other threads:[~2026-01-30 16:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 17:47 [PATCH 0/3] ASoC: es8328: Fix deemph control and improve error handling Hsieh Hung-En
2026-01-29 17:47 ` [PATCH 1/3] ASoC: es8328: Fix DAC deemphasis control handling Hsieh Hung-En
2026-01-29 17:47 ` [PATCH 2/3] ASoC: es8328: Propagate errors in set_bias_level() Hsieh Hung-En
2026-01-29 17:47 ` [PATCH 3/3] ASoC: es8328: Check errors in set_dai_fmt() and resume() Hsieh Hung-En
2026-01-29 18:02 ` Mark Brown
2026-01-30 16:00 ` [PATCH v2 0/5] ASoC: es8328: error handling and resume fixes Hsieh Hung-En
2026-01-30 16:00 ` Hsieh Hung-En [this message]
2026-01-30 16:00 ` [PATCH v2 2/5] ASoC: es8328: Propagate errors in set_bias_level() Hsieh Hung-En
2026-01-30 16:00 ` [PATCH v2 3/5] ASoC: es8328: Check errors in set_dai_fmt() Hsieh Hung-En
2026-01-30 16:00 ` [PATCH v2 4/5] ASoC: es8328: Use cached regmap on resume Hsieh Hung-En
2026-01-30 16:00 ` [PATCH v2 5/5] ASoC: es8328: Add error unwind in resume Hsieh Hung-En
2026-02-03 12:05 ` [PATCH v2 0/5] ASoC: es8328: error handling and resume fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130160017.2630-2-hungen3108@gmail.com \
--to=hungen3108@gmail.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox