Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Hsieh Hung-En <hungen3108@gmail.com>
To: Mark Brown <broonie@kernel.org>, linux-sound@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Hsieh Hung-En <hungen3108@gmail.com>
Subject: [PATCH v2 4/5] ASoC: es8328: Use cached regmap on resume
Date: Sat, 31 Jan 2026 00:00:16 +0800	[thread overview]
Message-ID: <20260130160017.2630-5-hungen3108@gmail.com> (raw)
In-Reply-To: <20260130160017.2630-1-hungen3108@gmail.com>

Use the regmap stored in the driver private data when restoring the
register cache on resume, instead of looking it up from the device.

This keeps the resume path consistent with the regmap instance used by
the driver and avoids relying on a separate dev_get_regmap() lookup.

Signed-off-by: Hsieh Hung-En <hungen3108@gmail.com>
---
 sound/soc/codecs/es8328.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c
index a18c3fe22da5..7afc97c62587 100644
--- a/sound/soc/codecs/es8328.c
+++ b/sound/soc/codecs/es8328.c
@@ -771,12 +771,9 @@ static int es8328_suspend(struct snd_soc_component *component)
 
 static int es8328_resume(struct snd_soc_component *component)
 {
-	struct regmap *regmap = dev_get_regmap(component->dev, NULL);
-	struct es8328_priv *es8328;
+	struct es8328_priv *es8328 = snd_soc_component_get_drvdata(component);
 	int ret;
 
-	es8328 = snd_soc_component_get_drvdata(component);
-
 	ret = clk_prepare_enable(es8328->clk);
 	if (ret) {
 		dev_err(component->dev, "unable to enable clock\n");
@@ -790,8 +787,8 @@ static int es8328_resume(struct snd_soc_component *component)
 		return ret;
 	}
 
-	regcache_mark_dirty(regmap);
-	ret = regcache_sync(regmap);
+	regcache_mark_dirty(es8328->regmap);
+	ret = regcache_sync(es8328->regmap);
 	if (ret) {
 		dev_err(component->dev, "unable to sync regcache\n");
 		return ret;
-- 
2.34.1


  parent reply	other threads:[~2026-01-30 16:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 17:47 [PATCH 0/3] ASoC: es8328: Fix deemph control and improve error handling Hsieh Hung-En
2026-01-29 17:47 ` [PATCH 1/3] ASoC: es8328: Fix DAC deemphasis control handling Hsieh Hung-En
2026-01-29 17:47 ` [PATCH 2/3] ASoC: es8328: Propagate errors in set_bias_level() Hsieh Hung-En
2026-01-29 17:47 ` [PATCH 3/3] ASoC: es8328: Check errors in set_dai_fmt() and resume() Hsieh Hung-En
2026-01-29 18:02   ` Mark Brown
2026-01-30 16:00 ` [PATCH v2 0/5] ASoC: es8328: error handling and resume fixes Hsieh Hung-En
2026-01-30 16:00   ` [PATCH v2 1/5] ASoC: es8328: Fix DAC deemphasis control handling Hsieh Hung-En
2026-01-30 16:00   ` [PATCH v2 2/5] ASoC: es8328: Propagate errors in set_bias_level() Hsieh Hung-En
2026-01-30 16:00   ` [PATCH v2 3/5] ASoC: es8328: Check errors in set_dai_fmt() Hsieh Hung-En
2026-01-30 16:00   ` Hsieh Hung-En [this message]
2026-01-30 16:00   ` [PATCH v2 5/5] ASoC: es8328: Add error unwind in resume Hsieh Hung-En
2026-02-03 12:05   ` [PATCH v2 0/5] ASoC: es8328: error handling and resume fixes Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260130160017.2630-5-hungen3108@gmail.com \
    --to=hungen3108@gmail.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=nicolas.frattaroli@collabora.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox