* [PATCH] ALSA: hda: cs35l56: Remove unnecessary struct cs_dsp_client_ops
@ 2026-02-26 12:41 Richard Fitzgerald
2026-02-26 13:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Richard Fitzgerald @ 2026-02-26 12:41 UTC (permalink / raw)
To: tiwai; +Cc: linux-kernel, linux-sound, patches
Since commit af37511305c0 ("firmware: cs_dsp: Don't require client to
provide a struct cs_dsp_client_ops") the client doesn't have to provide
a struct cs_dsp_client_ops. So remove the dummy cs_dsp_client_ops.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/hda/codecs/side-codecs/cs35l56_hda.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/hda/codecs/side-codecs/cs35l56_hda.c b/sound/hda/codecs/side-codecs/cs35l56_hda.c
index eb66827eabf8..1ace4beef508 100644
--- a/sound/hda/codecs/side-codecs/cs35l56_hda.c
+++ b/sound/hda/codecs/side-codecs/cs35l56_hda.c
@@ -403,10 +403,6 @@ static void cs35l56_hda_remove_controls(struct cs35l56_hda *cs35l56)
snd_ctl_remove(cs35l56->codec->card, cs35l56->volume_ctl);
}
-static const struct cs_dsp_client_ops cs35l56_hda_client_ops = {
- /* cs_dsp requires the client to provide this even if it is empty */
-};
-
static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56,
const struct firmware **firmware, char **filename,
const char *base_name, const char *system_name,
@@ -1149,7 +1145,6 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
cs35l56->base.cal_index = cs35l56->index;
cs35l56_init_cs_dsp(&cs35l56->base, &cs35l56->cs_dsp);
- cs35l56->cs_dsp.client_ops = &cs35l56_hda_client_ops;
if (cs35l56->base.reset_gpio) {
dev_dbg(cs35l56->base.dev, "Hard reset\n");
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda: cs35l56: Remove unnecessary struct cs_dsp_client_ops
2026-02-26 12:41 [PATCH] ALSA: hda: cs35l56: Remove unnecessary struct cs_dsp_client_ops Richard Fitzgerald
@ 2026-02-26 13:17 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-02-26 13:17 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: tiwai, linux-kernel, linux-sound, patches
On Thu, 26 Feb 2026 13:41:15 +0100,
Richard Fitzgerald wrote:
>
> Since commit af37511305c0 ("firmware: cs_dsp: Don't require client to
> provide a struct cs_dsp_client_ops") the client doesn't have to provide
> a struct cs_dsp_client_ops. So remove the dummy cs_dsp_client_ops.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-26 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 12:41 [PATCH] ALSA: hda: cs35l56: Remove unnecessary struct cs_dsp_client_ops Richard Fitzgerald
2026-02-26 13:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox