From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: [PATCH] ASoC: cs35l56-test: Add test cases without onchip pulls defined
Date: Tue, 3 Mar 2026 13:14:40 +0000 [thread overview]
Message-ID: <20260303131440.574690-1-rf@opensource.cirrus.com> (raw)
Add parameters to cs35l56_test_onchip_spkid_cases[] for the ACPI
defining onchip GPIOs but not defining any pull settings.
Pull settings are optional because the pull should normally be
provided by an external resistor.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/soc/codecs/cs35l56-test.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/codecs/cs35l56-test.c b/sound/soc/codecs/cs35l56-test.c
index b6c8c08e3ade..decedf76847d 100644
--- a/sound/soc/codecs/cs35l56-test.c
+++ b/sound/soc/codecs/cs35l56-test.c
@@ -541,18 +541,28 @@ static void cs35l56_test_gpio_param_desc(const struct cs35l56_test_param *param,
}
static const struct cs35l56_test_param cs35l56_test_onchip_spkid_cases[] = {
+ { .spkid_gpios = { 1, -1 }, .spkid_pulls = { -1, -1 }, },
+ { .spkid_gpios = { 1, -1 }, .spkid_pulls = { -1, -1 }, },
{ .spkid_gpios = { 1, -1 }, .spkid_pulls = { 1, -1 }, },
{ .spkid_gpios = { 1, -1 }, .spkid_pulls = { 2, -1 }, },
+ { .spkid_gpios = { 7, -1 }, .spkid_pulls = { -1, -1 }, },
+ { .spkid_gpios = { 7, -1 }, .spkid_pulls = { -1, -1 }, },
{ .spkid_gpios = { 7, -1 }, .spkid_pulls = { 1, -1 }, },
{ .spkid_gpios = { 7, -1 }, .spkid_pulls = { 2, -1 }, },
+ { .spkid_gpios = { 1, 7, -1 }, .spkid_pulls = { -1, -1, -1 }, },
+ { .spkid_gpios = { 1, 7, -1 }, .spkid_pulls = { -1, -1, -1 }, },
{ .spkid_gpios = { 1, 7, -1 }, .spkid_pulls = { 1, 1, -1 }, },
{ .spkid_gpios = { 1, 7, -1 }, .spkid_pulls = { 2, 2, -1 }, },
+ { .spkid_gpios = { 7, 1, -1 }, .spkid_pulls = { -1, -1, -1 }, },
+ { .spkid_gpios = { 7, 1, -1 }, .spkid_pulls = { -1, -1, -1 }, },
{ .spkid_gpios = { 7, 1, -1 }, .spkid_pulls = { 1, 1, -1 }, },
{ .spkid_gpios = { 7, 1, -1 }, .spkid_pulls = { 2, 2, -1 }, },
+ { .spkid_gpios = { 3, 7, 1, -1 }, .spkid_pulls = { -1, -1, -1, -1 }, },
+ { .spkid_gpios = { 3, 7, 1, -1 }, .spkid_pulls = { -1, -1, -1, -1 }, },
{ .spkid_gpios = { 3, 7, 1, -1 }, .spkid_pulls = { 1, 1, 1, -1 }, },
{ .spkid_gpios = { 3, 7, 1, -1 }, .spkid_pulls = { 2, 2, 2, -1 }, },
};
--
2.47.3
next reply other threads:[~2026-03-03 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 13:14 Richard Fitzgerald [this message]
2026-03-03 20:45 ` [PATCH] ASoC: cs35l56-test: Add test cases without onchip pulls defined Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303131440.574690-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox