[PATCH] ASoC: cs35l56-test: Add test cases without onchip pulls defined

[PATCH] ASoC: cs35l56-test: Add test cases without onchip pulls defined

[Richard Fitzgerald]

Add parameters to cs35l56_test_onchip_spkid_cases[] for the ACPI
defining onchip GPIOs but not defining any pull settings.

Pull settings are optional because the pull should normally be
provided by an external resistor.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
 sound/soc/codecs/cs35l56-test.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/soc/codecs/cs35l56-test.c b/sound/soc/codecs/cs35l56-test.c
index b6c8c08e3ade..decedf76847d 100644
--- a/sound/soc/codecs/cs35l56-test.c
+++ b/sound/soc/codecs/cs35l56-test.c
@@ -541,18 +541,28 @@ static void cs35l56_test_gpio_param_desc(const struct cs35l56_test_param *param,
 }
 
 static const struct cs35l56_test_param cs35l56_test_onchip_spkid_cases[] = {
+	{ .spkid_gpios = { 1, -1 },		.spkid_pulls = { -1, -1 }, },
+	{ .spkid_gpios = { 1, -1 },		.spkid_pulls = { -1, -1 }, },
 	{ .spkid_gpios = { 1, -1 },		.spkid_pulls = { 1, -1 }, },
 	{ .spkid_gpios = { 1, -1 },		.spkid_pulls = { 2, -1 }, },
 
+	{ .spkid_gpios = { 7, -1 },		.spkid_pulls = { -1, -1 }, },
+	{ .spkid_gpios = { 7, -1 },		.spkid_pulls = { -1, -1 }, },
 	{ .spkid_gpios = { 7, -1 },		.spkid_pulls = { 1, -1 }, },
 	{ .spkid_gpios = { 7, -1 },		.spkid_pulls = { 2, -1 }, },
 
+	{ .spkid_gpios = { 1, 7, -1 },		.spkid_pulls = { -1, -1, -1 }, },
+	{ .spkid_gpios = { 1, 7, -1 },		.spkid_pulls = { -1, -1, -1 }, },
 	{ .spkid_gpios = { 1, 7, -1 },		.spkid_pulls = { 1, 1, -1 }, },
 	{ .spkid_gpios = { 1, 7, -1 },		.spkid_pulls = { 2, 2, -1 }, },
 
+	{ .spkid_gpios = { 7, 1, -1 },		.spkid_pulls = { -1, -1, -1 }, },
+	{ .spkid_gpios = { 7, 1, -1 },		.spkid_pulls = { -1, -1, -1 }, },
 	{ .spkid_gpios = { 7, 1, -1 },		.spkid_pulls = { 1, 1, -1 }, },
 	{ .spkid_gpios = { 7, 1, -1 },		.spkid_pulls = { 2, 2, -1 }, },
 
+	{ .spkid_gpios = { 3, 7, 1, -1 },	.spkid_pulls = { -1, -1, -1, -1 }, },
+	{ .spkid_gpios = { 3, 7, 1, -1 },	.spkid_pulls = { -1, -1, -1, -1 }, },
 	{ .spkid_gpios = { 3, 7, 1, -1 },	.spkid_pulls = { 1, 1, 1, -1 }, },
 	{ .spkid_gpios = { 3, 7, 1, -1 },	.spkid_pulls = { 2, 2, 2, -1 }, },
 };
-- 
2.47.3

Re: [PATCH] ASoC: cs35l56-test: Add test cases without onchip pulls defined

[Mark Brown]

On Tue, 03 Mar 2026 13:14:40 +0000, Richard Fitzgerald wrote:
> Add parameters to cs35l56_test_onchip_spkid_cases[] for the ACPI
> defining onchip GPIOs but not defining any pull settings.
> 
> Pull settings are optional because the pull should normally be
> provided by an external resistor.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs35l56-test: Add test cases without onchip pulls defined
      commit: 2adac914c72b6cb5aba2612f49050c82aecd498e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark