* [PATCH 1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
@ 2026-03-14 20:06 ` Linus Walleij
2026-03-14 20:06 ` [PATCH 2/5] ASoC: amd: acp-es8336: " Linus Walleij
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-03-14 20:06 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, Linus Walleij
This driver includes the legacy header <linux/gpio.h> but does
not use any symbols from it. Drop the inclusion.
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
sound/soc/amd/acp-da7219-max98357a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 42aa009c4e13..3c08e6e17e41 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -11,7 +11,6 @@
#include <sound/soc-dapm.h>
#include <sound/jack.h>
#include <linux/clk.h>
-#include <linux/gpio.h>
#include <linux/module.h>
#include <linux/regulator/machine.h>
#include <linux/regulator/driver.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/5] ASoC: amd: acp-es8336: Drop unused include
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
2026-03-14 20:06 ` [PATCH 1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include Linus Walleij
@ 2026-03-14 20:06 ` Linus Walleij
2026-03-14 20:06 ` [PATCH 3/5] ASoC: amd: acp-rt5645: " Linus Walleij
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-03-14 20:06 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, Linus Walleij
This driver includes the legacy header <linux/gpio.h> but does
not use any symbols from it. Drop the inclusion.
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
sound/soc/amd/acp-es8336.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c
index b16dde0e2987..9f3f11256788 100644
--- a/sound/soc/amd/acp-es8336.c
+++ b/sound/soc/amd/acp-es8336.c
@@ -11,7 +11,6 @@
#include <sound/pcm_params.h>
#include <sound/soc-dapm.h>
#include <sound/jack.h>
-#include <linux/gpio.h>
#include <linux/device.h>
#include <linux/dmi.h>
#include <linux/gpio/consumer.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/5] ASoC: amd: acp-rt5645: Drop unused include
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
2026-03-14 20:06 ` [PATCH 1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include Linus Walleij
2026-03-14 20:06 ` [PATCH 2/5] ASoC: amd: acp-es8336: " Linus Walleij
@ 2026-03-14 20:06 ` Linus Walleij
2026-03-14 20:06 ` [PATCH 4/5] ASoC: amd: acp3x-es83x: " Linus Walleij
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-03-14 20:06 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, Linus Walleij
This driver includes the legacy header <linux/gpio.h> but does
not use any symbols from it. Drop the inclusion.
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
sound/soc/amd/acp-rt5645.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c
index 11d373169380..894f530434da 100644
--- a/sound/soc/amd/acp-rt5645.c
+++ b/sound/soc/amd/acp-rt5645.c
@@ -32,7 +32,6 @@
#include <sound/pcm_params.h>
#include <sound/soc-dapm.h>
#include <sound/jack.h>
-#include <linux/gpio.h>
#include <linux/module.h>
#include <linux/i2c.h>
#include <linux/acpi.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/5] ASoC: amd: acp3x-es83x: Drop unused include
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
` (2 preceding siblings ...)
2026-03-14 20:06 ` [PATCH 3/5] ASoC: amd: acp-rt5645: " Linus Walleij
@ 2026-03-14 20:06 ` Linus Walleij
2026-03-14 20:06 ` [PATCH 5/5] ASoC: amd: acp3x-rt5682-max9836: " Linus Walleij
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-03-14 20:06 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, Linus Walleij
This driver includes the legacy header <linux/gpio.h> but does
not use any symbols from it. Drop the inclusion.
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c b/sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c
index 141ea4787d99..46fff565d732 100644
--- a/sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c
+++ b/sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c
@@ -11,7 +11,6 @@
#include <sound/jack.h>
#include <sound/soc-acpi.h>
#include <linux/clk.h>
-#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/i2c.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5] ASoC: amd: acp3x-rt5682-max9836: Drop unused include
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
` (3 preceding siblings ...)
2026-03-14 20:06 ` [PATCH 4/5] ASoC: amd: acp3x-es83x: " Linus Walleij
@ 2026-03-14 20:06 ` Linus Walleij
2026-03-16 1:11 ` [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Mark Brown
2026-03-16 12:06 ` Mark Brown
6 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-03-14 20:06 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, Linus Walleij
This driver includes the legacy header <linux/gpio.h> but does
not use any symbols from it. Drop the inclusion.
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
sound/soc/amd/acp3x-rt5682-max9836.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c
index 4ca1978020a9..39e1a355e157 100644
--- a/sound/soc/amd/acp3x-rt5682-max9836.c
+++ b/sound/soc/amd/acp3x-rt5682-max9836.c
@@ -11,7 +11,6 @@
#include <sound/soc-dapm.h>
#include <sound/jack.h>
#include <linux/clk.h>
-#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/i2c.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] ASoC: amd: Move to GPIO descriptors
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
` (4 preceding siblings ...)
2026-03-14 20:06 ` [PATCH 5/5] ASoC: amd: acp3x-rt5682-max9836: " Linus Walleij
@ 2026-03-16 1:11 ` Mark Brown
2026-03-16 12:06 ` Mark Brown
6 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2026-03-16 1:11 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Linus Walleij
Cc: linux-sound
On Sat, 14 Mar 2026 21:06:19 +0100, Linus Walleij wrote:
> ASoC: amd: Move to GPIO descriptors
>
> After a quick look and test-compile I can determine that
> all of these drivers include <linux/gpio.h> for no reason
> whatsoever, so fixing it is low hanging fruit.
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1
Thanks!
[1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include
https://git.kernel.org/broonie/sound/c/6d841b46ec05
[2/5] ASoC: amd: acp-es8336: Drop unused include
https://git.kernel.org/broonie/sound/c/0a80eff3f53c
[3/5] ASoC: amd: acp-rt5645: Drop unused include
https://git.kernel.org/broonie/sound/c/d63b722361b8
[4/5] ASoC: amd: acp3x-es83x: Drop unused include
https://git.kernel.org/broonie/sound/c/70f0a90e718d
[5/5] ASoC: amd: acp3x-rt5682-max9836: Drop unused include
https://git.kernel.org/broonie/sound/c/c43988dfe25b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] ASoC: amd: Move to GPIO descriptors
2026-03-14 20:06 [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Linus Walleij
` (5 preceding siblings ...)
2026-03-16 1:11 ` [PATCH 0/5] ASoC: amd: Move to GPIO descriptors Mark Brown
@ 2026-03-16 12:06 ` Mark Brown
6 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2026-03-16 12:06 UTC (permalink / raw)
To: Vijendar Mukunda, Venkata Prasad Potturu, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Linus Walleij
Cc: linux-sound
On Sat, 14 Mar 2026 21:06:19 +0100, Linus Walleij wrote:
> After a quick look and test-compile I can determine that
> all of these drivers include <linux/gpio.h> for no reason
> whatsoever, so fixing it is low hanging fruit.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include
https://git.kernel.org/broonie/misc/c/6d841b46ec05
[2/5] ASoC: amd: acp-es8336: Drop unused include
https://git.kernel.org/broonie/misc/c/0a80eff3f53c
[3/5] ASoC: amd: acp-rt5645: Drop unused include
https://git.kernel.org/broonie/misc/c/d63b722361b8
[4/5] ASoC: amd: acp3x-es83x: Drop unused include
https://git.kernel.org/broonie/misc/c/70f0a90e718d
[5/5] ASoC: amd: acp3x-rt5682-max9836: Drop unused include
https://git.kernel.org/broonie/misc/c/c43988dfe25b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 9+ messages in thread