From: Baojun Xu <baojun.xu@ti.com>
To: <tiwai@suse.de>, <hansg@kernel.org>
Cc: <ilpo.jarvinen@linux.intel.com>, <broonie@kernel.org>,
<andriy.shevchenko@linux.intel.com>, <shenghao-ding@ti.com>,
<13916275206@139.com>, <platform-driver-x86@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<baojun.xu@ti.com>, <letitia.tsai@hp.com>,
<bill.yu@canonical.com>
Subject: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
Date: Sat, 18 Apr 2026 13:50:30 +0800 [thread overview]
Message-ID: <20260418055030.765-1-baojun.xu@ti.com> (raw)
In the SPI driver probe, the chip ID must be set to TAS2781. Without this
initialization, calibration data fails to load correctly, causing audio
abnormalities on some devices.
And update the register bulk read API to handle the distinct requirements
of SPI and I2C devices.
Fixes: 05ac3846ffe5 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
sound/hda/codecs/side-codecs/tas2781_hda_spi.c | 1 +
sound/soc/codecs/tas2781-fmwlib.c | 7 +++----
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
index f860e0eb7602..560f2385212d 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
@@ -788,6 +788,7 @@ static int tas2781_hda_spi_probe(struct spi_device *spi)
}
if (strstr(dev_name(&spi->dev), "TXNW2781")) {
device_name = "TXNW2781";
+ tas_hda->priv->chip_id = TAS2781;
} else {
dev_err(tas_priv->dev, "Unmatched spi dev %s\n",
dev_name(&spi->dev));
diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
index a1d86bd309f4..885e0b6fed00 100644
--- a/sound/soc/codecs/tas2781-fmwlib.c
+++ b/sound/soc/codecs/tas2781-fmwlib.c
@@ -2487,7 +2487,7 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i)
if (spec == NULL)
return -ENOMEM;
priv->tasdevice[i].cali_specific = spec;
- rc = tasdevice_dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);
+ rc = priv->dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);
if (rc < 0) {
dev_err(priv->dev, "invalid RE from %d = %d\n", i, rc);
return rc;
@@ -2511,9 +2511,8 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i)
TASDEVICE_REG(0, 0x1b, 0x34) :
TASDEVICE_REG(0, 0x18, 0x1c);
- rc = tasdevice_dev_bulk_read(priv, i,
- spec->sin_gni_reg,
- spec->sin_gni, 4);
+ rc = priv->dev_bulk_read(priv, i, spec->sin_gni_reg,
+ spec->sin_gni, 4);
if (rc < 0) {
dev_err(priv->dev, "wrong sinegaini %d = %d\n",
i, rc);
--
2.25.1
next reply other threads:[~2026-04-18 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 5:50 Baojun Xu [this message]
2026-04-20 6:15 ` [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device Takashi Iwai
2026-04-20 6:43 ` Eric Naim
2026-04-20 7:00 ` [EXTERNAL] " Xu, Baojun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260418055030.765-1-baojun.xu@ti.com \
--to=baojun.xu@ti.com \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bill.yu@canonical.com \
--cc=broonie@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=letitia.tsai@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox