public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: "Xu, Baojun" <baojun.xu@ti.com>
To: Eric Naim <dnaim@cachyos.org>, "tiwai@suse.de" <tiwai@suse.de>,
	"hansg@kernel.org" <hansg@kernel.org>
Cc: "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"andriy.shevchenko@linux.intel.com"
	<andriy.shevchenko@linux.intel.com>,
	"Ding, Shenghao" <shenghao-ding@ti.com>,
	"13916275206@139.com" <13916275206@139.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"letitia.tsai@hp.com" <letitia.tsai@hp.com>,
	"bill.yu@canonical.com" <bill.yu@canonical.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
Date: Mon, 20 Apr 2026 07:00:27 +0000	[thread overview]
Message-ID: <819b32735b084ec881af42bd4e4e6347@ti.com> (raw)
In-Reply-To: <26976b47-8886-4f3c-bdbd-c15e6ac7c44c@cachyos.org>

Hi Eric,

> 
> ________________________________________
> From: Eric Naim <dnaim@cachyos.org>
> Sent: 20 April 2026 14:43
> To: Xu, Baojun; tiwai@suse.de; hansg@kernel.org
> Cc: ilpo.jarvinen@linux.intel.com; broonie@kernel.org; andriy.shevchenko@linux.intel.com; Ding, Shenghao; 13916275206@139.com; platform-driver-x86@vger.kernel.org; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; letitia.tsai@hp.com; bill.yu@canonical.com
> Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
> 
> On 4/18/26 1:50 PM, Baojun Xu wrote:
> > In the SPI driver probe, the chip ID must be set to TAS2781. Without this
> > initialization, calibration data fails to load correctly, causing audio
> > abnormalities on some devices.
> > And update the register bulk read API to handle the distinct requirements
> > of SPI and I2C devices.
> >
> > Fixes: 05ac3846ffe5 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
>> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
> > ---
> Hi Baojun, will this fix
> https://urldefense.com/v3/__https://lore.kernel.org/linux-sound/20260315160939.191265-1-dnaim@cachyos.org/__;!!G3vK!X-jfopjNDyUV4Zt7eHbLDT79zxX8PrVATeyHGzNtgCNvue6wSwqHWSaaVOuqjRfYbzZ5TQzNVhRq$ ?
> 
> Similarly, I noticed that something like the above was merged upstream, commit
> 0bdf27abaf894.
> 

To clarify: The patch mentioned earlier was designed to register the correct project with the codec.
My patch specifically resolves the issue where calibration data fails to be applied properly.

> --
> Regards,
>   Eric
> 
> 

Best Regards
Jim


      reply	other threads:[~2026-04-20  7:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18  5:50 [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device Baojun Xu
2026-04-20  6:15 ` Takashi Iwai
2026-04-20  6:43 ` Eric Naim
2026-04-20  7:00   ` Xu, Baojun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=819b32735b084ec881af42bd4e4e6347@ti.com \
    --to=baojun.xu@ti.com \
    --cc=13916275206@139.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bill.yu@canonical.com \
    --cc=broonie@kernel.org \
    --cc=dnaim@cachyos.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=letitia.tsai@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox