* [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
@ 2026-05-13 16:27 Andy Shevchenko
2026-05-13 16:46 ` Richard Fitzgerald
2026-05-14 15:04 ` Richard Fitzgerald
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2026-05-13 16:27 UTC (permalink / raw)
To: Takashi Iwai, Andy Shevchenko, linux-sound, linux-kernel
Cc: Jaroslav Kysela, Takashi Iwai, Richard Fitzgerald
First of all, it has to be 'default n' (small letter n), otherwise
it looks for CONFIG_N which is absent and in case of appearance
will enable something unrelated. Second and most important is that
'n' *is* the default 'default' already. Hence just drop malformed
line.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/hda/codecs/side-codecs/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/hda/codecs/side-codecs/Kconfig b/sound/hda/codecs/side-codecs/Kconfig
index fc5651e555e3..e51964c0a091 100644
--- a/sound/hda/codecs/side-codecs/Kconfig
+++ b/sound/hda/codecs/side-codecs/Kconfig
@@ -94,7 +94,6 @@ menu "CS35L56 driver options"
config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
bool "CS35L56 create debugfs for factory calibration"
- default N
depends on DEBUG_FS
select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
help
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
2026-05-13 16:27 [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig Andy Shevchenko
@ 2026-05-13 16:46 ` Richard Fitzgerald
2026-05-13 17:22 ` Andy Shevchenko
2026-05-14 15:04 ` Richard Fitzgerald
1 sibling, 1 reply; 5+ messages in thread
From: Richard Fitzgerald @ 2026-05-13 16:46 UTC (permalink / raw)
To: Andy Shevchenko, Takashi Iwai, linux-sound, linux-kernel
Cc: Jaroslav Kysela, Takashi Iwai
On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance
> will enable something unrelated. Second and most important is that
> 'n' *is* the default 'default' already. Hence just drop malformed
> line.
The redundant default was added intentionally to be explicit that the
default really must be "no". But if that sort of thing is forbidden you
can drop the line.
I apologize for the typo, but that is why you shouldn't use case
difference as language syntax.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/hda/codecs/side-codecs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/hda/codecs/side-codecs/Kconfig b/sound/hda/codecs/side-codecs/Kconfig
> index fc5651e555e3..e51964c0a091 100644
> --- a/sound/hda/codecs/side-codecs/Kconfig
> +++ b/sound/hda/codecs/side-codecs/Kconfig
> @@ -94,7 +94,6 @@ menu "CS35L56 driver options"
>
> config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
> bool "CS35L56 create debugfs for factory calibration"
> - default N
> depends on DEBUG_FS
> select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
> help
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
2026-05-13 16:46 ` Richard Fitzgerald
@ 2026-05-13 17:22 ` Andy Shevchenko
2026-05-13 17:24 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-05-13 17:22 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: Takashi Iwai, linux-sound, linux-kernel, Jaroslav Kysela,
Takashi Iwai
On Wed, May 13, 2026 at 05:46:03PM +0100, Richard Fitzgerald wrote:
> On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> > First of all, it has to be 'default n' (small letter n), otherwise
> > it looks for CONFIG_N which is absent and in case of appearance
> > will enable something unrelated. Second and most important is that
> > 'n' *is* the default 'default' already. Hence just drop malformed
> > line.
>
> The redundant default was added intentionally to be explicit that the
> default really must be "no". But if that sort of thing is forbidden you
> can drop the line.
Torvalds gave his opinion on the Subject a few years ago, here is what he would
do.
0192f17529fa ("clean up x86 platform driver default values")
> I apologize for the typo, but that is why you shouldn't use case
> difference as language syntax.
It's not me whom you should ask for that :-)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
2026-05-13 17:22 ` Andy Shevchenko
@ 2026-05-13 17:24 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2026-05-13 17:24 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: Takashi Iwai, linux-sound, linux-kernel, Jaroslav Kysela,
Takashi Iwai
On Wed, May 13, 2026 at 08:22:23PM +0300, Andy Shevchenko wrote:
> On Wed, May 13, 2026 at 05:46:03PM +0100, Richard Fitzgerald wrote:
> > On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> > > First of all, it has to be 'default n' (small letter n), otherwise
> > > it looks for CONFIG_N which is absent and in case of appearance
> > > will enable something unrelated. Second and most important is that
> > > 'n' *is* the default 'default' already. Hence just drop malformed
> > > line.
> >
> > The redundant default was added intentionally to be explicit that the
> > default really must be "no". But if that sort of thing is forbidden you
> > can drop the line.
>
> Torvalds gave his opinion on the Subject a few years ago, here is what he would
> do.
>
> 0192f17529fa ("clean up x86 platform driver default values")
Based on that, can you give your tag, please? (Also for ASoC case.)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
2026-05-13 16:27 [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig Andy Shevchenko
2026-05-13 16:46 ` Richard Fitzgerald
@ 2026-05-14 15:04 ` Richard Fitzgerald
1 sibling, 0 replies; 5+ messages in thread
From: Richard Fitzgerald @ 2026-05-14 15:04 UTC (permalink / raw)
To: Andy Shevchenko, Takashi Iwai, linux-sound, linux-kernel
Cc: Jaroslav Kysela, Takashi Iwai
On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance
> will enable something unrelated. Second and most important is that
> 'n' *is* the default 'default' already. Hence just drop malformed
> line.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/hda/codecs/side-codecs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/hda/codecs/side-codecs/Kconfig b/sound/hda/codecs/side-codecs/Kconfig
> index fc5651e555e3..e51964c0a091 100644
> --- a/sound/hda/codecs/side-codecs/Kconfig
> +++ b/sound/hda/codecs/side-codecs/Kconfig
> @@ -94,7 +94,6 @@ menu "CS35L56 driver options"
>
> config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
> bool "CS35L56 create debugfs for factory calibration"
> - default N
> depends on DEBUG_FS
> select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
> help
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-05-14 15:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 16:27 [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig Andy Shevchenko
2026-05-13 16:46 ` Richard Fitzgerald
2026-05-13 17:22 ` Andy Shevchenko
2026-05-13 17:24 ` Andy Shevchenko
2026-05-14 15:04 ` Richard Fitzgerald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox