[PATCH] ASoC: fsl: remove Efika audio fabric driver

[PATCH] ASoC: fsl: remove Efika audio fabric driver

[Rosen Penev]

The Efika 5K2 is an OpenFirmware-based PowerPC board from ~2006.
The platform code (PPC_EFIKA) and its sound driver have no in-tree
DTB references and the hardware is long obsolete. Remove the driver.

Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 sound/soc/fsl/Kconfig              |  8 ---
 sound/soc/fsl/Makefile             |  1 -
 sound/soc/fsl/efika-audio-fabric.c | 92 ------------------------------
 3 files changed, 101 deletions(-)
 delete mode 100644 sound/soc/fsl/efika-audio-fabric.c

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 8ae59c094878..86be309158fa 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -250,14 +250,6 @@ config SND_MPC52xx_SOC_PCM030
 	  Say Y if you want to add support for sound on the Phytec pcm030
 	  baseboard.
 
-config SND_MPC52xx_SOC_EFIKA
-	tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
-	depends on PPC_EFIKA
-	select SND_SOC_MPC5200_AC97
-	select SND_SOC_STAC9766
-	help
-	  Say Y if you want to add support for sound on the Efika.
-
 endif # SND_POWERPC_SOC
 
 config SND_SOC_IMX_PCM_FIQ
diff --git a/sound/soc/fsl/Makefile b/sound/soc/fsl/Makefile
index d656a9ab54e3..367dbbd690be 100644
--- a/sound/soc/fsl/Makefile
+++ b/sound/soc/fsl/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_SND_SOC_MPC5200_AC97) += mpc5200_psc_ac97.o
 
 # MPC5200 Machine Support
 obj-$(CONFIG_SND_MPC52xx_SOC_PCM030) += pcm030-audio-fabric.o
-obj-$(CONFIG_SND_MPC52xx_SOC_EFIKA) += efika-audio-fabric.o
 
 # i.MX Platform Support
 snd-soc-imx-audmux-y := imx-audmux.o
diff --git a/sound/soc/fsl/efika-audio-fabric.c b/sound/soc/fsl/efika-audio-fabric.c
deleted file mode 100644
index 4d3266d9cbb7..000000000000
--- a/sound/soc/fsl/efika-audio-fabric.c
+++ /dev/null
@@ -1,92 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * Efika driver for the PSC of the Freescale MPC52xx
- * configured as AC97 interface
- *
- * Copyright 2008 Jon Smirl, Digispeaker
- * Author: Jon Smirl <jonsmirl@gmail.com>
- */
-
-#include <linux/init.h>
-#include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/device.h>
-#include <linux/delay.h>
-#include <linux/of.h>
-#include <linux/platform_device.h>
-#include <linux/dma-mapping.h>
-
-#include <sound/core.h>
-#include <sound/pcm.h>
-#include <sound/pcm_params.h>
-#include <sound/initval.h>
-#include <sound/soc.h>
-
-#include "mpc5200_dma.h"
-
-#define DRV_NAME "efika-audio-fabric"
-
-SND_SOC_DAILINK_DEFS(analog,
-	DAILINK_COMP_ARRAY(COMP_CPU("mpc5200-psc-ac97.0")),
-	DAILINK_COMP_ARRAY(COMP_CODEC("stac9766-codec",
-				      "stac9766-hifi-analog")),
-	DAILINK_COMP_ARRAY(COMP_PLATFORM("mpc5200-pcm-audio")));
-
-SND_SOC_DAILINK_DEFS(iec958,
-	DAILINK_COMP_ARRAY(COMP_CPU("mpc5200-psc-ac97.1")),
-	DAILINK_COMP_ARRAY(COMP_CODEC("stac9766-codec",
-				      "stac9766-hifi-IEC958")),
-	DAILINK_COMP_ARRAY(COMP_PLATFORM("mpc5200-pcm-audio")));
-
-static struct snd_soc_dai_link efika_fabric_dai[] = {
-{
-	.name = "AC97",
-	.stream_name = "AC97 Analog",
-	SND_SOC_DAILINK_REG(analog),
-},
-{
-	.name = "AC97",
-	.stream_name = "AC97 IEC958",
-	SND_SOC_DAILINK_REG(iec958),
-},
-};
-
-static struct snd_soc_card card = {
-	.name = "Efika",
-	.owner = THIS_MODULE,
-	.dai_link = efika_fabric_dai,
-	.num_links = ARRAY_SIZE(efika_fabric_dai),
-};
-
-static __init int efika_fabric_init(void)
-{
-	struct platform_device *pdev;
-	int rc;
-
-	if (!of_machine_is_compatible("bplan,efika"))
-		return -ENODEV;
-
-	pdev = platform_device_alloc("soc-audio", 1);
-	if (!pdev) {
-		pr_err("efika_fabric_init: platform_device_alloc() failed\n");
-		return -ENODEV;
-	}
-
-	platform_set_drvdata(pdev, &card);
-
-	rc = platform_device_add(pdev);
-	if (rc) {
-		pr_err("efika_fabric_init: platform_device_add() failed\n");
-		platform_device_put(pdev);
-		return -ENODEV;
-	}
-	return 0;
-}
-
-module_init(efika_fabric_init);
-
-
-MODULE_AUTHOR("Jon Smirl <jonsmirl@gmail.com>");
-MODULE_DESCRIPTION(DRV_NAME ": mpc5200 Efika fabric driver");
-MODULE_LICENSE("GPL");
-
-- 
2.54.0

Re: [PATCH] ASoC: fsl: remove Efika audio fabric driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On Tue, Jun 09, 2026 at 02:52:12PM -0700, Rosen Penev wrote:
> The Efika 5K2 is an OpenFirmware-based PowerPC board from ~2006.
> The platform code (PPC_EFIKA) and its sound driver have no in-tree
> DTB references and the hardware is long obsolete. Remove the driver.

Is this solving an actual problem, and was the DT ever distributed with
the kernel?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: fsl: remove Efika audio fabric driver

[Rosen Penev]

On Tue, Jun 9, 2026 at 4:26 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Jun 09, 2026 at 02:52:12PM -0700, Rosen Penev wrote:
> > The Efika 5K2 is an OpenFirmware-based PowerPC board from ~2006.
> > The platform code (PPC_EFIKA) and its sound driver have no in-tree
> > DTB references and the hardware is long obsolete. Remove the driver.
>
> Is this solving an actual problem, and was the DT ever distributed with
> the kernel?
No and I don't think so.

The only reason for the removal is that everything else old seems to
be getting removed.

Re: [PATCH] ASoC: fsl: remove Efika audio fabric driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On Tue, Jun 09, 2026 at 05:29:10PM -0700, Rosen Penev wrote:
> On Tue, Jun 9, 2026 at 4:26 PM Mark Brown <broonie@kernel.org> wrote:

> > On Tue, Jun 09, 2026 at 02:52:12PM -0700, Rosen Penev wrote:
> > > The Efika 5K2 is an OpenFirmware-based PowerPC board from ~2006.
> > > The platform code (PPC_EFIKA) and its sound driver have no in-tree
> > > DTB references and the hardware is long obsolete. Remove the driver.

> > Is this solving an actual problem, and was the DT ever distributed with
> > the kernel?

> No and I don't think so.

> The only reason for the removal is that everything else old seems to
> be getting removed.

OK, in that case I'd rather keep it unless it's causing trouble or
obviously can't be used (eg, due to dependencies being removed).  It's
hard to tell what some out of tree users are using, and some things have
a very long lifetime since they fit a good niche - it's only quite
recently that wm8731 went out of production for example.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]