* [PATCH] ASoC: tas2783A: remove unused tas25xx_(de)register_misc() functions
@ 2026-06-10 1:35 Ethan Nelson-Moore
2026-06-10 10:59 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-10 1:35 UTC (permalink / raw)
To: linux-sound
Cc: Ethan Nelson-Moore, Shenghao Ding, Kevin Lu, Baojun Xu,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
The tas2783 driver defines two functions tas25xx_register_misc and
tas25xx_deregister_misc which have stub implementations. It uses
external implementations if CONFIG_SND_SOC_TAS2783_UTIL is enabled, but
that symbol has never been present in the kernel. Therefore, these
functions are entirely unused. Remove them.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
sound/soc/codecs/tas2783-sdw.c | 2 --
sound/soc/codecs/tas2783.h | 8 --------
2 files changed, 10 deletions(-)
diff --git a/sound/soc/codecs/tas2783-sdw.c b/sound/soc/codecs/tas2783-sdw.c
index 90008d2d06e2..1aadb3a4c3a6 100644
--- a/sound/soc/codecs/tas2783-sdw.c
+++ b/sound/soc/codecs/tas2783-sdw.c
@@ -1011,7 +1011,6 @@ static s32 tas_component_probe(struct snd_soc_component *component)
snd_soc_component_get_drvdata(component);
tas_dev->component = component;
- tas25xx_register_misc(tas_dev->sdw_peripheral);
return 0;
}
@@ -1020,7 +1019,6 @@ static void tas_component_remove(struct snd_soc_component *codec)
{
struct tas2783_prv *tas_dev =
snd_soc_component_get_drvdata(codec);
- tas25xx_deregister_misc();
tas_dev->component = NULL;
}
diff --git a/sound/soc/codecs/tas2783.h b/sound/soc/codecs/tas2783.h
index bf34319c9a9f..d5996c73526c 100644
--- a/sound/soc/codecs/tas2783.h
+++ b/sound/soc/codecs/tas2783.h
@@ -100,12 +100,4 @@
#define TAS2783_CALIB_DATA_SZ ((TAS2783_CALIB_HDR_SZ) + TAS2783_CALIB_CRC_SZ + \
((TAS2783_CALIB_PARAMS) * 4 * (TAS2783_CALIB_MAX_SPK_COUNT)))
-#if IS_ENABLED(CONFIG_SND_SOC_TAS2783_UTIL)
-int32_t tas25xx_register_misc(struct sdw_slave *peripheral);
-int32_t tas25xx_deregister_misc(void);
-#else
-static void tas25xx_register_misc(struct sdw_slave *peripheral) {}
-static void tas25xx_deregister_misc(void) {}
-#endif
-
#endif /*__TAS2783_H__ */
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: tas2783A: remove unused tas25xx_(de)register_misc() functions
2026-06-10 1:35 [PATCH] ASoC: tas2783A: remove unused tas25xx_(de)register_misc() functions Ethan Nelson-Moore
@ 2026-06-10 10:59 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-06-10 10:59 UTC (permalink / raw)
To: linux-sound, Ethan Nelson-Moore
Cc: Shenghao Ding, Kevin Lu, Baojun Xu, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai
On Tue, 09 Jun 2026 18:35:34 -0700, Ethan Nelson-Moore wrote:
> ASoC: tas2783A: remove unused tas25xx_(de)register_misc() functions
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2
Thanks!
[1/1] ASoC: tas2783A: remove unused tas25xx_(de)register_misc() functions
https://git.kernel.org/broonie/sound/c/fda53b646717
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-11 9:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 1:35 [PATCH] ASoC: tas2783A: remove unused tas25xx_(de)register_misc() functions Ethan Nelson-Moore
2026-06-10 10:59 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox