* [PATCH] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type
@ 2026-06-12 21:49 Rob Herring (Arm)
2026-06-13 18:44 ` Krzysztof Kozlowski
2026-06-14 0:03 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-06-12 21:49 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
Animesh Agarwal
Cc: linux-sound, devicetree, linux-kernel
"realtek,gpio-config" is described as six 8-bit GPIO configuration
values, and the RT5677 driver stores and reads those values as bytes.
The binding incorrectly documented the property as a uint32 array.
Document "realtek,gpio-config" as a uint8-array so the generated
schema matches the hardware definition and the existing driver helper.
Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/sound/realtek,rt5677.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5677.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5677.yaml
index 9ce23e58e5ea..ae27ae78b1b2 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5677.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5677.yaml
@@ -58,7 +58,7 @@ properties:
0 - floating (reset value)
1 - pull down
2 - pull up
- $ref: /schemas/types.yaml#/definitions/uint32-array
+ $ref: /schemas/types.yaml#/definitions/uint8-array
minItems: 6
maxItems: 6
items:
@@ -130,6 +130,6 @@ examples:
realtek,pow-ldo2-gpio = <&gpio 3 GPIO_ACTIVE_HIGH>;
realtek,reset-gpio = <&gpio 3 GPIO_ACTIVE_LOW>;
realtek,in1-differential;
- realtek,gpio-config = <0 0 0 0 0 2>;
+ realtek,gpio-config = /bits/ 8 <0 0 0 0 0 2>;
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type
2026-06-12 21:49 [PATCH] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type Rob Herring (Arm)
@ 2026-06-13 18:44 ` Krzysztof Kozlowski
2026-06-14 0:03 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-13 18:44 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
Animesh Agarwal, linux-sound, devicetree, linux-kernel
On Fri, Jun 12, 2026 at 04:49:11PM -0500, Rob Herring (Arm) wrote:
> "realtek,gpio-config" is described as six 8-bit GPIO configuration
> values, and the RT5677 driver stores and reads those values as bytes.
> The binding incorrectly documented the property as a uint32 array.
>
> Document "realtek,gpio-config" as a uint8-array so the generated
> schema matches the hardware definition and the existing driver helper.
>
> Assisted-by: Codex:gpt-5-5
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/sound/realtek,rt5677.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type
2026-06-12 21:49 [PATCH] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type Rob Herring (Arm)
2026-06-13 18:44 ` Krzysztof Kozlowski
@ 2026-06-14 0:03 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-06-14 0:03 UTC (permalink / raw)
To: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley, Animesh Agarwal,
Rob Herring (Arm)
Cc: linux-sound, devicetree, linux-kernel
On Fri, 12 Jun 2026 16:49:11 -0500, Rob Herring (Arm) wrote:
> ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2
Thanks!
[1/1] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type
https://git.kernel.org/broonie/sound/c/4346d91cfa47
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-14 10:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-12 21:49 [PATCH] ASoC: dt-bindings: Fix RT5677 "realtek,gpio-config" type Rob Herring (Arm)
2026-06-13 18:44 ` Krzysztof Kozlowski
2026-06-14 0:03 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox