* [PATCH] ALSA: core: Drop redundant stream_open() return check
@ 2026-07-02 6:31 phucduc.bui
0 siblings, 0 replies; only message in thread
From: phucduc.bui @ 2026-07-02 6:31 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: cassiogabrielcontato, Kees Cook, HariKrishna Sagala, Cen Zhang,
Len Bao, HanQuan, Kyle Zeng, Dewei Meng, Maoyi Xie, linux-sound,
linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The previous conversion from nonseekable_open() to stream_open() retained
the existing error check.
Since stream_open() always returns 0, remove the dead error handling path.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/core/rawmidi.c | 4 +---
sound/core/seq/seq_clientmgr.c | 5 +----
sound/core/timer.c | 5 +----
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c
index 4dfd9d53e6d3..789254a88e53 100644
--- a/sound/core/rawmidi.c
+++ b/sound/core/rawmidi.c
@@ -441,9 +441,7 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
if ((file->f_flags & O_APPEND) && !(file->f_flags & O_NONBLOCK))
return -EINVAL; /* invalid combination */
- err = stream_open(inode, file);
- if (err < 0)
- return err;
+ stream_open(inode, file);
if (maj == snd_major) {
rmidi = snd_lookup_minor_data(iminor(inode),
diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c
index 28782e1776fa..8fe872367568 100644
--- a/sound/core/seq/seq_clientmgr.c
+++ b/sound/core/seq/seq_clientmgr.c
@@ -296,11 +296,8 @@ static int snd_seq_open(struct inode *inode, struct file *file)
int c, mode; /* client id */
struct snd_seq_client *client;
struct snd_seq_user_client *user;
- int err;
- err = stream_open(inode, file);
- if (err < 0)
- return err;
+ stream_open(inode, file);
scoped_guard(mutex, ®ister_mutex) {
client = seq_create_client1(-1, SNDRV_SEQ_DEFAULT_EVENTS);
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 51c6ac4df9f4..937d7996f7ab 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1531,11 +1531,8 @@ static int realloc_user_queue(struct snd_timer_user *tu, int size)
static int snd_timer_user_open(struct inode *inode, struct file *file)
{
struct snd_timer_user *tu;
- int err;
- err = stream_open(inode, file);
- if (err < 0)
- return err;
+ stream_open(inode, file);
tu = kzalloc_obj(*tu);
if (tu == NULL)
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-02 6:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-02 6:31 [PATCH] ALSA: core: Drop redundant stream_open() return check phucduc.bui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox