[PATCH] ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT

[PATCH] ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT

[Richard Fitzgerald]

Make the Kconfig item for cirrus_scodec visible if CONFIG_KUNIT is
enabled. This is so that its KUnit test can be enabled by KUnit
scripts without requiring a large amount of irrelevant additional
components.

The general rule for KUNIT_ALL_TESTS is that it should only enable
tests for components that are already selected. However, the UML
environment does not support ACPI, which means the HDA codec drivers
that use cirrus_scodec cannot be selected. But cirrus_scodec does not
need ACPI.

By making the Kconfig option visible if CONFIG_KUNIT, the KUnit test
can be enabled with only the minimal set of functionality that is
required for cirrus_scodec.

This is still compliant with the KUNIT_ALL_TESTS rule "only tests
for enabled modules" because by default cirrus_scodec will only be
enabled if the drivers that use it are enabled. It must be
intentionally enabled to force it to be included for testing.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
 sound/hda/codecs/side-codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/codecs/side-codecs/Kconfig b/sound/hda/codecs/side-codecs/Kconfig
index 2a2e8804bf9e4..1cfd83e251e4b 100644
--- a/sound/hda/codecs/side-codecs/Kconfig
+++ b/sound/hda/codecs/side-codecs/Kconfig
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config SND_HDA_CIRRUS_SCODEC
-	tristate
+	tristate "Cirrus side-codec library" if KUNIT
 
 config SND_HDA_CIRRUS_SCODEC_KUNIT_TEST
 	tristate "KUnit test for Cirrus side-codec library" if !KUNIT_ALL_TESTS
-- 
2.47.3

Re: [PATCH] ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT

[Takashi Iwai]

On Thu, 09 Jul 2026 14:12:24 +0200,
Richard Fitzgerald wrote:
> 
> Make the Kconfig item for cirrus_scodec visible if CONFIG_KUNIT is
> enabled. This is so that its KUnit test can be enabled by KUnit
> scripts without requiring a large amount of irrelevant additional
> components.
> 
> The general rule for KUNIT_ALL_TESTS is that it should only enable
> tests for components that are already selected. However, the UML
> environment does not support ACPI, which means the HDA codec drivers
> that use cirrus_scodec cannot be selected. But cirrus_scodec does not
> need ACPI.
> 
> By making the Kconfig option visible if CONFIG_KUNIT, the KUnit test
> can be enabled with only the minimal set of functionality that is
> required for cirrus_scodec.
> 
> This is still compliant with the KUNIT_ALL_TESTS rule "only tests
> for enabled modules" because by default cirrus_scodec will only be
> enabled if the drivers that use it are enabled. It must be
> intentionally enabled to force it to be included for testing.
> 
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Applied now.  Thanks.


Takashi