[PATCH] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

[PATCH] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

[Rosen Penev]

The MPC5200 PSC AC97 driver only applies to the MPC52xx family of
SoCs, but only depended on PPC_BESTCOMM. Restrict the driver to
MPC52xx platforms so it is not offered (and does not fail to build)
on other bestcomm-based machines.

Fixes the following linking error:

ERROR: modpost: sound/soc/fsl/mpc5200_psc_ac97.ko: symbol 'mpc5200_psc_ac97_gpio_reset' undefined!

Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 sound/soc/fsl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 04940879dfd8..101bc952aa14 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -234,7 +234,7 @@ config SND_SOC_MPC5200_I2S
 
 config SND_SOC_MPC5200_AC97
 	tristate "Freescale MPC5200 PSC in AC97 mode driver"
-	depends on PPC_BESTCOMM
+	depends on PPC_BESTCOMM && PPC_MPC52xx
 	select SND_SOC_AC97_BUS
 	select SND_MPC52xx_DMA
 	select PPC_BESTCOMM_GEN_BD
-- 
2.55.0

Re: [PATCH] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Wed, Sep 16, 2026 at 03:04:53PM -0700, Rosen Penev wrote:
> The MPC5200 PSC AC97 driver only applies to the MPC52xx family of
> SoCs, but only depended on PPC_BESTCOMM. Restrict the driver to
> MPC52xx platforms so it is not offered (and does not fail to build)
> on other bestcomm-based machines.

>  config SND_SOC_MPC5200_AC97
>  	tristate "Freescale MPC5200 PSC in AC97 mode driver"
> -	depends on PPC_BESTCOMM
> +	depends on PPC_BESTCOMM && PPC_MPC52xx

The DMA controller has:

config PPC_BESTCOMM
        tristate "Bestcomm DMA engine support"
        depends on PPC_MPC52xx

so there's something else going on here I think.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

[Rosen Penev]

On Thu, Sep 17, 2026 at 10:24 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Sep 16, 2026 at 03:04:53PM -0700, Rosen Penev wrote:
> > The MPC5200 PSC AC97 driver only applies to the MPC52xx family of
> > SoCs, but only depended on PPC_BESTCOMM. Restrict the driver to
> > MPC52xx platforms so it is not offered (and does not fail to build)
> > on other bestcomm-based machines.
>
> >  config SND_SOC_MPC5200_AC97
> >       tristate "Freescale MPC5200 PSC in AC97 mode driver"
> > -     depends on PPC_BESTCOMM
> > +     depends on PPC_BESTCOMM && PPC_MPC52xx
>
> The DMA controller has:
>
> config PPC_BESTCOMM
>         tristate "Bestcomm DMA engine support"
>         depends on PPC_MPC52xx
>
> so there's something else going on here I think.
It was requested that I split up from
https://lore.kernel.org/dmaengine/aqrxFTWEsJmFIrel@SMW015318/

Re: [PATCH] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

On Thu, Sep 17, 2026 at 11:27:36AM -0700, Rosen Penev wrote:

> It was requested that I split up from
> https://lore.kernel.org/dmaengine/aqrxFTWEsJmFIrel@SMW015318/

Unless you mention that I'm not going to be able to tell that anything
else has changed...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

[Mark Brown]

On Wed, 16 Sep 2026 15:04:53 -0700, Rosen Penev wrote:
> ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/1] ASoC: fsl: mpc5200: gate AC97 driver on PPC_MPC52xx
      https://git.kernel.org/broonie/sound/c/ebdc596c4262

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark