Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup
@ 2026-09-18 11:17 Cezary Rojewski
  2026-09-18 11:17 ` [PATCH 2/2] ASoC: codecs: rt274: Fix format setting for 44100 rate Cezary Rojewski
  2026-09-22 10:26 ` [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Cezary Rojewski @ 2026-09-18 11:17 UTC (permalink / raw)
  To: broonie; +Cc: tiwai, perex, amade, linux-sound, Cezary Rojewski

Fat fingered the change when reorganizing the jack-detect
initialization. Equivalent changes for rt274 and rt298:

Commit a43b4394bb35 ("ASoC: codecs: rt274: Always init jack_detect_work")
Commit 1eb73102da28 ("ASoC: codecs: rt298: Reorganize jack detect handling")

carry no update to the delay value.

From user perspective, no difference has been observed between 1250 and
50 values on Intel's SkyLake, KabyLake and AmberLake configurations.

Fixes: 3082afe097cc ("ASoC: codecs: rt286: Reorganize jack detect handling")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/codecs/rt286.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 9e84cc657ef5..edfe7d88c313 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -956,7 +956,7 @@ static int rt286_probe(struct snd_soc_component *component)
 
 	if (rt286->i2c->irq)
 		schedule_delayed_work(&rt286->jack_detect_work,
-				      msecs_to_jiffies(50));
+				      msecs_to_jiffies(1250));
 	return 0;
 }
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: codecs: rt274: Fix format setting for 44100 rate
  2026-09-18 11:17 [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup Cezary Rojewski
@ 2026-09-18 11:17 ` Cezary Rojewski
  2026-09-22 10:26 ` [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Cezary Rojewski @ 2026-09-18 11:17 UTC (permalink / raw)
  To: broonie; +Cc: tiwai, perex, amade, linux-sound, Cezary Rojewski

As per specification, Sample Base Rate (bit 14)
shall be set to 1 for 44.1 kHz.

Fixes: c7e79b2b2d2d ("ASoC: rt274: add rt274 codec driver")
Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/codecs/rt274.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index 91031a08a5cd..496cfd3e8fb7 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -622,9 +622,11 @@ static int rt274_hw_params(struct snd_pcm_substream *substream,
 	unsigned int val = 0;
 	int d_len_code = 0, c_len_code = 0;
 
+	/* bit 14 Sample Rate Base, 0: 48kHz 1: 44.1kHz */
 	switch (params_rate(params)) {
-	/* bit 14 0:48K 1:44.1K */
 	case 44100:
+		val |= BIT(14);
+		break;
 	case 48000:
 		break;
 	default:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup
  2026-09-18 11:17 [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup Cezary Rojewski
  2026-09-18 11:17 ` [PATCH 2/2] ASoC: codecs: rt274: Fix format setting for 44100 rate Cezary Rojewski
@ 2026-09-22 10:26 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-09-22 10:26 UTC (permalink / raw)
  To: Cezary Rojewski; +Cc: tiwai, perex, amade, linux-sound

On Fri, 18 Sep 2026 13:17:44 +0200, Cezary Rojewski wrote:
> ASoC: codecs: rt286: Revert delay value for jack setup

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/2] ASoC: codecs: rt286: Revert delay value for jack setup
      https://git.kernel.org/broonie/sound/c/d30fba93ebfc
[2/2] ASoC: codecs: rt274: Fix format setting for 44100 rate
      https://git.kernel.org/broonie/sound/c/6eda8938a790

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-22 12:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 11:17 [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup Cezary Rojewski
2026-09-18 11:17 ` [PATCH 2/2] ASoC: codecs: rt274: Fix format setting for 44100 rate Cezary Rojewski
2026-09-22 10:26 ` [PATCH 1/2] ASoC: codecs: rt286: Revert delay value for jack setup Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox