Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Fix mute and micmute LEDs on HP ENVY x360 15-ey0xxx
@ 2026-09-29 17:43 Harrison Lucas
  2026-09-30 12:31 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Harrison Lucas @ 2026-09-29 17:43 UTC (permalink / raw)
  To: linux-sound; +Cc: Takashi Iwai, Harrison Lucas

The HP ENVY x360 2-in-1 Laptop 15-ey0xxx (SSID 103c:8a31, ALC245 with
CS35L41 I2C amps) currently only gets ALC287_FIXUP_CS35L41_I2C_2, so the
mute and micmute LEDs on the keyboard never light up.

On this machine the mute LED is driven by COEF 0x0b bits 2-3 and the
micmute LED by GPIO 0x04 (active low), which is exactly what
ALC245_FIXUP_HP_X360_MUTE_LEDS sets up. Switch the quirk to
ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS, which keeps the CS35L41 setup
and chains to that LED fixup.

Verified by driving the COEF and GPIO values by hand with hda-verb,
following Master Playback Switch and Mic ACP LED Capture Switch.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Harrison Lucas <tiiowsalt@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 67b9f4172..6648dd318 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7703,7 +7703,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a2d, "HP Envy 16", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a2e, "HP Envy 16", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a30, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
-	SND_PCI_QUIRK(0x103c, 0x8a31, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x103c, 0x8a31, "HP ENVY x360 2-in-1 Laptop 15-ey0xxx", ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8a34, "HP Pavilion x360 2-in-1 Laptop 14-ek0xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a36, "HP Pavilion Plus 14-eh0xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a3d, "HP Victus 15-fb0xxx (MB 8A3D)", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Fix mute and micmute LEDs on HP ENVY x360 15-ey0xxx
  2026-09-29 17:43 [PATCH] ALSA: hda/realtek: Fix mute and micmute LEDs on HP ENVY x360 15-ey0xxx Harrison Lucas
@ 2026-09-30 12:31 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-09-30 12:31 UTC (permalink / raw)
  To: Harrison Lucas; +Cc: linux-sound, Takashi Iwai

On Tue, 29 Sep 2026 19:43:48 +0200,
Harrison Lucas wrote:
> 
> The HP ENVY x360 2-in-1 Laptop 15-ey0xxx (SSID 103c:8a31, ALC245 with
> CS35L41 I2C amps) currently only gets ALC287_FIXUP_CS35L41_I2C_2, so the
> mute and micmute LEDs on the keyboard never light up.
> 
> On this machine the mute LED is driven by COEF 0x0b bits 2-3 and the
> micmute LED by GPIO 0x04 (active low), which is exactly what
> ALC245_FIXUP_HP_X360_MUTE_LEDS sets up. Switch the quirk to
> ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS, which keeps the CS35L41 setup
> and chains to that LED fixup.
> 
> Verified by driving the COEF and GPIO values by hand with hda-verb,
> following Master Playback Switch and Mic ACP LED Capture Switch.
> 
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Harrison Lucas <tiiowsalt@gmail.com>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-30 12:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-29 17:43 [PATCH] ALSA: hda/realtek: Fix mute and micmute LEDs on HP ENVY x360 15-ey0xxx Harrison Lucas
2026-09-30 12:31 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox