Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: vkoul@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org,
	stable@vger.kernel.org
Subject: [PATCH 0/4] ALSA: compress: fix buffer handling and state validation
Date: Wed,  7 Oct 2026 16:25:05 +0300	[thread overview]
Message-ID: <20261007132509.18237-1-peter.ujfalusi@linux.intel.com> (raw)

Hi,

The compress offload core has several edge cases in buffer management
and state validation.

Repeated SET_PARAMS while a stream is OPEN can replace a framework-owned
buffer without freeing it. During gapless playback, SET_PARAMS can also
change the buffer geometry while the byte counters still refer to the
previous buffer. Separately, SET_METADATA can reach the driver before
SET_PARAMS, and the origin_seqno task lookup can restart a task that is
still ACTIVE.

Address these cases by:
- freeing a prior framework-owned buffer before replacing it;
- rejecting buffer geometry changes on the gapless next_track path;
- rejecting SET_METADATA while the stream is OPEN; and
- allowing origin_seqno to reuse IDLE or FINISHED tasks, but not ACTIVE
  ones.

Regards,
Peter
---
Peter Ujfalusi (4):
  ALSA: compress: fix buffer leak on repeated SET_PARAMS
  ALSA: compress: reject buffer geometry change on gapless next_track
  ALSA: compress: add missing OPEN-state gate to SET_METADATA
  ALSA: compress: reject restarting an ACTIVE task via origin_seqno

 sound/core/compress_offload.c | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

-- 
2.56.0


             reply	other threads:[~2026-10-07 13:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 13:25 Peter Ujfalusi [this message]
2026-10-07 13:25 ` [PATCH 1/4] ALSA: compress: fix buffer leak on repeated SET_PARAMS Peter Ujfalusi
2026-10-07 14:04   ` Takashi Iwai
2026-10-07 14:10     ` Vinod Koul
2026-10-07 14:25       ` Péter Ujfalusi
2026-10-07 14:37         ` Vinod Koul
2026-10-08  6:25           ` Péter Ujfalusi
2026-10-08  7:57             ` Péter Ujfalusi
2026-10-08  7:54     ` Péter Ujfalusi
2026-10-07 14:08   ` Vinod Koul
2026-10-07 13:25 ` [PATCH 2/4] ALSA: compress: reject buffer geometry change on gapless next_track Peter Ujfalusi
2026-10-07 14:12   ` Vinod Koul
2026-10-07 13:25 ` [PATCH 3/4] ALSA: compress: add missing OPEN-state gate to SET_METADATA Peter Ujfalusi
2026-10-07 14:12   ` Vinod Koul
2026-10-07 13:25 ` [PATCH 4/4] ALSA: compress: reject restarting an ACTIVE task via origin_seqno Peter Ujfalusi
2026-10-07 14:14   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007132509.18237-1-peter.ujfalusi@linux.intel.com \
    --to=peter.ujfalusi@linux.intel.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox