Re: [PATCH 4/4] ALSA: compress: reject restarting an ACTIVE task via origin_seqno

[Vinod Koul <vkoul@kernel.org>]

On 07-10-26, 16:25, Peter Ujfalusi wrote:
> snd_compr_task_start_prepare() only rejects tasks with
> state >= SND_COMPRESS_TASK_STATE_FINISHED. Since the enum is
> IDLE(0) < ACTIVE(1) < FINISHED(2), this accepts ACTIVE tasks and
> rejects FINISHED ones, the opposite of what the origin_seqno
> mechanism needs: origin_seqno is meant to let a caller reuse a
> FINISHED task's buffers for a new job, not to restart a task that is
> still queued with the driver.
> 
> The seqno lookup path in snd_compr_task_start() has its own explicit
> "task->state != IDLE" guard, but the origin_seqno lookup path relies
> solely on this function, so it can restart an ACTIVE task, causing
> ops->task_start() to be called twice for the same task and
> runtime->active_tasks to be incremented twice without a matching
> finish/stop.
> 
> Accept IDLE and FINISHED, reject ACTIVE, on both entry paths.

Acked-by: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod