Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Jiawei Wang <me@jwang.link>, broonie@kernel.org
Cc: linux-sound@vger.kernel.org, sashal@kernel.org,
	Venkata prasad Potturu <venkataprasad.potturu@amd.com>,
	Syed Saba Kareem <Syed.SabaKareem@amd.com>,
	"Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>
Subject: Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"
Date: Thu, 14 Mar 2024 10:44:27 +0530	[thread overview]
Message-ID: <2768b0a2-d228-4d26-90d2-b4f6d83cfb5d@amd.com> (raw)
In-Reply-To: <20240313015853.3573242-1-me@jwang.link>

On 13/03/24 07:28, Jiawei Wang wrote:
> I would like to revert two of my previous commits after
> realizing they incorrectly enabled the Yellow Carp
> (YC) driver for Pink Sardine (PS) platforms.
>
> The first commit was reverted because it added a quirk entry
> that incorrectly enabled the YC driver for the Lenovo 21J2
> laptop, which is a PS platform.
>
> The second commit was reverted because it incorrectly enabled
> the YC driver for PS platforms.
>
> Thanks to Mukunda Vijendar [1] for pointing this out.
>
> Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
>
> v3 -> v2:
> - No changes to content.
> - Patches re-prepared using the broonie/sound.git tree's for-next branch.
> v2 -> v1:
> - No changes to content. Subject lines and commit messages were revised.
>
> On March 13, 2024 at 12:44 AM, Mark Brown wrote:
>> This still doesn't apply against my for-6.9 branch.
> I've updated the patch using your "for-next" tree.
>
> However, it can't be applied to the "for-6.9" branch,
> because the commits to be reverted are not present in "for-6.9".
> Below are their hashes:
> ed00a69  ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
> 316a784  ASoC: amd: yc: add new YC platform variant (0x63) support
>
> On March 13, 2024 at 12:50 AM, Mukunda,Vijendar wrote:
>> You can prepare patch by cloning below git tree for-next branch.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
>>
>> while sending patches, please use --cc-cmd=./scripts/get_maintainer.pl along
>> with cc list.
> Thank you for your guidance. I have updated the patch using
> the "for-next" tree as suggested. Additionally, I've 
> incorporated the cc-cmd as per your instructions.

Hi Mark,

Could you please apply this patch series? Without these changes, functionality
is broken for Pink Sardine (PS) platform.

>
> Jiawei Wang (2):
>   ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
>   ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
>
>  sound/soc/amd/yc/acp6x-mach.c | 7 -------
>  sound/soc/amd/yc/pci-acp6x.c  | 1 -
>  2 files changed, 8 deletions(-)
>


  parent reply	other threads:[~2024-03-14  5:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  2:33 [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support" Jiawei Wang
2024-03-12  2:33 ` [PATCH 1/2] Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-12 13:56   ` Mark Brown
2024-03-12 16:32     ` [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-12 16:32       ` [PATCH v2 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-12 16:44         ` Mark Brown
2024-03-13  1:58           ` [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-13  1:58             ` [PATCH v3 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-13  1:58             ` [PATCH v3 2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-14  5:14             ` Mukunda,Vijendar [this message]
2024-03-14 13:09               ` [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and " Mark Brown
2024-03-15 17:14             ` Mark Brown
2024-03-12 16:32       ` [PATCH v2 2/2] ASoC: amd: yc: Revert " Jiawei Wang
2024-03-15 17:14       ` [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and " Mark Brown
2024-03-12  2:33 ` [PATCH 2/2] Revert "ASoC: amd: yc: add " Jiawei Wang
2024-03-12 13:14 ` [PATCH 0/2] " Mark Brown
2024-03-27 17:56 ` Luca Stefani
2024-03-27 18:09   ` Greg KH
2024-03-28 10:40     ` Mukunda,Vijendar
2024-03-28 11:34       ` Greg KH
2024-03-28 11:57         ` Mukunda,Vijendar
2024-03-29  9:30           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2768b0a2-d228-4d26-90d2-b4f6d83cfb5d@amd.com \
    --to=vijendar.mukunda@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=Syed.SabaKareem@amd.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=me@jwang.link \
    --cc=sashal@kernel.org \
    --cc=venkataprasad.potturu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox