[PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Jiawei Wang]

Please revert my previous two commits:

ASoC: amd: yc: add new YC platform variant (0x63) support
[ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]

ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
[ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]

PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow
Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.

The mic on Lenovo 21J2 works after enabling the CONFIG_SND_SOC_AMD_PS
flag, which I had not enabled when I was writing these patches. 21J2
does not need to be in this quirk table.

I apologize for the inconvenience caused.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>

Jiawei Wang (2):
  Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"
  Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)

-- 
2.39.2

[PATCH 1/2] Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"

[Jiawei Wang]

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.

Lenovo 21J2 uses the Pink Sardine (PS) platform, not Yellow Carp
(YC). Thanks to Mukunda Vijendar [1] for pointing this out.

Lenovo 21J2 should not be in YC's quirk table.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 90360f8b3e81..1d1452c29ed0 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.39.2

Re: [PATCH 1/2] Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On Tue, Mar 12, 2024 at 10:33:25AM +0800, Jiawei Wang wrote:
> This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

> Lenovo 21J2 uses the Pink Sardine (PS) platform, not Yellow Carp
> (YC). Thanks to Mukunda Vijendar [1] for pointing this out.
> 
> Lenovo 21J2 should not be in YC's quirk table.

This doesn't apply against current code, please check and resend - there
was another quirk went in yesterday which might also need to be
reverted.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

[Jiawei Wang]

I would like to revert two of my previous commits after
realizing they incorrectly enabled the Yellow Carp
(YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry
that incorrectly enabled the YC driver for the Lenovo 21J2
laptop, which is a PS platform.

The second commit was reverted because it incorrectly enabled
the YC driver for PS platforms.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

On 2024-03-12 13:14 UTC, Mark Brown wrote:
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

The patches' subject lines have been changed to
ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

On 2024-03-12 13:56 UTC, Mark Brown wrote:
> > This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.
> 
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

I have added descriptions around commit hashes in the updated patch set, 
copied below for convenience:
1. This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.
2. This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa,
that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

> This doesn't apply against current code, please check and resend - there
> was another quirk went in yesterday which might also need to be
> reverted.

I have updated the explanation for the first patch for why
the quirk entry for Lenovo 21J2 should be removed.
Please find my updated explanation in [PATCH v2 1/2].

Thanks for the review.

Signed-off-by: Jiawei Wang <me@jwang.link>

Jiawei Wang (2):
  ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
  ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)

-- 
2.39.2

[PATCH v2 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

[Jiawei Wang]

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.

Although the microphone functioned with the YC driver, it
resulted in incorrect driver usage. The Lenovo 21J2 is not a
Yellow Carp platform, but a Pink Sardine platform, which
already has an upstreamed driver.

The microphone on the Lenovo 21J2 operates correctly with the
CONFIG_SND_SOC_AMD_PS flag enabled and does not require the
quirk entry. So this patch removes the quirk entry.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 90360f8b3e81..1d1452c29ed0 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.39.2

Re: [PATCH v2 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

On Wed, Mar 13, 2024 at 12:32:55AM +0800, Jiawei Wang wrote:
> This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
> which added a quirk entry to enable the Yellow Carp (YC)
> driver for the Lenovo 21J2 laptop.

This still doesn't apply against my for-6.9 branch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

[Jiawei Wang]

I would like to revert two of my previous commits after
realizing they incorrectly enabled the Yellow Carp
(YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry
that incorrectly enabled the YC driver for the Lenovo 21J2
laptop, which is a PS platform.

The second commit was reverted because it incorrectly enabled
the YC driver for PS platforms.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

v3 -> v2:
- No changes to content.
- Patches re-prepared using the broonie/sound.git tree's for-next branch.
v2 -> v1:
- No changes to content. Subject lines and commit messages were revised.

On March 13, 2024 at 12:44 AM, Mark Brown wrote:
> This still doesn't apply against my for-6.9 branch.

I've updated the patch using your "for-next" tree.

However, it can't be applied to the "for-6.9" branch,
because the commits to be reverted are not present in "for-6.9".
Below are their hashes:
ed00a69  ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
316a784  ASoC: amd: yc: add new YC platform variant (0x63) support

On March 13, 2024 at 12:50 AM, Mukunda,Vijendar wrote:
> You can prepare patch by cloning below git tree for-next branch.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> 
> while sending patches, please use --cc-cmd=./scripts/get_maintainer.pl along
> with cc list.

Thank you for your guidance. I have updated the patch using
the "for-next" tree as suggested. Additionally, I've 
incorporated the cc-cmd as per your instructions.

Jiawei Wang (2):
  ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
  ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)

-- 
2.39.2

[PATCH v3 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

[Jiawei Wang]

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.

Although the microphone functioned with the YC driver, it
resulted in incorrect driver usage. The Lenovo 21J2 is not a
Yellow Carp platform, but a Pink Sardine platform, which
already has an upstreamed driver.

The microphone on the Lenovo 21J2 operates correctly with the
CONFIG_SND_SOC_AMD_PS flag enabled and does not require the
quirk entry. So this patch removes the quirk entry.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1ab69a53174e..69c68d8e7a6b 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.39.2

[PATCH v3 2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

[Jiawei Wang]

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa,
that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

Mukunda Vijendar [1] points out that revision 0x63 is Pink
Sardine platform, not Yellow Carp. The YC driver should not
be enabled for this platform. This patch prevents the YC
driver from being incorrectly enabled.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 694b8e313902..7af6a349b1d4 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
-- 
2.39.2

Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

[Mukunda,Vijendar]

On 13/03/24 07:28, Jiawei Wang wrote:
> I would like to revert two of my previous commits after
> realizing they incorrectly enabled the Yellow Carp
> (YC) driver for Pink Sardine (PS) platforms.
>
> The first commit was reverted because it added a quirk entry
> that incorrectly enabled the YC driver for the Lenovo 21J2
> laptop, which is a PS platform.
>
> The second commit was reverted because it incorrectly enabled
> the YC driver for PS platforms.
>
> Thanks to Mukunda Vijendar [1] for pointing this out.
>
> Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
>
> v3 -> v2:
> - No changes to content.
> - Patches re-prepared using the broonie/sound.git tree's for-next branch.
> v2 -> v1:
> - No changes to content. Subject lines and commit messages were revised.
>
> On March 13, 2024 at 12:44 AM, Mark Brown wrote:
>> This still doesn't apply against my for-6.9 branch.
> I've updated the patch using your "for-next" tree.
>
> However, it can't be applied to the "for-6.9" branch,
> because the commits to be reverted are not present in "for-6.9".
> Below are their hashes:
> ed00a69  ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
> 316a784  ASoC: amd: yc: add new YC platform variant (0x63) support
>
> On March 13, 2024 at 12:50 AM, Mukunda,Vijendar wrote:
>> You can prepare patch by cloning below git tree for-next branch.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
>>
>> while sending patches, please use --cc-cmd=./scripts/get_maintainer.pl along
>> with cc list.
> Thank you for your guidance. I have updated the patch using
> the "for-next" tree as suggested. Additionally, I've 
> incorporated the cc-cmd as per your instructions.

Hi Mark,

Could you please apply this patch series? Without these changes, functionality
is broken for Pink Sardine (PS) platform.

>
> Jiawei Wang (2):
>   ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
>   ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
>
>  sound/soc/amd/yc/acp6x-mach.c | 7 -------
>  sound/soc/amd/yc/pci-acp6x.c  | 1 -
>  2 files changed, 8 deletions(-)
>

Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On Thu, Mar 14, 2024 at 10:44:27AM +0530, Mukunda,Vijendar wrote:

> Could you please apply this patch series? Without these changes, functionality
> is broken for Pink Sardine (PS) platform.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

[Mark Brown]

On Wed, 13 Mar 2024 09:58:51 +0800, Jiawei Wang wrote:
> I would like to revert two of my previous commits after
> realizing they incorrectly enabled the Yellow Carp
> (YC) driver for Pink Sardine (PS) platforms.
> 
> The first commit was reverted because it added a quirk entry
> that incorrectly enabled the YC driver for the Lenovo 21J2
> laptop, which is a PS platform.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
      commit: 861b3415e4dee06cc00cd1754808a7827b9105bf
[2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
      commit: 37bee1855d0e3b6dbeb8de71895f6f68cad137be

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

[PATCH v2 2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

[Jiawei Wang]

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa,
that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

Mukunda Vijendar [1] points out that revision 0x63 is Pink
Sardine platform, not Yellow Carp. The YC driver should not
be enabled for this platform. This patch prevents the YC
driver from being incorrectly enabled.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 694b8e313902..7af6a349b1d4 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
-- 
2.39.2

Re: [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

[Mark Brown]

On Wed, 13 Mar 2024 00:32:54 +0800, Jiawei Wang wrote:
> I would like to revert two of my previous commits after
> realizing they incorrectly enabled the Yellow Carp
> (YC) driver for Pink Sardine (PS) platforms.
> 
> The first commit was reverted because it added a quirk entry
> that incorrectly enabled the YC driver for the Lenovo 21J2
> laptop, which is a PS platform.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
      commit: 861b3415e4dee06cc00cd1754808a7827b9105bf
[2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
      commit: 37bee1855d0e3b6dbeb8de71895f6f68cad137be

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

[PATCH 2/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Jiawei Wang]

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa.

PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow
Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 694b8e313902..7af6a349b1d4 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
-- 
2.39.2

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Tue, Mar 12, 2024 at 10:33:24AM +0800, Jiawei Wang wrote:
> Please revert my previous two commits:
> 
> ASoC: amd: yc: add new YC platform variant (0x63) support
> [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]
> 
> ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
> [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Luca Stefani]

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic 
input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices 
in the wild.

Thanks, Luca.

On 12/03/24 03:33, Jiawei Wang wrote:
> Please revert my previous two commits:
>
> ASoC: amd: yc: add new YC platform variant (0x63) support
> [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]
>
> ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2
> [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]
>
> PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow
> Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.
>
> The mic on Lenovo 21J2 works after enabling the CONFIG_SND_SOC_AMD_PS
> flag, which I had not enabled when I was writing these patches. 21J2
> does not need to be in this quirk table.
>
> I apologize for the inconvenience caused.
>
> Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
>
> Signed-off-by: Jiawei Wang <me@jwang.link>
>
> Jiawei Wang (2):
>    Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"
>    Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"
>
>   sound/soc/amd/yc/acp6x-mach.c | 7 -------
>   sound/soc/amd/yc/pci-acp6x.c  | 1 -
>   2 files changed, 8 deletions(-)
>

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Greg KH]

On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
> Hello everyone,
> 
> Can those changes be pulled in stable? They're currently breaking mic input
> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
> wild.


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Mukunda,Vijendar]

On 27/03/24 23:39, Greg KH wrote:
> On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
>> Hello everyone,
>>
>> Can those changes be pulled in stable? They're currently breaking mic input
>> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
>> wild.
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
These patches already got merged in V6.9-rc1 release.
Need to be cherry-picked for stable release.

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Greg KH]

On Thu, Mar 28, 2024 at 04:10:38PM +0530, Mukunda,Vijendar wrote:
> On 27/03/24 23:39, Greg KH wrote:
> > On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
> >> Hello everyone,
> >>
> >> Can those changes be pulled in stable? They're currently breaking mic input
> >> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
> >> wild.
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read:
> >     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> >
> > </formletter>
> These patches already got merged in V6.9-rc1 release.
> Need to be cherry-picked for stable release.
> 

What changes exactly?  I do not see any git ids here.

confused,

greg k-h

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Mukunda,Vijendar]

On 28/03/24 17:04, Greg KH wrote:
> On Thu, Mar 28, 2024 at 04:10:38PM +0530, Mukunda,Vijendar wrote:
>> On 27/03/24 23:39, Greg KH wrote:
>>> On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
>>>> Hello everyone,
>>>>
>>>> Can those changes be pulled in stable? They're currently breaking mic input
>>>> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
>>>> wild.
>>> <formletter>
>>>
>>> This is not the correct way to submit patches for inclusion in the
>>> stable kernel tree.  Please read:
>>>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>>> for how to do this properly.
>>>
>>> </formletter>
>> These patches already got merged in V6.9-rc1 release.
>> Need to be cherry-picked for stable release.
>>
> What changes exactly?  I do not see any git ids here.
>
> confused,
>
> greg k-h

Below are the commits.

37bee1855d0e ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
861b3415e4de ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

Re: [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

[Greg KH]

On Thu, Mar 28, 2024 at 05:27:58PM +0530, Mukunda,Vijendar wrote:
> On 28/03/24 17:04, Greg KH wrote:
> > On Thu, Mar 28, 2024 at 04:10:38PM +0530, Mukunda,Vijendar wrote:
> >> On 27/03/24 23:39, Greg KH wrote:
> >>> On Wed, Mar 27, 2024 at 06:56:18PM +0100, Luca Stefani wrote:
> >>>> Hello everyone,
> >>>>
> >>>> Can those changes be pulled in stable? They're currently breaking mic input
> >>>> on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the
> >>>> wild.
> >>> <formletter>
> >>>
> >>> This is not the correct way to submit patches for inclusion in the
> >>> stable kernel tree.  Please read:
> >>>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> >>> for how to do this properly.
> >>>
> >>> </formletter>
> >> These patches already got merged in V6.9-rc1 release.
> >> Need to be cherry-picked for stable release.
> >>
> > What changes exactly?  I do not see any git ids here.
> >
> > confused,
> >
> > greg k-h
> 
> Below are the commits.
> 
> 37bee1855d0e ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
> 861b3415e4de ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
> 
> 
> 

Already asked for here:
	https://lore.kernel.org/r/1b8a991b-ad82-44e6-a76d-a2f81880d549@gmail.com