Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Kailang <kailang@realtek.com>
To: Takashi Iwai <tiwai@suse.de>,
	Dean Matthew Menezes <dean.menezes@utexas.edu>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Linux Sound System <linux-sound@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: RE: No sound on speakers X1 Carbon Gen 12
Date: Mon, 21 Oct 2024 07:56:32 +0000	[thread overview]
Message-ID: <325719ad24c24f1faee12a4cdceec87b@realtek.com> (raw)
In-Reply-To: <877ca2j60l.wl-tiwai@suse.de>



> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Monday, October 21, 2024 2:59 PM
> To: Dean Matthew Menezes <dean.menezes@utexas.edu>
> Cc: Takashi Iwai <tiwai@suse.de>; Kailang <kailang@realtek.com>;
> stable@vger.kernel.org; regressions@lists.linux.dev; Jaroslav Kysela
> <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Linux Sound System
> <linux-sound@vger.kernel.org>; Greg KH <gregkh@linuxfoundation.org>
> Subject: Re: No sound on speakers X1 Carbon Gen 12
> 
> 
> External mail.
> 
> 
> 
> On Mon, 21 Oct 2024 03:30:13 +0200,
> Dean Matthew Menezes wrote:
> >
> > I can confirm that the original fix does not bring back the speaker
> > output.  I have attached both outputs for alsa-info.sh
> 
> Thanks!  This confirms that the only significant difference is the COEF data
> between working and patched-non-working cases.
> 
> Kailang, I guess this model (X1 Carbon Gen 12) isn't with ALC1318, hence your
> quirk rather influences badly.  Or may the GPIO3 workaround have the similar
> effect?

No, I check with our AE. It's ALC1318 include.
And This fixed was testing with Lenovo.

> 
> As of now, the possible fix is to simply remove the quirk entries for ALC1318.
> But I'd need to know which model was targeted for your original fix in commit
> 1e707769df07 and whether the regressed model is with ALC1318.

+	SND_PCI_QUIRK(0x17aa, 0x231e, "Thinkpad", ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318),
+	SND_PCI_QUIRK(0x17aa, 0x231f, "Thinkpad", ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318),

Yes, this model include ALC1318.

> 	
> 
> Takashi

  reply	other threads:[~2024-10-21  7:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAEkK70Tke7UxMEEKgRLMntSYeMqiv0PC8st72VYnBVQD-KcqVw@mail.gmail.com>
     [not found] ` <2024101613-giggling-ceremony-aae7@gregkh>
2024-10-16  5:56   ` No sound on speakers X1 Carbon Gen 12 Linux regression tracking (Thorsten Leemhuis)
2024-10-16  9:21     ` Takashi Iwai
2024-10-16 21:18       ` Dean Matthew Menezes
2024-10-17  8:34         ` Takashi Iwai
2024-10-18 23:14           ` Dean Matthew Menezes
2024-10-19  8:12             ` Takashi Iwai
2024-10-19 23:11               ` Dean Matthew Menezes
2024-10-20  7:19                 ` Takashi Iwai
2024-10-20 14:54                   ` Dean Matthew Menezes
     [not found]                   ` <CAEkK70TWL_me58QZXeJSq+=Ry3jA+CgZJttsgAPz1wP7ywqj6A@mail.gmail.com>
2024-10-20 15:29                     ` Takashi Iwai
2024-10-20 15:33                       ` Takashi Iwai
2024-10-21  1:30                         ` Dean Matthew Menezes
2024-10-21  6:59                           ` Takashi Iwai
2024-10-21  7:56                             ` Kailang [this message]
2024-10-21  8:20                               ` Takashi Iwai
2024-10-21  8:19                             ` Kailang
2024-10-21  8:24                               ` Takashi Iwai
2024-10-21  8:38                                 ` Kailang
2024-10-21  8:56                                   ` Takashi Iwai
2024-10-21  8:59                                     ` Kailang
2024-10-25  1:22                                       ` Dean Matthew Menezes
2024-10-25  7:17                                         ` Takashi Iwai
2024-10-25  7:32                                           ` Kailang
2024-10-26  0:22                                           ` Dean Matthew Menezes
2024-11-08  2:58                                             ` Kailang
2024-11-11  6:57                                             ` Kailang
2024-11-12  3:17                                               ` Dean Matthew Menezes
2024-11-13  6:22                                                 ` Kailang
2024-11-13  6:43                                                   ` Takashi Iwai
2024-10-21  9:31                                     ` Kailang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=325719ad24c24f1faee12a4cdceec87b@realtek.com \
    --to=kailang@realtek.com \
    --cc=dean.menezes@utexas.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox