Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>, vkoul@kernel.org
Cc: yung-chuan.liao@linux.intel.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI
Date: Tue, 24 Feb 2026 11:53:56 +0100	[thread overview]
Message-ID: <3a837f32-018d-4b2c-b308-2504a9aaf41e@linux.dev> (raw)
In-Reply-To: <20260223092048.3695135-1-ckeepax@opensource.cirrus.com>

On 2/23/26 10:20, Charles Keepax wrote:
> If a piece of hardware is disabled in ACPI it shouldn't be added to the
> bus. Add code to handle this similar to other buses like SPI/I2C.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Makes sense!

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

> ---
>  drivers/soundwire/slave.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index f5a3ca3b9dda4..ff763b692078d 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -115,6 +115,9 @@ static bool find_slave(struct sdw_bus *bus,
>  	u64 addr;
>  	int ret;
>  
> +	if (acpi_bus_get_status(adev) || !acpi_dev_ready_for_enumeration(adev))
> +		return false;
> +
>  	ret = acpi_get_local_u64_address(adev->handle, &addr);
>  	if (ret < 0)
>  		return false;


  reply	other threads:[~2026-02-24 11:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23  9:20 [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI Charles Keepax
2026-02-24 10:53 ` Pierre-Louis Bossart [this message]
2026-02-25  7:58 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a837f32-018d-4b2c-b308-2504a9aaf41e@linux.dev \
    --to=pierre-louis.bossart@linux.dev \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox