* [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI
@ 2026-02-23 9:20 Charles Keepax
2026-02-24 10:53 ` Pierre-Louis Bossart
2026-02-25 7:58 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Charles Keepax @ 2026-02-23 9:20 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, linux-sound, linux-kernel,
patches
If a piece of hardware is disabled in ACPI it shouldn't be added to the
bus. Add code to handle this similar to other buses like SPI/I2C.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/soundwire/slave.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index f5a3ca3b9dda4..ff763b692078d 100644
--- a/drivers/soundwire/slave.c
+++ b/drivers/soundwire/slave.c
@@ -115,6 +115,9 @@ static bool find_slave(struct sdw_bus *bus,
u64 addr;
int ret;
+ if (acpi_bus_get_status(adev) || !acpi_dev_ready_for_enumeration(adev))
+ return false;
+
ret = acpi_get_local_u64_address(adev->handle, &addr);
if (ret < 0)
return false;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI
2026-02-23 9:20 [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI Charles Keepax
@ 2026-02-24 10:53 ` Pierre-Louis Bossart
2026-02-25 7:58 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2026-02-24 10:53 UTC (permalink / raw)
To: Charles Keepax, vkoul; +Cc: yung-chuan.liao, linux-sound, linux-kernel, patches
On 2/23/26 10:20, Charles Keepax wrote:
> If a piece of hardware is disabled in ACPI it shouldn't be added to the
> bus. Add code to handle this similar to other buses like SPI/I2C.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Makes sense!
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> ---
> drivers/soundwire/slave.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index f5a3ca3b9dda4..ff763b692078d 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -115,6 +115,9 @@ static bool find_slave(struct sdw_bus *bus,
> u64 addr;
> int ret;
>
> + if (acpi_bus_get_status(adev) || !acpi_dev_ready_for_enumeration(adev))
> + return false;
> +
> ret = acpi_get_local_u64_address(adev->handle, &addr);
> if (ret < 0)
> return false;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI
2026-02-23 9:20 [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI Charles Keepax
2026-02-24 10:53 ` Pierre-Louis Bossart
@ 2026-02-25 7:58 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-02-25 7:58 UTC (permalink / raw)
To: Charles Keepax
Cc: yung-chuan.liao, pierre-louis.bossart, linux-sound, linux-kernel,
patches
On Mon, 23 Feb 2026 09:20:48 +0000, Charles Keepax wrote:
> If a piece of hardware is disabled in ACPI it shouldn't be added to the
> bus. Add code to handle this similar to other buses like SPI/I2C.
>
>
Applied, thanks!
[1/1] soundwire: slave: Don't register devices that are disabled in ACPI
commit: de67b4ea168f01dac24e328aab6be0802a5c96f6
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-25 7:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-23 9:20 [PATCH] soundwire: slave: Don't register devices that are disabled in ACPI Charles Keepax
2026-02-24 10:53 ` Pierre-Louis Bossart
2026-02-25 7:58 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox