Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>,
	tomm.merciai@gmail.com
Cc: linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	John Madieu <john.madieu.xa@bp.renesas.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency
Date: Mon, 3 Aug 2026 15:32:48 +0200	[thread overview]
Message-ID: <44c150f6-b04e-4515-ba71-63780c56c38d@kernel.org> (raw)
In-Reply-To: <20260803132828.3249424-2-tommaso.merciai.xr@bp.renesas.com>

On 03/08/2026 15:28, Tommaso Merciai wrote:
> r9a09g047e57-smarc.dts set clock-frequency for the audio_clkout output,
> but the binding never declared it, so dtbs_check fails:
> 
>   sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties
>   are not allowed ('clock-frequency' was unexpected)

Maybe the DTS is wrong, because property was rejected? Did you check
this? You cannot document ABI post-factum if it was rejected.


> 
> clock-cells is fixed to 0, so only a single audio_clkout applies.
> 
> Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound")
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
>  .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml     | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> index d7fa16554698..6e2b2c93b4b7 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> @@ -42,6 +42,9 @@ properties:
>    "#clock-cells":
>      const: 0
>  
> +  clock-frequency:
> +    description: for audio_clkout

Incomplete, missing type/ref, constraints.

Best regards,
Krzysztof

  reply	other threads:[~2026-08-03 13:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 13:28 [PATCH 0/3] RZ/G3E: Fix dtbs_check failures Tommaso Merciai
2026-08-03 13:28 ` [PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency Tommaso Merciai
2026-08-03 13:32   ` Krzysztof Kozlowski [this message]
2026-08-03 17:19     ` Tommaso Merciai
2026-08-04  6:20       ` Krzysztof Kozlowski
2026-08-03 13:28 ` [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency Tommaso Merciai
2026-08-03 13:33   ` Krzysztof Kozlowski
2026-08-03 16:18     ` Tommaso Merciai
2026-08-03 13:28 ` [PATCH 3/3] arm64: dts: renesas: r9a09g047e57-smarc: Set I2C1 clock frequency to 1 MHz Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44c150f6-b04e-4515-ba71-63780c56c38d@kernel.org \
    --to=krzk@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=john.madieu.xa@bp.renesas.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=tomm.merciai@gmail.com \
    --cc=tommaso.merciai.xr@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox