Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: tomm.merciai@gmail.com, linux-renesas-soc@vger.kernel.org,
	biju.das.jz@bp.renesas.com, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	John Madieu <john.madieu.xa@bp.renesas.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency
Date: Mon, 3 Aug 2026 18:18:28 +0200	[thread overview]
Message-ID: <anC_VPGuGhgyNJXF@tom-desktop> (raw)
In-Reply-To: <a724bb82-f21b-4d9e-8a11-9817f6c97af7@kernel.org>

Hi Krzysztof,
Thanks for your review.

On Mon, Aug 03, 2026 at 03:33:40PM +0200, Krzysztof Kozlowski wrote:
> On 03/08/2026 15:28, Tommaso Merciai wrote:
> > clock-frequency is a required property of the renesas,riic binding, but
> > it is not set in any of the I2C nodes, so dtbs_check fails on boards
> > that enable an I2C controller without providing a rate:
> > 
> >   r9a09g047e57-smarc.dtb: i2c@14400800 (renesas,riic-r9a09g047):
> >   'clock-frequency' is a required property
> > 
> > Add the standard mode rate (100 kHz) to all I2C nodes. Boards that
> > need a faster bus can still override it.
> 
> Why? Binding looks wrong. It clearly says that property can be missing
> and is required.

Good catch, I missed this.

Looking closer, the description is correct: i2c-riic calls
i2c_parse_fw_timings() with use_defaults set, so the core falls back to
I2C_MAX_STANDARD_MODE_FREQ when the property is absent.

So the right fix is to drop clock-frequency from the required
properties instead. I will do that in v2.

Kind regards,
Tommaso

> 
> 
> Best regards,
> Krzysztof

  reply	other threads:[~2026-08-03 16:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 13:28 [PATCH 0/3] RZ/G3E: Fix dtbs_check failures Tommaso Merciai
2026-08-03 13:28 ` [PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency Tommaso Merciai
2026-08-03 13:32   ` Krzysztof Kozlowski
2026-08-03 17:19     ` Tommaso Merciai
2026-08-04  6:20       ` Krzysztof Kozlowski
2026-08-03 13:28 ` [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency Tommaso Merciai
2026-08-03 13:33   ` Krzysztof Kozlowski
2026-08-03 16:18     ` Tommaso Merciai [this message]
2026-08-03 13:28 ` [PATCH 3/3] arm64: dts: renesas: r9a09g047e57-smarc: Set I2C1 clock frequency to 1 MHz Tommaso Merciai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anC_VPGuGhgyNJXF@tom-desktop \
    --to=tommaso.merciai.xr@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=john.madieu.xa@bp.renesas.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=tomm.merciai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox