[PATCH 0/3] RZ/G3E: Fix dtbs_check failures

[PATCH 0/3] RZ/G3E: Fix dtbs_check failures

[Tommaso Merciai]

Dear All,

This series fix the following dtbs_check failures:

sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties
  are not allowed ('clock-frequency' was unexpected)

i2c@14400800 (renesas,riic-r9a09g047): 'clock-frequency' is a
  required property

Additionally, set the i2c1 clock frequency to 1 MHz in r9a09g047e57-smarc.dts.

Kind regards,
Tommaso

Tommaso Merciai (3):
  ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout
    clock-frequency
  arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency
  arm64: dts: renesas: r9a09g047e57-smarc: Set I2C1 clock frequency to 1
    MHz

 .../bindings/sound/renesas,r9a09g047-sound.yaml          | 3 +++
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi               | 9 +++++++++
 arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts       | 2 ++
 3 files changed, 14 insertions(+)

-- 
2.54.0

[PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency

[Tommaso Merciai]

r9a09g047e57-smarc.dts set clock-frequency for the audio_clkout output,
but the binding never declared it, so dtbs_check fails:

  sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties
  are not allowed ('clock-frequency' was unexpected)

clock-cells is fixed to 0, so only a single audio_clkout applies.

Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound")
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
 .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml     | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
index d7fa16554698..6e2b2c93b4b7 100644
--- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
@@ -42,6 +42,9 @@ properties:
   "#clock-cells":
     const: 0
 
+  clock-frequency:
+    description: for audio_clkout
+
   "#address-cells":
     const: 1
 
-- 
2.54.0

[PATCH 2/3] arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency

[Tommaso Merciai]

clock-frequency is a required property of the renesas,riic binding, but
it is not set in any of the I2C nodes, so dtbs_check fails on boards
that enable an I2C controller without providing a rate:

  r9a09g047e57-smarc.dtb: i2c@14400800 (renesas,riic-r9a09g047):
  'clock-frequency' is a required property

Add the standard mode rate (100 kHz) to all I2C nodes. Boards that
need a faster bus can still override it.

Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
index 73757e8e2197..b9a707f04004 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
@@ -1538,6 +1538,7 @@ i2c0: i2c@14400400 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x94>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x98>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1559,6 +1560,7 @@ i2c1: i2c@14400800 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x95>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x99>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1580,6 +1582,7 @@ i2c2: i2c@14400c00 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x96>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x9a>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1601,6 +1604,7 @@ i2c3: i2c@14401000 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x97>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x9b>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1622,6 +1626,7 @@ i2c4: i2c@14401400 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x98>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x9c>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1643,6 +1648,7 @@ i2c5: i2c@14401800 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x99>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x9d>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1664,6 +1670,7 @@ i2c6: i2c@14401c00 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x9a>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x9e>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1685,6 +1692,7 @@ i2c7: i2c@14402000 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x9b>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0x9f>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
@@ -1706,6 +1714,7 @@ i2c8: i2c@11c01000 {
 			interrupt-names = "tei", "ri", "ti", "spi", "sti",
 					  "naki", "ali", "tmoi";
 			clocks = <&cpg CPG_MOD 0x93>;
+			clock-frequency = <100000>;
 			resets = <&cpg 0xa0>;
 			power-domains = <&cpg>;
 			#address-cells = <1>;
-- 
2.54.0

[PATCH 3/3] arm64: dts: renesas: r9a09g047e57-smarc: Set I2C1 clock frequency to 1 MHz

[Tommaso Merciai]

On the SMARC carrier board I2C1 only carries the DA7212 audio codec.
Override the 100 kHz SoC default with 1 MHz.

Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
index 4eed095b683b..469a6282b2a3 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
@@ -147,6 +147,8 @@ &i2c0 {
 };
 
 &i2c1 {
+	clock-frequency = <1000000>;
+
 	da7212: codec@1a {
 		compatible = "dlg,da7212";
 		#sound-dai-cells = <0>;
-- 
2.54.0

Re: [PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency

[Krzysztof Kozlowski]

On 03/08/2026 15:28, Tommaso Merciai wrote:
> r9a09g047e57-smarc.dts set clock-frequency for the audio_clkout output,
> but the binding never declared it, so dtbs_check fails:
> 
>   sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties
>   are not allowed ('clock-frequency' was unexpected)

Maybe the DTS is wrong, because property was rejected? Did you check
this? You cannot document ABI post-factum if it was rejected.


> 
> clock-cells is fixed to 0, so only a single audio_clkout applies.
> 
> Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound")
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
>  .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml     | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> index d7fa16554698..6e2b2c93b4b7 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> @@ -42,6 +42,9 @@ properties:
>    "#clock-cells":
>      const: 0
>  
> +  clock-frequency:
> +    description: for audio_clkout

Incomplete, missing type/ref, constraints.

Best regards,
Krzysztof

Re: [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency

[Krzysztof Kozlowski]

On 03/08/2026 15:28, Tommaso Merciai wrote:
> clock-frequency is a required property of the renesas,riic binding, but
> it is not set in any of the I2C nodes, so dtbs_check fails on boards
> that enable an I2C controller without providing a rate:
> 
>   r9a09g047e57-smarc.dtb: i2c@14400800 (renesas,riic-r9a09g047):
>   'clock-frequency' is a required property
> 
> Add the standard mode rate (100 kHz) to all I2C nodes. Boards that
> need a faster bus can still override it.

Why? Binding looks wrong. It clearly says that property can be missing
and is required.


Best regards,
Krzysztof

Re: [PATCH 2/3] arm64: dts: renesas: r9a09g047: Add missing I2C clock-frequency

[Tommaso Merciai]

Hi Krzysztof,
Thanks for your review.

On Mon, Aug 03, 2026 at 03:33:40PM +0200, Krzysztof Kozlowski wrote:
> On 03/08/2026 15:28, Tommaso Merciai wrote:
> > clock-frequency is a required property of the renesas,riic binding, but
> > it is not set in any of the I2C nodes, so dtbs_check fails on boards
> > that enable an I2C controller without providing a rate:
> > 
> >   r9a09g047e57-smarc.dtb: i2c@14400800 (renesas,riic-r9a09g047):
> >   'clock-frequency' is a required property
> > 
> > Add the standard mode rate (100 kHz) to all I2C nodes. Boards that
> > need a faster bus can still override it.
> 
> Why? Binding looks wrong. It clearly says that property can be missing
> and is required.

Good catch, I missed this.

Looking closer, the description is correct: i2c-riic calls
i2c_parse_fw_timings() with use_defaults set, so the core falls back to
I2C_MAX_STANDARD_MODE_FREQ when the property is absent.

So the right fix is to drop clock-frequency from the required
properties instead. I will do that in v2.

Kind regards,
Tommaso

> 
> 
> Best regards,
> Krzysztof

Re: [PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency

[Tommaso Merciai]

Hi Krzysztof,
Thanks for your review.

On Mon, Aug 03, 2026 at 03:32:48PM +0200, Krzysztof Kozlowski wrote:
> On 03/08/2026 15:28, Tommaso Merciai wrote:
> > r9a09g047e57-smarc.dts set clock-frequency for the audio_clkout output,
> > but the binding never declared it, so dtbs_check fails:
> > 
> >   sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties
> >   are not allowed ('clock-frequency' was unexpected)
> 
> Maybe the DTS is wrong, because property was rejected? Did you check
> this? You cannot document ABI post-factum if it was rejected.
> 
> 
> > 
> > clock-cells is fixed to 0, so only a single audio_clkout applies.
> > 
> > Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound")
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > ---
> >  .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml     | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> > index d7fa16554698..6e2b2c93b4b7 100644
> > --- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> > @@ -42,6 +42,9 @@ properties:
> >    "#clock-cells":
> >      const: 0
> >  
> > +  clock-frequency:
> > +    description: for audio_clkout
> 
> Incomplete, missing type/ref, constraints.

renesas,r9a09g047-sound is handled by sound/soc/renesas/rcar/core.c [1],
and "clock-frequency" is read by rsnd_adg_get_clkout() [2]. The same
property is already documented for R-Car in
Documentation/devicetree/bindings/sound/renesas,rsnd.yaml [3].

Please correct me if I'm missing somenthing.

[1] https://elixir.bootlin.com/linux/v7.2-rc5/source/sound/soc/renesas/rcar/core.c#L109
[2] https://elixir.bootlin.com/linux/v7.2-rc5/source/sound/soc/renesas/rcar/adg.c#L690
[3] https://elixir.bootlin.com/linux/v7.2-rc5/source/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml#L89

Kind regards,
Tommaso

> 
> Best regards,
> Krzysztof

Re: [PATCH 1/3] ASoC: dt-bindings: renesas,r9a09g047-sound: Document audio_clkout clock-frequency

[Krzysztof Kozlowski]

On 03/08/2026 19:19, Tommaso Merciai wrote:
> Hi Krzysztof,
> Thanks for your review.
> 
> On Mon, Aug 03, 2026 at 03:32:48PM +0200, Krzysztof Kozlowski wrote:
>> On 03/08/2026 15:28, Tommaso Merciai wrote:
>>> r9a09g047e57-smarc.dts set clock-frequency for the audio_clkout output,
>>> but the binding never declared it, so dtbs_check fails:
>>>
>>>   sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties
>>>   are not allowed ('clock-frequency' was unexpected)
>>
>> Maybe the DTS is wrong, because property was rejected? Did you check
>> this? You cannot document ABI post-factum if it was rejected.
>>
>>
>>>
>>> clock-cells is fixed to 0, so only a single audio_clkout applies.
>>>
>>> Fixes: a86fd3c20218 ("ASoC: dt-bindings: sound: Add DT binding for RZ/G3E sound")
>>> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>>> ---
>>>  .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml     | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
>>> index d7fa16554698..6e2b2c93b4b7 100644
>>> --- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
>>> @@ -42,6 +42,9 @@ properties:
>>>    "#clock-cells":
>>>      const: 0
>>>  
>>> +  clock-frequency:
>>> +    description: for audio_clkout
>>
>> Incomplete, missing type/ref, constraints.
> 
> renesas,r9a09g047-sound is handled by sound/soc/renesas/rcar/core.c [1],
> and "clock-frequency" is read by rsnd_adg_get_clkout() [2]. The same
> property is already documented for R-Car in
> Documentation/devicetree/bindings/sound/renesas,rsnd.yaml [3].

But was the property rejected? I am repeating myself...

Best regards,
Krzysztof