From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Andreas Dannenberg <dannenberg@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: Axel Lin <axel.lin@ingics.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: tas2552: fix dBscale-min declaration
Date: Tue, 06 Oct 2015 11:37:12 +0000 [thread overview]
Message-ID: <5613B268.6040701@ti.com> (raw)
In-Reply-To: <1444075214-21206-1-git-send-email-dannenberg@ti.com>
On 10/05/2015 11:00 PM, Andreas Dannenberg wrote:
> The minimum volume level for the TAS2552 (control register value 0x00)
> is -7dB however the driver declares it as -0.07dB.
>
> Running amixer before the patch reports:
> dBscale-min=-0.07dB,step=1.00dB,mute=0
>
> Running amixer with the patch applied reports:
> dBscale-min=-7.00dB,step=1.00dB,mute=0
I have not noticed this when fixing the mute parameter.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
> sound/soc/codecs/tas2552.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
> index e3a0bca..cc1d398 100644
> --- a/sound/soc/codecs/tas2552.c
> +++ b/sound/soc/codecs/tas2552.c
> @@ -549,7 +549,7 @@ static struct snd_soc_dai_driver tas2552_dai[] = {
> /*
> * DAC digital volumes. From -7 to 24 dB in 1 dB steps
> */
> -static DECLARE_TLV_DB_SCALE(dac_tlv, -7, 100, 0);
> +static DECLARE_TLV_DB_SCALE(dac_tlv, -700, 100, 0);
>
> static const char * const tas2552_din_source_select[] = {
> "Muted",
>
--
Péter
prev parent reply other threads:[~2015-10-06 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 20:00 [PATCH] ASoC: codecs: tas2552: fix dBscale-min declaration Andreas Dannenberg
2015-10-06 11:37 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613B268.6040701@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=dannenberg@ti.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox