* [PATCH] ASoC: codecs: tas2552: fix dBscale-min declaration
@ 2015-10-05 20:00 Andreas Dannenberg
2015-10-06 11:37 ` Peter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Dannenberg @ 2015-10-05 20:00 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Peter Ujfalusi, Axel Lin, Lars-Peter Clausen, Uwe Kleine-Koenig,
alsa-devel, linux-sound, Andreas Dannenberg
The minimum volume level for the TAS2552 (control register value 0x00)
is -7dB however the driver declares it as -0.07dB.
Running amixer before the patch reports:
dBscale-min=-0.07dB,step=1.00dB,mute=0
Running amixer with the patch applied reports:
dBscale-min=-7.00dB,step=1.00dB,mute=0
Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
---
sound/soc/codecs/tas2552.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index e3a0bca..cc1d398 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -549,7 +549,7 @@ static struct snd_soc_dai_driver tas2552_dai[] = {
/*
* DAC digital volumes. From -7 to 24 dB in 1 dB steps
*/
-static DECLARE_TLV_DB_SCALE(dac_tlv, -7, 100, 0);
+static DECLARE_TLV_DB_SCALE(dac_tlv, -700, 100, 0);
static const char * const tas2552_din_source_select[] = {
"Muted",
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: codecs: tas2552: fix dBscale-min declaration
2015-10-05 20:00 [PATCH] ASoC: codecs: tas2552: fix dBscale-min declaration Andreas Dannenberg
@ 2015-10-06 11:37 ` Peter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2015-10-06 11:37 UTC (permalink / raw)
To: Andreas Dannenberg, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: Axel Lin, Lars-Peter Clausen, Uwe Kleine-Koenig, alsa-devel,
linux-sound
On 10/05/2015 11:00 PM, Andreas Dannenberg wrote:
> The minimum volume level for the TAS2552 (control register value 0x00)
> is -7dB however the driver declares it as -0.07dB.
>
> Running amixer before the patch reports:
> dBscale-min=-0.07dB,step=1.00dB,mute=0
>
> Running amixer with the patch applied reports:
> dBscale-min=-7.00dB,step=1.00dB,mute=0
I have not noticed this when fixing the mute parameter.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
> sound/soc/codecs/tas2552.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
> index e3a0bca..cc1d398 100644
> --- a/sound/soc/codecs/tas2552.c
> +++ b/sound/soc/codecs/tas2552.c
> @@ -549,7 +549,7 @@ static struct snd_soc_dai_driver tas2552_dai[] = {
> /*
> * DAC digital volumes. From -7 to 24 dB in 1 dB steps
> */
> -static DECLARE_TLV_DB_SCALE(dac_tlv, -7, 100, 0);
> +static DECLARE_TLV_DB_SCALE(dac_tlv, -700, 100, 0);
>
> static const char * const tas2552_din_source_select[] = {
> "Muted",
>
--
Péter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-06 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-05 20:00 [PATCH] ASoC: codecs: tas2552: fix dBscale-min declaration Andreas Dannenberg
2015-10-06 11:37 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox