From: Mark Brown <broonie@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Michal Simek <michal.simek@amd.com>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers
Date: Thu, 29 Jan 2026 17:27:58 +0000 [thread overview]
Message-ID: <700e4e67-a2ed-4b37-a00b-303bbc5ee6cd@sirena.org.uk> (raw)
In-Reply-To: <20260129172315.3871602-3-sean.anderson@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Thu, Jan 29, 2026 at 12:23:15PM -0500, Sean Anderson wrote:
> - ret = of_property_read_u32(node, "xlnx,num-channels", &drv_data->channels);
> - ret = of_property_read_u32(node, "xlnx,dwidth", &drv_data->data_width);
Given that the properties already exist it seems wise to continue to
parse them if available and prefer them over what we read from the
hardware, it would not shock me to discover that hardware exists where
the registers are inaccurate or need overriding due to bugs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-01-29 17:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 17:23 [PATCH 0/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers Sean Anderson
2026-01-29 17:23 ` [PATCH 1/2] dt-bindings: sound: xlnx,i2s: Make discoverable parameters optional Sean Anderson
2026-01-29 17:37 ` Conor Dooley
2026-01-29 17:23 ` [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers Sean Anderson
2026-01-29 17:27 ` Mark Brown [this message]
2026-01-29 17:46 ` Sean Anderson
2026-01-29 18:09 ` Mark Brown
2026-01-29 18:17 ` Sean Anderson
2026-01-29 18:46 ` Mark Brown
2026-01-30 8:19 ` Michal Simek
2026-02-02 17:52 ` Peter Korsgaard
2026-01-29 19:58 ` Andrew Lunn
2026-01-29 20:13 ` Sean Anderson
2026-01-29 17:37 ` Andrew Lunn
2026-01-29 17:51 ` Sean Anderson
2026-01-30 6:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=700e4e67-a2ed-4b37-a00b-303bbc5ee6cd@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=perex@perex.cz \
--cc=sean.anderson@linux.dev \
--cc=tiwai@suse.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox