Re: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Mark" == Mark Brown <broonie@kernel.org> writes:

Hi,

 >> and go "Ah, there are the properties I need." On some Xilinx cores this
 >> is the only way to discover certain properties, so people have gotten into
 >> the habit of using them even when these properties can be read from the
 >> device itself.

 > Oh.  If the properties are there it's reasonable and sensible to use
 > them, them being redundant is a concern when specifying the binding but
 > once things are there any discrepency should usually be resolved in
 > favour of the binding.

I also think making the hardware registers take priority over the DTS
makes sense (E.G. what this patch does), as the DTS can get out of sync
with the (programmable) HW configuration if the FPGA config is changed
and a DTS update is forgotten.


 >> I would rather remove it for the code size reduction and simplication.

 > We're talking a couple of function calls with no error handling here,
 > I'm not sure anyone concerned about that kind of impact is running
 > Linux.

Agreed, but the HW registers should by definition always be in sync with
the IP block configuration, where the DTS update involves a manual
update so it may not, so the HW registers are more reliable than the DTS.

-- 
Bye, Peter Korsgaard