From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: Simon Trimmer <simont@opensource.cirrus.com>,
<linux-sound@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH] ASoC: cs35l56: Accept values greater than 0 as IRQ numbers
Date: Tue, 18 Jun 2024 17:06:01 +0100 [thread overview]
Message-ID: <7032b425-c2e3-4258-92f9-8035b354ea8b@opensource.cirrus.com> (raw)
In-Reply-To: <a2946d8a-1ead-4514-b1a4-9c04e37cd8a8@sirena.org.uk>
On 18/06/2024 17:00, Mark Brown wrote:
> On Mon, Jun 17, 2024 at 03:54:04PM +0100, Richard Fitzgerald wrote:
>
>> So 0 is invalid. Question is: is it also valid to pass -ve errors, or is
>> 0 the _only_ invalid value?
>
> Negative values should be fine.
In that case this patch is necessary so we reject negative values
as not an IRQ. Otherwise we'll try to request a non-existant IRQ and
fail with an error.
next prev parent reply other threads:[~2024-06-18 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 13:53 [PATCH] ASoC: cs35l56: Accept values greater than 0 as IRQ numbers Simon Trimmer
2024-06-17 14:04 ` Mark Brown
2024-06-17 14:33 ` Richard Fitzgerald
2024-06-17 14:48 ` Simon Trimmer
2024-06-17 14:54 ` Richard Fitzgerald
2024-06-18 16:00 ` Mark Brown
2024-06-18 16:06 ` Richard Fitzgerald [this message]
2024-06-18 15:58 ` Mark Brown
2024-06-18 16:07 ` Richard Fitzgerald
2024-06-19 9:44 ` Richard Fitzgerald
2024-06-19 10:22 ` Mark Brown
2024-06-19 10:24 ` Richard Fitzgerald
2024-06-19 11:48 ` Mark Brown
2024-06-19 13:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7032b425-c2e3-4258-92f9-8035b354ea8b@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox