From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH 2/2] ASoC: SDCA: fix finding wrong entity
Date: Wed, 25 Mar 2026 10:51:25 +0000 [thread overview]
Message-ID: <738a67aa724b40cbb94764cc3567a5b0@realtek.com> (raw)
In-Reply-To: <acO1+yld0mhWjxvW@opensource.cirrus.com>
> > This patch fixes an issue like:
> > where searching for the entity 'FU 11' could incorrectly match 'FU 113' first.
> > The driver should first perform an exact match on the full string name.
> > If no exact match is found, it can then fall back to a partial match.
> >
> > Signed-off-by: Shuming Fan <shumingf@realtek.com>
>
> Could use a fixes tag:
>
> Fixes: 48fa77af2f4a ("ASoC: SDCA: Add terminal type into input/output widget
> name")
Will add the fixed tag.
> > ---
> > sound/soc/sdca/sdca_functions.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/sdca/sdca_functions.c
> > b/sound/soc/sdca/sdca_functions.c index 0b7d97dcb236..0787bf024d21
> > 100644
> > --- a/sound/soc/sdca/sdca_functions.c
> > +++ b/sound/soc/sdca/sdca_functions.c
> > @@ -1602,9 +1602,18 @@ static struct sdca_entity
> *find_sdca_entity_by_label(struct sdca_function_data *
> > const char
> > *entity_label) {
> > int i;
> > + struct sdca_entity *entity = NULL;
>
> Minor nit put this above the int i;
Sure, will fix
> But looks like a good fix, thanks for spotting that.
>
> Thanks,
> Charles
prev parent reply other threads:[~2026-03-25 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 9:20 [PATCH 2/2] ASoC: SDCA: fix finding wrong entity shumingf
2026-03-25 10:16 ` Charles Keepax
2026-03-25 10:51 ` Shuming [范書銘] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=738a67aa724b40cbb94764cc3567a5b0@realtek.com \
--to=shumingf@realtek.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox