Re: [PATCH 2/2] ASoC: SDCA: fix finding wrong entity

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, Mar 25, 2026 at 05:20:28PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> This patch fixes an issue like:
> where searching for the entity 'FU 11' could incorrectly match 'FU 113' first.
> The driver should first perform an exact match on the full string name.
> If no exact match is found, it can then fall back to a partial match.
> 
> Signed-off-by: Shuming Fan <shumingf@realtek.com>

Could use a fixes tag:

Fixes: 48fa77af2f4a ("ASoC: SDCA: Add terminal type into input/output widget name")

> ---
>  sound/soc/sdca/sdca_functions.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_functions.c
> index 0b7d97dcb236..0787bf024d21 100644
> --- a/sound/soc/sdca/sdca_functions.c
> +++ b/sound/soc/sdca/sdca_functions.c
> @@ -1602,9 +1602,18 @@ static struct sdca_entity *find_sdca_entity_by_label(struct sdca_function_data *
>  						     const char *entity_label)
>  {
>  	int i;
> +	struct sdca_entity *entity = NULL;

Minor nit put this above the int i;

But looks like a good fix, thanks for spotting that.

Thanks,
Charles