[RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200

[RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200

[julianbraha]

SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
dependency, I2C is enabled. This causes an unmet dependency when
SND_SOC_DB1200 is enabled without I2C.

Let's add a dependency on I2C, as similar options in this subsystem do.

This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.

Fixes: 9dc15f81baf2 ("ASoC: wm8731: Factor out the I2C and SPI bus code into separate modules")

Signed-off-by: julianbraha <julianbraha@gmail.com>
---
 sound/soc/au1x/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/au1x/Kconfig b/sound/soc/au1x/Kconfig
index a7630897bc0b..e8986da24d64 100644
--- a/sound/soc/au1x/Kconfig
+++ b/sound/soc/au1x/Kconfig
@@ -55,6 +55,7 @@ config SND_SOC_DB1000
 
 config SND_SOC_DB1200
 	tristate "DB1200/DB1300/DB1550 Audio support"
+	depends on I2C
 	depends on SND_SOC_AU1XPSC
 	select SND_SOC_AU1XPSC_AC97
 	select SND_SOC_AC97_CODEC
-- 
2.55.0

Re: [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200

[Arnd Bergmann]

On Wed, Sep 9, 2026, at 14:56, julianbraha wrote:
> SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
> dependency, I2C is enabled. This causes an unmet dependency when
> SND_SOC_DB1200 is enabled without I2C.
>
> Let's add a dependency on I2C, as similar options in this subsystem do.
>
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 9dc15f81baf2 ("ASoC: wm8731: Factor out the I2C and SPI bus code 
> into separate modules")
>
> Signed-off-by: julianbraha <julianbraha@gmail.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Wed, Sep 09, 2026 at 01:56:36PM +0100, julianbraha wrote:
> SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
> dependency, I2C is enabled. This causes an unmet dependency when
> SND_SOC_DB1200 is enabled without I2C.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [RESEND PATCH] ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200

[Julian Braha]

On 9/9/26 14:06, Mark Brown wrote:
> On Wed, Sep 09, 2026 at 01:56:36PM +0100, julianbraha wrote:
>> SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its
>> dependency, I2C is enabled. This causes an unmet dependency when
>> SND_SOC_DB1200 is enabled without I2C.
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.

Got it, will do better on this. Thanks for your feedback, Mark.

- Julian Braha