* [PATCH] ALSA: hda/realtek: fix micmute LED reversed on HP Abe and Bantie
@ 2025-12-17 2:52 Dirk Su
2025-12-17 9:06 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dirk Su @ 2025-12-17 2:52 UTC (permalink / raw)
Cc: Dirk Su, Jaroslav Kysela, Takashi Iwai, Stefan Binding,
Kailang Yang, Chris Chiu, Edip Hazuri, linux-sound, linux-kernel
Quirk ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO make mute/micmute LEDs
on HP Abe and Bantie functional. But the micmute LED's function
is reversed, LED will be on when Mic enabled and off when Mic
disabled. Create a new function to fix the micmute LED reversed
issue.
Signed-off-by: Dirk Su <dirk.su@canonical.com>
---
sound/hda/codecs/realtek/alc269.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 171a71457ec3b..75489a9394383 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -1656,6 +1656,18 @@ static void alc236_fixup_hp_mute_led_micmute_vref(struct hda_codec *codec,
alc236_fixup_hp_micmute_led_vref(codec, fix, action);
}
+static void alc236_fixup_hp_mute_led_micmute_gpio(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ struct alc_spec *spec = codec->spec;
+
+ if (action == HDA_FIXUP_ACT_PRE_PROBE)
+ spec->micmute_led_polarity = 1;
+
+ alc236_fixup_hp_mute_led_coefbit2(codec, fix, action);
+ alc_fixup_hp_gpio_led(codec, action, 0x00, 0x01);
+}
+
static inline void alc298_samsung_write_coef_pack(struct hda_codec *codec,
const unsigned short coefs[2])
{
@@ -5326,9 +5338,7 @@ static const struct hda_fixup alc269_fixups[] = {
},
[ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO] = {
.type = HDA_FIXUP_FUNC,
- .v.func = alc236_fixup_hp_mute_led_coefbit2,
- .chained = true,
- .chain_id = ALC236_FIXUP_HP_GPIO_LED,
+ .v.func = alc236_fixup_hp_mute_led_micmute_gpio,
},
[ALC236_FIXUP_LENOVO_INV_DMIC] = {
.type = HDA_FIXUP_FUNC,
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix micmute LED reversed on HP Abe and Bantie
2025-12-17 2:52 [PATCH] ALSA: hda/realtek: fix micmute LED reversed on HP Abe and Bantie Dirk Su
@ 2025-12-17 9:06 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-12-17 9:06 UTC (permalink / raw)
To: Dirk Su
Cc: Jaroslav Kysela, Takashi Iwai, Stefan Binding, Kailang Yang,
Chris Chiu, Edip Hazuri, linux-sound, linux-kernel
On Wed, 17 Dec 2025 03:52:44 +0100,
Dirk Su wrote:
>
> Quirk ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO make mute/micmute LEDs
> on HP Abe and Bantie functional. But the micmute LED's function
> is reversed, LED will be on when Mic enabled and off when Mic
> disabled. Create a new function to fix the micmute LED reversed
> issue.
>
> Signed-off-by: Dirk Su <dirk.su@canonical.com>
Applied now with Fixes tag. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-17 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-17 2:52 [PATCH] ALSA: hda/realtek: fix micmute LED reversed on HP Abe and Bantie Dirk Su
2025-12-17 9:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox