From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Xi Wang <xi.wang@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
stable@vger.kernel.org,
syzbot+d56178c27a4710960820@syzkaller.appspotmail.com
Subject: Re: [PATCH] ALSA: usb-audio: stop parsing UAC2 rates at MAX_NR_RATES
Date: Thu, 16 Apr 2026 10:57:31 +0200 [thread overview]
Message-ID: <87340vffk4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260415-usb-audio-uac2-rate-cap-v1-1-5ecbafc120d8@gmail.com>
On Wed, 15 Apr 2026 17:04:53 +0200,
Cássio Gabriel wrote:
>
> parse_uac2_sample_rate_range() caps the number of enumerated
> rates at MAX_NR_RATES, but it only breaks out of the current
> rate loop. A malformed UAC2 RANGE response with additional
> triplets continues parsing the remaining triplets and repeatedly
> prints "invalid uac2 rates" while probe still holds
> register_mutex.
>
> Stop the whole parse once the cap is reached and return the
> number of rates collected so far.
>
> Fixes: 4fa0e81b8350 ("ALSA: usb-audio: fix possible hang and overflow in parse_uac2_sample_rate_range()")
> Cc: stable@vger.kernel.org
> Reported-by: syzbot+d56178c27a4710960820@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=d56178c27a4710960820
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2026-04-16 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 15:04 [PATCH] ALSA: usb-audio: stop parsing UAC2 rates at MAX_NR_RATES Cássio Gabriel
2026-04-16 8:57 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87340vffk4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=syzbot+d56178c27a4710960820@syzkaller.appspotmail.com \
--cc=tiwai@suse.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox