From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
Kiseok Jo <kiseok.jo@irondevice.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Peter\ Ujfalusi" <peter.ujfalusi@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
"Vijendar\ Mukunda" <Vijendar.Mukunda@amd.com>,
Benjamin Bara <benjamin.bara@skidata.com>,
<linux-sound@vger.kernel.org>
Subject: Re: [PATCH 1/7] ASoC: soc-component: use dapm->component instead of container_of()
Date: Fri, 11 Apr 2025 02:04:23 +0000 [thread overview]
Message-ID: <8734efh2s8.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <871pu0na09.wl-kuninori.morimoto.gx@renesas.com>
Hi Cezary, again
> > I'd rather focus on 'struct snd_soc_dapm_context' exclusively. A valid
> > pointer to this type is required for many functions found in
> > include/sound/ yet the struct is more of framework-internal entity.
> > Strict separation between dapm-context "for the framework" from
> > dapm-context "for the user" would grant better readability benefits.
I have checked each drivers which is using struct snd_soc_dapm_context.
It seems not only framework but many user drivers need to use/access to it.
So separation seems impossible, and dropping wrapper is maybe not good idea.
But I can understand that it will be very longer code :)
x = dapm->component;
x = snd_soc_dapm_to_component(dapm);
For me personally, wrapper function/macro is not so bad idea.
It is much safer to use function/macro rather than touching them directly.
Anyway, I will try to keep current patch-set style.
But any comment is very welcome.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2025-04-11 2:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 2:56 [PATCH 0/7] ASoC: use snd_soc_dapm_to_component() Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 1/7] ASoC: soc-component: use dapm->component instead of container_of() Kuninori Morimoto
2025-04-09 7:59 ` Cezary Rojewski
2025-04-10 0:19 ` Kuninori Morimoto
2025-04-11 2:04 ` Kuninori Morimoto [this message]
2025-04-11 9:07 ` Cezary Rojewski
2025-04-13 23:39 ` Kuninori Morimoto
2025-04-14 2:01 ` Kuninori Morimoto
2025-04-17 9:34 ` Cezary Rojewski
2025-04-17 23:00 ` Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 2/7] ASoC: amd: use snd_soc_dapm_to_component() Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 3/7] ASoC: sma1307: " Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 4/7] ASoC: intel: " Kuninori Morimoto
2025-04-09 8:03 ` Cezary Rojewski
2025-04-10 0:20 ` Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 5/7] ASoC: mediatek: " Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 6/7] ASoC: soc-dapm: " Kuninori Morimoto
2025-04-09 2:57 ` [PATCH 7/7] ASoC: soc-topology: " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734efh2s8.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.bara@skidata.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kiseok.jo@irondevice.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox