Re: [PATCH 1/7] ASoC: soc-component: use dapm->component instead of container_of()

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2025-04-14 4:01 AM, Kuninori Morimoto wrote:
> 
> Hi Cezary, Mark
> 
>> 	dapm->card
>> 	dapm->component
>> 	dapm->dev
>> 	dapm->bias_level
>> 	dapm->idle_bias_off
> (snip)
>> 	snd_soc_dapm_new_controls()
>> 	snd_soc_dapm_add_routes()
>> 	snd_soc_dapm_disable_pin_unlocked()
>> 	snd_soc_dapm_sync_unlocked()
>> 	snd_soc_dapm_mutex_lock()
>> 	...
> (snip)
>> To hide dapm_context details from user driver
>> 	- define struct dapm_context name only in include/sound.
>> 	- define struct dapm_context details in soc_dapm.c
>>
>> To use dapm_context related feature in user driver
>> 	- use snd_soc_dapm_xxx() function in all user driver
> 
> We have 2 way to get dapm_context (card vs component).
> So if soc-dapm has function for these, we can remove dapm_context from
> header (Not 100% sure for now, but maybe).
> It will be big patch-set. I'm OK to create it. But what do you think ?
> 
> --- soc-dapm.c -------
> 
> static __snd_soc_dapm_xxx(dapm_context, ...)
> {
> 	...
> }
> 
> int snd_soc_dapm_xxx_for_card(card, xxx) {
> 	__snd_soc_dapm_xxx(card->dapm, ...);
> }
> 
> int snd_soc_dapm_xxx_for_component(component, xxx) {
> 	__snd_soc_dapm_xxx(component->dapm, ...);
> }
> 
> --- soc-dapm.h -------
> 
> #define snd_soc_dapm_xxx(x) _Generic((x, ...),			\
> 	struct snd_soc_card * :		snd_soc_dapm_xxx_for_card, \
> 	struct snd_soc_component * :	snd_soc_dapm_xxx_for_component)(x, ...)
> 

Sorry for the delay in response, Kuninori.

Now, personally I'm up even for big patchsets i.e.: it's 'just' a 
_proposal_, nothing is merged by default and every good engineering 
discussion I see as absolute win.

Reducing the need for users (sound drivers) to manipulate dapm_context 
is a good thing. I'll tell more once I see the actual proposal. The 
pseudo-code shown above, provided is used by soc-core.c alone, looks good.


Kind regards,
Czarek