* [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include @ 2023-12-12 14:30 Jani Nikula 2023-12-12 18:53 ` kernel test robot 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula 0 siblings, 2 replies; 11+ messages in thread From: Jani Nikula @ 2023-12-12 14:30 UTC (permalink / raw) To: linux-sound; +Cc: dri-devel, Jaroslav Kysela, Takashi Iwai, jani.nikula hdmi-codec.h does not appear to need drm/drm_edid.h for anything. Remove it. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- I'm pretty sure I haven't compiled everything that might implicitly depend on the include. However, the right thing to do is to include drm_edid.h where needed, not from somewhat random intermediate headers. I hope this uncovers anything I missed. --- include/sound/hdmi-codec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h index 9b162ac1e08e..5e1a9eafd10f 100644 --- a/include/sound/hdmi-codec.h +++ b/include/sound/hdmi-codec.h @@ -12,7 +12,6 @@ #include <linux/of_graph.h> #include <linux/hdmi.h> -#include <drm/drm_edid.h> #include <sound/asoundef.h> #include <sound/soc.h> #include <uapi/sound/asound.h> -- 2.39.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-12 14:30 [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include Jani Nikula @ 2023-12-12 18:53 ` kernel test robot 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula 1 sibling, 0 replies; 11+ messages in thread From: kernel test robot @ 2023-12-12 18:53 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: oe-kbuild-all, jani.nikula, Takashi Iwai, dri-devel, Jaroslav Kysela Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on tiwai-sound/for-linus linus/master v6.7-rc5 next-20231212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/ASoC-hdmi-codec-drop-drm-drm_edid-h-include/20231212-223200 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20231212143038.3828691-1-jani.nikula%40intel.com patch subject: [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20231213/202312130235.qG8OwKk0-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231213/202312130235.qG8OwKk0-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312130235.qG8OwKk0-lkp@intel.com/ All error/warnings (new ones prefixed by >>): drivers/gpu/drm/msm/dp/dp_display.c: In function 'dp_display_process_hpd_high': >> drivers/gpu/drm/msm/dp/dp_display.c:406:31: error: implicit declaration of function 'drm_detect_monitor_audio' [-Werror=implicit-function-declaration] 406 | dp->audio_supported = drm_detect_monitor_audio(edid); | ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_is_full_range': >> drivers/gpu/drm/vc4/vc4_hdmi.c:168:17: error: implicit declaration of function 'drm_default_rgb_quant_range' [-Werror=implicit-function-declaration] 168 | drm_default_rgb_quant_range(mode) == HDMI_QUANTIZATION_RANGE_FULL; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_handle_hotplug': >> drivers/gpu/drm/vc4/vc4_hdmi.c:437:16: error: implicit declaration of function 'drm_get_edid'; did you mean 'drm_gem_evict'? [-Werror=implicit-function-declaration] 437 | edid = drm_get_edid(connector, vc4_hdmi->ddc); | ^~~~~~~~~~~~ | drm_gem_evict >> drivers/gpu/drm/vc4/vc4_hdmi.c:437:14: warning: assignment to 'struct edid *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 437 | edid = drm_get_edid(connector, vc4_hdmi->ddc); | ^ drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_connector_get_modes': drivers/gpu/drm/vc4/vc4_hdmi.c:508:14: warning: assignment to 'struct edid *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 508 | edid = drm_get_edid(connector, vc4_hdmi->ddc); | ^ >> drivers/gpu/drm/vc4/vc4_hdmi.c:514:15: error: implicit declaration of function 'drm_add_edid_modes' [-Werror=implicit-function-declaration] 514 | ret = drm_add_edid_modes(connector, edid); | ^~~~~~~~~~~~~~~~~~ drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_set_avi_infoframe': >> drivers/gpu/drm/vc4/vc4_hdmi.c:910:15: error: implicit declaration of function 'drm_hdmi_avi_infoframe_from_display_mode'; did you mean 'drm_hdmi_avi_infoframe_content_type'? [-Werror=implicit-function-declaration] 910 | ret = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | drm_hdmi_avi_infoframe_content_type >> drivers/gpu/drm/vc4/vc4_hdmi.c:917:9: error: implicit declaration of function 'drm_hdmi_avi_infoframe_quant_range'; did you mean 'drm_hdmi_avi_infoframe_content_type'? [-Werror=implicit-function-declaration] 917 | drm_hdmi_avi_infoframe_quant_range(&frame.avi, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | drm_hdmi_avi_infoframe_content_type drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_sink_supports_format_bpc': >> drivers/gpu/drm/vc4/vc4_hdmi.c:1930:18: error: implicit declaration of function 'drm_match_cea_mode' [-Werror=implicit-function-declaration] 1930 | u8 vic = drm_match_cea_mode(mode); | ^~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/vc4/vc4_hdmi.c:1950:70: error: 'DRM_EDID_HDMI_DC_30' undeclared (first use in this function) 1950 | if (bpc == 10 && !(info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30)) { | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/vc4/vc4_hdmi.c:1950:70: note: each undeclared identifier is reported only once for each function it appears in >> drivers/gpu/drm/vc4/vc4_hdmi.c:1955:70: error: 'DRM_EDID_HDMI_DC_36' undeclared (first use in this function) 1955 | if (bpc == 12 && !(info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_36)) { | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/drm_detect_monitor_audio +406 drivers/gpu/drm/msm/dp/dp_display.c c943b4948b5848 Chandan Uddaraju 2020-08-27 381 c943b4948b5848 Chandan Uddaraju 2020-08-27 382 static int dp_display_process_hpd_high(struct dp_display_private *dp) c943b4948b5848 Chandan Uddaraju 2020-08-27 383 { c943b4948b5848 Chandan Uddaraju 2020-08-27 384 int rc = 0; c943b4948b5848 Chandan Uddaraju 2020-08-27 385 struct edid *edid; c943b4948b5848 Chandan Uddaraju 2020-08-27 386 c943b4948b5848 Chandan Uddaraju 2020-08-27 387 dp->panel->max_dp_lanes = dp->parser->max_dp_lanes; 0e7f270591a42f Kuogee Hsieh 2022-12-27 388 dp->panel->max_dp_link_rate = dp->parser->max_dp_link_rate; 0e7f270591a42f Kuogee Hsieh 2022-12-27 389 0e7f270591a42f Kuogee Hsieh 2022-12-27 390 drm_dbg_dp(dp->drm_dev, "max_lanes=%d max_link_rate=%d\n", 0e7f270591a42f Kuogee Hsieh 2022-12-27 391 dp->panel->max_dp_lanes, dp->panel->max_dp_link_rate); c943b4948b5848 Chandan Uddaraju 2020-08-27 392 c943b4948b5848 Chandan Uddaraju 2020-08-27 393 rc = dp_panel_read_sink_caps(dp->panel, dp->dp_display.connector); c943b4948b5848 Chandan Uddaraju 2020-08-27 394 if (rc) 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 395 goto end; c943b4948b5848 Chandan Uddaraju 2020-08-27 396 c943b4948b5848 Chandan Uddaraju 2020-08-27 397 dp_link_process_request(dp->link); c943b4948b5848 Chandan Uddaraju 2020-08-27 398 bfcc3d8f94f4cb Dmitry Baryshkov 2023-09-04 399 drm_dp_set_subconnector_property(dp->dp_display.connector, connector_status_connected, bfcc3d8f94f4cb Dmitry Baryshkov 2023-09-04 400 dp->panel->dpcd, dp->panel->downstream_ports); bfcc3d8f94f4cb Dmitry Baryshkov 2023-09-04 401 c943b4948b5848 Chandan Uddaraju 2020-08-27 402 edid = dp->panel->edid; c943b4948b5848 Chandan Uddaraju 2020-08-27 403 b78c77273a5648 Abhinav Kumar 2023-04-27 404 dp->dp_display.psr_supported = dp->panel->psr_cap.version && psr_enabled; cd779808cccd50 Vinod Polimera 2023-03-02 405 c943b4948b5848 Chandan Uddaraju 2020-08-27 @406 dp->audio_supported = drm_detect_monitor_audio(edid); c943b4948b5848 Chandan Uddaraju 2020-08-27 407 dp_panel_handle_sink_request(dp->panel); c943b4948b5848 Chandan Uddaraju 2020-08-27 408 c943b4948b5848 Chandan Uddaraju 2020-08-27 409 dp->dp_display.max_dp_lanes = dp->parser->max_dp_lanes; 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 410 f21c8a276c2dad Kuogee Hsieh 2021-05-21 411 /* f21c8a276c2dad Kuogee Hsieh 2021-05-21 412 * set sink to normal operation mode -- D0 f21c8a276c2dad Kuogee Hsieh 2021-05-21 413 * before dpcd read f21c8a276c2dad Kuogee Hsieh 2021-05-21 414 */ f21c8a276c2dad Kuogee Hsieh 2021-05-21 415 dp_link_psm_config(dp->link, &dp->panel->link_info, false); f21c8a276c2dad Kuogee Hsieh 2021-05-21 416 6625e2637d93d2 Tanmay Shah 2020-09-25 417 dp_link_reset_phy_params_vx_px(dp->link); 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 418 rc = dp_ctrl_on_link(dp->ctrl); 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 419 if (rc) { 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 420 DRM_ERROR("failed to complete DP link training\n"); 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 421 goto end; 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 422 } 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 423 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 424 dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); 8ede2ecc3e5ee3 Kuogee Hsieh 2020-09-11 425 c943b4948b5848 Chandan Uddaraju 2020-08-27 426 end: c943b4948b5848 Chandan Uddaraju 2020-08-27 427 return rc; c943b4948b5848 Chandan Uddaraju 2020-08-27 428 } c943b4948b5848 Chandan Uddaraju 2020-08-27 429 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-12 14:30 [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include Jani Nikula 2023-12-12 18:53 ` kernel test robot @ 2023-12-13 9:50 ` Jani Nikula 2023-12-13 23:56 ` kernel test robot ` (3 more replies) 1 sibling, 4 replies; 11+ messages in thread From: Jani Nikula @ 2023-12-13 9:50 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: dri-devel, Jaroslav Kysela, Takashi Iwai, linux-arm-msm hdmi-codec.h does not appear to directly need drm/drm_edid.h for anything. Remove it. There are some files that get drm/edid.h by proxy; include it where needed. v2: Fix build (kernel test robot <lkp@intel.com>) Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- I'm pretty sure I haven't compiled everything that might implicitly depend on the include. However, the right thing to do is to include drm_edid.h where needed, not from somewhat random intermediate headers. I hope this uncovers anything I missed. --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + include/sound/hdmi-codec.h | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 1b88fb52726f..766c8d01e6b3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -11,6 +11,7 @@ #include <linux/of_irq.h> #include <linux/delay.h> #include <drm/display/drm_dp_aux_bus.h> +#include <drm/drm_edid.h> #include "msm_drv.h" #include "msm_kms.h" diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 25c9c71256d3..d35d8a531cfc 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -35,6 +35,7 @@ #include <drm/display/drm_scdc_helper.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_drv.h> +#include <drm/drm_edid.h> #include <drm/drm_probe_helper.h> #include <drm/drm_simple_kms_helper.h> #include <linux/clk.h> diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h index 9b162ac1e08e..5e1a9eafd10f 100644 --- a/include/sound/hdmi-codec.h +++ b/include/sound/hdmi-codec.h @@ -12,7 +12,6 @@ #include <linux/of_graph.h> #include <linux/hdmi.h> -#include <drm/drm_edid.h> #include <sound/asoundef.h> #include <sound/soc.h> #include <uapi/sound/asound.h> -- 2.39.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula @ 2023-12-13 23:56 ` kernel test robot 2023-12-14 1:56 ` kernel test robot ` (2 subsequent siblings) 3 siblings, 0 replies; 11+ messages in thread From: kernel test robot @ 2023-12-13 23:56 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: oe-kbuild-all, linux-arm-msm, Takashi Iwai, dri-devel, Jaroslav Kysela Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/ASoC-hdmi-codec-drop-drm-drm_edid-h-include/20231213-175633 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231213095023.3928703-1-jani.nikula%40intel.com patch subject: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include config: hexagon-randconfig-r063-20231213 (https://download.01.org/0day-ci/archive/20231214/202312140733.2qj4HH0f-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312140733.2qj4HH0f-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312140733.2qj4HH0f-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/bridge/lontium-lt9611.c:8: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __raw_readb(PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) ^ In file included from drivers/gpu/drm/bridge/lontium-lt9611.c:8: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) ^ In file included from drivers/gpu/drm/bridge/lontium-lt9611.c:8: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writeb(value, PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ >> drivers/gpu/drm/bridge/lontium-lt9611.c:346:8: error: call to undeclared function 'drm_hdmi_avi_infoframe_from_display_mode'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] ret = drm_hdmi_avi_infoframe_from_display_mode(&infoframe.avi, ^ >> drivers/gpu/drm/bridge/lontium-lt9611.c:359:8: error: call to undeclared function 'drm_hdmi_vendor_infoframe_from_display_mode'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] ret = drm_hdmi_vendor_infoframe_from_display_mode(&infoframe.vendor.hdmi, ^ >> drivers/gpu/drm/bridge/lontium-lt9611.c:855:9: error: call to undeclared function 'drm_do_get_edid'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] return drm_do_get_edid(connector, lt9611_get_edid_block, lt9611); ^ drivers/gpu/drm/bridge/lontium-lt9611.c:855:9: note: did you mean 'drm_bridge_get_edid'? include/drm/drm_bridge.h:891:14: note: 'drm_bridge_get_edid' declared here struct edid *drm_bridge_get_edid(struct drm_bridge *bridge, ^ drivers/gpu/drm/bridge/lontium-lt9611.c:855:9: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'struct edid *' [-Wint-conversion] return drm_do_get_edid(connector, lt9611_get_edid_block, lt9611); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings and 4 errors generated. vim +/drm_hdmi_avi_infoframe_from_display_mode +346 drivers/gpu/drm/bridge/lontium-lt9611.c 23278bf54afe18 Vinod Koul 2020-07-23 334 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 335 static void lt9611_hdmi_set_infoframes(struct lt9611 *lt9611, 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 336 struct drm_connector *connector, 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 337 struct drm_display_mode *mode) 23278bf54afe18 Vinod Koul 2020-07-23 338 { 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 339 union hdmi_infoframe infoframe; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 340 ssize_t len; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 341 u8 iframes = 0x0a; /* UD1 infoframe */ 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 342 u8 buf[32]; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 343 int ret; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 344 int i; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 345 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 @346 ret = drm_hdmi_avi_infoframe_from_display_mode(&infoframe.avi, 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 347 connector, 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 348 mode); 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 349 if (ret < 0) 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 350 goto out; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 351 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 352 len = hdmi_infoframe_pack(&infoframe, buf, sizeof(buf)); 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 353 if (len < 0) 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 354 goto out; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 355 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 356 for (i = 0; i < len; i++) 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 357 regmap_write(lt9611->regmap, 0x8440 + i, buf[i]); 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 358 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 @359 ret = drm_hdmi_vendor_infoframe_from_display_mode(&infoframe.vendor.hdmi, 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 360 connector, 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 361 mode); 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 362 if (ret < 0) 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 363 goto out; 23278bf54afe18 Vinod Koul 2020-07-23 364 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 365 len = hdmi_infoframe_pack(&infoframe, buf, sizeof(buf)); 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 366 if (len < 0) 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 367 goto out; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 368 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 369 for (i = 0; i < len; i++) 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 370 regmap_write(lt9611->regmap, 0x8474 + i, buf[i]); 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 371 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 372 iframes |= 0x20; 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 373 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 374 out: 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 375 regmap_write(lt9611->regmap, 0x843d, iframes); /* UD1 infoframe */ 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 376 } 84cf74d99f88bc Dmitry Baryshkov 2023-01-18 377 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula 2023-12-13 23:56 ` kernel test robot @ 2023-12-14 1:56 ` kernel test robot 2023-12-14 6:14 ` kernel test robot 2023-12-14 9:28 ` [PATCH v3] " Jani Nikula 3 siblings, 0 replies; 11+ messages in thread From: kernel test robot @ 2023-12-14 1:56 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: oe-kbuild-all, linux-arm-msm, Takashi Iwai, dri-devel, Jaroslav Kysela Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/ASoC-hdmi-codec-drop-drm-drm_edid-h-include/20231213-175633 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231213095023.3928703-1-jani.nikula%40intel.com patch subject: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include config: i386-randconfig-006-20231214 (https://download.01.org/0day-ci/archive/20231214/202312140917.YddZdAlJ-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312140917.YddZdAlJ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312140917.YddZdAlJ-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/bridge/lontium-lt9611.c: In function 'lt9611_hdmi_set_infoframes': drivers/gpu/drm/bridge/lontium-lt9611.c:346:8: error: implicit declaration of function 'drm_hdmi_avi_infoframe_from_display_mode'; did you mean 'hdmi_avi_infoframe_pack_only'? [-Werror=implicit-function-declaration] ret = drm_hdmi_avi_infoframe_from_display_mode(&infoframe.avi, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hdmi_avi_infoframe_pack_only drivers/gpu/drm/bridge/lontium-lt9611.c:359:8: error: implicit declaration of function 'drm_hdmi_vendor_infoframe_from_display_mode'; did you mean 'hdmi_vendor_infoframe_pack_only'? [-Werror=implicit-function-declaration] ret = drm_hdmi_vendor_infoframe_from_display_mode(&infoframe.vendor.hdmi, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hdmi_vendor_infoframe_pack_only drivers/gpu/drm/bridge/lontium-lt9611.c: In function 'lt9611_bridge_get_edid': drivers/gpu/drm/bridge/lontium-lt9611.c:855:9: error: implicit declaration of function 'drm_do_get_edid'; did you mean 'drm_bridge_get_edid'? [-Werror=implicit-function-declaration] return drm_do_get_edid(connector, lt9611_get_edid_block, lt9611); ^~~~~~~~~~~~~~~ drm_bridge_get_edid >> drivers/gpu/drm/bridge/lontium-lt9611.c:855:9: warning: return makes pointer from integer without a cast [-Wint-conversion] return drm_do_get_edid(connector, lt9611_get_edid_block, lt9611); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +855 drivers/gpu/drm/bridge/lontium-lt9611.c 23278bf54afe18 Vinod Koul 2020-07-23 848 23278bf54afe18 Vinod Koul 2020-07-23 849 static struct edid *lt9611_bridge_get_edid(struct drm_bridge *bridge, 23278bf54afe18 Vinod Koul 2020-07-23 850 struct drm_connector *connector) 23278bf54afe18 Vinod Koul 2020-07-23 851 { 23278bf54afe18 Vinod Koul 2020-07-23 852 struct lt9611 *lt9611 = bridge_to_lt9611(bridge); 23278bf54afe18 Vinod Koul 2020-07-23 853 23278bf54afe18 Vinod Koul 2020-07-23 854 lt9611_power_on(lt9611); 23278bf54afe18 Vinod Koul 2020-07-23 @855 return drm_do_get_edid(connector, lt9611_get_edid_block, lt9611); 23278bf54afe18 Vinod Koul 2020-07-23 856 } 23278bf54afe18 Vinod Koul 2020-07-23 857 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula 2023-12-13 23:56 ` kernel test robot 2023-12-14 1:56 ` kernel test robot @ 2023-12-14 6:14 ` kernel test robot 2023-12-14 9:28 ` [PATCH v3] " Jani Nikula 3 siblings, 0 replies; 11+ messages in thread From: kernel test robot @ 2023-12-14 6:14 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: oe-kbuild-all, linux-arm-msm, Takashi Iwai, dri-devel, Jaroslav Kysela Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/ASoC-hdmi-codec-drop-drm-drm_edid-h-include/20231213-175633 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231213095023.3928703-1-jani.nikula%40intel.com patch subject: [PATCH v2] ASoC: hdmi-codec: drop drm/drm_edid.h include config: i386-randconfig-002-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141302.SBNAHryl-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141302.SBNAHryl-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312141302.SBNAHryl-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/bridge/lontium-lt9611uxc.c: In function 'lt9611uxc_connector_get_modes': drivers/gpu/drm/bridge/lontium-lt9611uxc.c:301:10: error: implicit declaration of function 'drm_add_edid_modes'; did you mean 'drm_bridge_get_modes'? [-Werror=implicit-function-declaration] count = drm_add_edid_modes(connector, edid); ^~~~~~~~~~~~~~~~~~ drm_bridge_get_modes drivers/gpu/drm/bridge/lontium-lt9611uxc.c: In function 'lt9611uxc_bridge_get_edid': drivers/gpu/drm/bridge/lontium-lt9611uxc.c:512:9: error: implicit declaration of function 'drm_do_get_edid'; did you mean 'drm_bridge_get_edid'? [-Werror=implicit-function-declaration] return drm_do_get_edid(connector, lt9611uxc_get_edid_block, lt9611uxc); ^~~~~~~~~~~~~~~ drm_bridge_get_edid >> drivers/gpu/drm/bridge/lontium-lt9611uxc.c:512:9: warning: return makes pointer from integer without a cast [-Wint-conversion] return drm_do_get_edid(connector, lt9611uxc_get_edid_block, lt9611uxc); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +512 drivers/gpu/drm/bridge/lontium-lt9611uxc.c 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 496 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 497 static struct edid *lt9611uxc_bridge_get_edid(struct drm_bridge *bridge, 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 498 struct drm_connector *connector) 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 499 { 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 500 struct lt9611uxc *lt9611uxc = bridge_to_lt9611uxc(bridge); 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 501 int ret; 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 502 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 503 ret = lt9611uxc_wait_for_edid(lt9611uxc); 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 504 if (ret < 0) { 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 505 dev_err(lt9611uxc->dev, "wait for EDID failed: %d\n", ret); 1bb7ab402da44e Dmitry Baryshkov 2021-01-22 506 return NULL; 1bb7ab402da44e Dmitry Baryshkov 2021-01-22 507 } else if (ret == 0) { 1bb7ab402da44e Dmitry Baryshkov 2021-01-22 508 dev_err(lt9611uxc->dev, "wait for EDID timeout\n"); 1bb7ab402da44e Dmitry Baryshkov 2021-01-22 509 return NULL; 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 510 } 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 511 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 @512 return drm_do_get_edid(connector, lt9611uxc_get_edid_block, lt9611uxc); 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 513 } 0cbbd5b1a012cd Dmitry Baryshkov 2020-11-02 514 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula ` (2 preceding siblings ...) 2023-12-14 6:14 ` kernel test robot @ 2023-12-14 9:28 ` Jani Nikula 2023-12-14 20:53 ` kernel test robot 2023-12-19 12:12 ` [PATCH v4] " Jani Nikula 3 siblings, 2 replies; 11+ messages in thread From: Jani Nikula @ 2023-12-14 9:28 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: dri-devel, Jaroslav Kysela, Takashi Iwai, linux-arm-msm hdmi-codec.h does not appear to directly need drm/drm_edid.h for anything. Remove it. There are some files that get drm/edid.h by proxy; include it where needed. v2-v3: Fix build (kernel test robot <lkp@intel.com>) Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- I'm pretty sure I haven't compiled everything that might implicitly depend on the include. However, the right thing to do is to include drm_edid.h where needed, not from somewhat random intermediate headers. I hope this uncovers anything I missed. --- drivers/gpu/drm/bridge/lontium-lt9611.c | 1 + drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + include/sound/hdmi-codec.h | 1 - 5 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index 9663601ce098..b9205d14d943 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -18,6 +18,7 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_edid.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_of.h> #include <drm/drm_print.h> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c index e971b75e90ad..f3f130c1ef0a 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -21,6 +21,7 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_edid.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_print.h> #include <drm/drm_probe_helper.h> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 1b88fb52726f..766c8d01e6b3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -11,6 +11,7 @@ #include <linux/of_irq.h> #include <linux/delay.h> #include <drm/display/drm_dp_aux_bus.h> +#include <drm/drm_edid.h> #include "msm_drv.h" #include "msm_kms.h" diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index f05e2c95a60d..34f807ed1c31 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -35,6 +35,7 @@ #include <drm/display/drm_scdc_helper.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_drv.h> +#include <drm/drm_edid.h> #include <drm/drm_probe_helper.h> #include <drm/drm_simple_kms_helper.h> #include <linux/clk.h> diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h index 9b162ac1e08e..5e1a9eafd10f 100644 --- a/include/sound/hdmi-codec.h +++ b/include/sound/hdmi-codec.h @@ -12,7 +12,6 @@ #include <linux/of_graph.h> #include <linux/hdmi.h> -#include <drm/drm_edid.h> #include <sound/asoundef.h> #include <sound/soc.h> #include <uapi/sound/asound.h> -- 2.39.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-14 9:28 ` [PATCH v3] " Jani Nikula @ 2023-12-14 20:53 ` kernel test robot 2023-12-19 12:12 ` [PATCH v4] " Jani Nikula 1 sibling, 0 replies; 11+ messages in thread From: kernel test robot @ 2023-12-14 20:53 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: llvm, oe-kbuild-all, linux-arm-msm, Takashi Iwai, dri-devel, Jaroslav Kysela Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/ASoC-hdmi-codec-drop-drm-drm_edid-h-include/20231214-173047 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231214092856.4019251-1-jani.nikula%40intel.com patch subject: [PATCH v3] ASoC: hdmi-codec: drop drm/drm_edid.h include config: arm-randconfig-001-20231215 (https://download.01.org/0day-ci/archive/20231215/202312150438.cYAajoc9-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231215/202312150438.cYAajoc9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312150438.cYAajoc9-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:1772:2: error: call to undeclared function 'drm_hdmi_avi_infoframe_from_display_mode'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] drm_hdmi_avi_infoframe_from_display_mode(&frame, connector, mode); ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:1775:3: error: call to undeclared function 'drm_hdmi_avi_infoframe_quant_range'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] drm_hdmi_avi_infoframe_quant_range(&frame, connector, mode, ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:1899:8: error: call to undeclared function 'drm_hdmi_vendor_infoframe_from_display_mode'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] err = drm_hdmi_vendor_infoframe_from_display_mode(&frame, connector, ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2249:14: error: call to undeclared function 'drm_match_cea_mode'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] hdmi->vic = drm_match_cea_mode(mode); ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2282:3: error: call to undeclared function 'drm_default_rgb_quant_range'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] drm_default_rgb_quant_range(mode) == ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2465:9: error: call to undeclared function 'drm_get_edid'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] edid = drm_get_edid(connector, hdmi->ddc); ^ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2465:7: error: incompatible integer to pointer conversion assigning to 'struct edid *' from 'int' [-Wint-conversion] edid = drm_get_edid(connector, hdmi->ddc); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2472:7: error: incomplete definition of type 'struct edid' edid->width_cm, edid->height_cm); ~~~~^ include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk' _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/media/cec.h:311:8: note: forward declaration of 'struct edid' struct edid; ^ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2472:23: error: incomplete definition of type 'struct edid' edid->width_cm, edid->height_cm); ~~~~^ include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk' _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/media/cec.h:311:8: note: forward declaration of 'struct edid' struct edid; ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2474:23: error: call to undeclared function 'drm_detect_hdmi_monitor'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] hdmi->sink_is_hdmi = drm_detect_hdmi_monitor(edid); ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2475:25: error: call to undeclared function 'drm_detect_monitor_audio'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] hdmi->sink_has_audio = drm_detect_monitor_audio(edid); ^ >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2505:8: error: call to undeclared function 'drm_add_edid_modes'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] ret = drm_add_edid_modes(connector, edid); ^ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2677:35: error: use of undeclared identifier 'DRM_EDID_YCBCR420_DC_48' (info->hdmi.y420_dc_modes & DRM_EDID_YCBCR420_DC_48)) ^ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2681:35: error: use of undeclared identifier 'DRM_EDID_YCBCR420_DC_36' (info->hdmi.y420_dc_modes & DRM_EDID_YCBCR420_DC_36)) ^ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c:2685:35: error: use of undeclared identifier 'DRM_EDID_YCBCR420_DC_30' (info->hdmi.y420_dc_modes & DRM_EDID_YCBCR420_DC_30)) ^ 15 errors generated. vim +/drm_hdmi_avi_infoframe_from_display_mode +1772 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1763 9fbfa320b435e6 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 1764 static void hdmi_config_AVI(struct dw_hdmi *hdmi, 81980037fb275d drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 1765 const struct drm_connector *connector, 9fbfa320b435e6 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 1766 const struct drm_display_mode *mode) 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1767 { d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1768 struct hdmi_avi_infoframe frame; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1769 u8 val; 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1770 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1771 /* Initialise info frame from DRM mode */ 81980037fb275d drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 @1772 drm_hdmi_avi_infoframe_from_display_mode(&frame, connector, mode); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1773 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1774 if (hdmi_bus_fmt_is_rgb(hdmi->hdmi_data.enc_out_bus_format)) { 81980037fb275d drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 @1775 drm_hdmi_avi_infoframe_quant_range(&frame, connector, mode, 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1776 hdmi->hdmi_data.rgb_limited_range ? 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1777 HDMI_QUANTIZATION_RANGE_LIMITED : 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1778 HDMI_QUANTIZATION_RANGE_FULL); 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1779 } else { 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1780 frame.quantization_range = HDMI_QUANTIZATION_RANGE_DEFAULT; 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1781 frame.ycc_quantization_range = 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1782 HDMI_YCC_QUANTIZATION_RANGE_LIMITED; 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1783 } 86af379ebca2ef drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1784 def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1785 if (hdmi_bus_fmt_is_yuv444(hdmi->hdmi_data.enc_out_bus_format)) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1786 frame.colorspace = HDMI_COLORSPACE_YUV444; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1787 else if (hdmi_bus_fmt_is_yuv422(hdmi->hdmi_data.enc_out_bus_format)) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1788 frame.colorspace = HDMI_COLORSPACE_YUV422; ba9877e2361c46 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2019-02-01 1789 else if (hdmi_bus_fmt_is_yuv420(hdmi->hdmi_data.enc_out_bus_format)) ba9877e2361c46 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2019-02-01 1790 frame.colorspace = HDMI_COLORSPACE_YUV420; 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1791 else d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1792 frame.colorspace = HDMI_COLORSPACE_RGB; 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1793 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1794 /* Set up colorimetry */ e8dca30f711846 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1795 if (!hdmi_bus_fmt_is_rgb(hdmi->hdmi_data.enc_out_bus_format)) { def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1796 switch (hdmi->hdmi_data.enc_out_encoding) { def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1797 case V4L2_YCBCR_ENC_601: def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1798 if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV601) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1799 frame.colorimetry = HDMI_COLORIMETRY_EXTENDED; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1800 else def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1801 frame.colorimetry = HDMI_COLORIMETRY_ITU_601; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1802 frame.extended_colorimetry = d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1803 HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; f40d6560eba65b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Dan Carpenter 2017-04-06 1804 break; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1805 case V4L2_YCBCR_ENC_709: def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1806 if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709) def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1807 frame.colorimetry = HDMI_COLORIMETRY_EXTENDED; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1808 else def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1809 frame.colorimetry = HDMI_COLORIMETRY_ITU_709; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1810 frame.extended_colorimetry = d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1811 HDMI_EXTENDED_COLORIMETRY_XV_YCC_709; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1812 break; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1813 default: /* Carries no data */ def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1814 frame.colorimetry = HDMI_COLORIMETRY_ITU_601; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1815 frame.extended_colorimetry = def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1816 HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; def23aa7e9821a drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Neil Armstrong 2017-04-04 1817 break; 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1818 } e8dca30f711846 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1819 } else { e8dca30f711846 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1820 frame.colorimetry = HDMI_COLORIMETRY_NONE; e8dca30f711846 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1821 frame.extended_colorimetry = e8dca30f711846 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1822 HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; e8dca30f711846 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Jernej Skrabec 2020-03-05 1823 } 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1824 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1825 /* d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1826 * The Designware IP uses a different byte format from standard d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1827 * AVI info frames, though generally the bits are in the correct d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1828 * bytes. d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1829 */ d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1830 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1831 /* b0118e7d936c55 drivers/gpu/drm/bridge/dw-hdmi.c Jose Abreu 2016-08-29 1832 * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6, b0118e7d936c55 drivers/gpu/drm/bridge/dw-hdmi.c Jose Abreu 2016-08-29 1833 * scan info in bits 4,5 rather than 0,1 and active aspect present in b0118e7d936c55 drivers/gpu/drm/bridge/dw-hdmi.c Jose Abreu 2016-08-29 1834 * bit 6 rather than 4. d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1835 */ b0118e7d936c55 drivers/gpu/drm/bridge/dw-hdmi.c Jose Abreu 2016-08-29 1836 val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1837 if (frame.active_aspect & 15) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1838 val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1839 if (frame.top_bar || frame.bottom_bar) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1840 val |= HDMI_FC_AVICONF0_BAR_DATA_HORIZ_BAR; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1841 if (frame.left_bar || frame.right_bar) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1842 val |= HDMI_FC_AVICONF0_BAR_DATA_VERT_BAR; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1843 hdmi_writeb(hdmi, val, HDMI_FC_AVICONF0); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1844 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1845 /* AVI data byte 2 differences: none */ d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1846 val = ((frame.colorimetry & 0x3) << 6) | d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1847 ((frame.picture_aspect & 0x3) << 4) | d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1848 (frame.active_aspect & 0xf); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1849 hdmi_writeb(hdmi, val, HDMI_FC_AVICONF1); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1850 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1851 /* AVI data byte 3 differences: none */ d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1852 val = ((frame.extended_colorimetry & 0x7) << 4) | d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1853 ((frame.quantization_range & 0x3) << 2) | d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1854 (frame.nups & 0x3); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1855 if (frame.itc) d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1856 val |= HDMI_FC_AVICONF2_IT_CONTENT_VALID; 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1857 hdmi_writeb(hdmi, val, HDMI_FC_AVICONF2); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1858 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1859 /* AVI data byte 4 differences: none */ d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1860 val = frame.video_code & 0x7f; d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1861 hdmi_writeb(hdmi, val, HDMI_FC_AVIVID); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1862 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1863 /* AVI Data Byte 5- set up input and output pixel repetition */ 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1864 val = (((hdmi->hdmi_data.video_mode.mpixelrepetitioninput + 1) << 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1865 HDMI_FC_PRCONF_INCOMING_PR_FACTOR_OFFSET) & 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1866 HDMI_FC_PRCONF_INCOMING_PR_FACTOR_MASK) | 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1867 ((hdmi->hdmi_data.video_mode.mpixelrepetitionoutput << 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1868 HDMI_FC_PRCONF_OUTPUT_PR_FACTOR_OFFSET) & 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1869 HDMI_FC_PRCONF_OUTPUT_PR_FACTOR_MASK); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1870 hdmi_writeb(hdmi, val, HDMI_FC_PRCONF); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1871 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1872 /* d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1873 * AVI data byte 5 differences: content type in 0,1 rather than 4,5, d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1874 * ycc range in bits 2,3 rather than 6,7 d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1875 */ d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1876 val = ((frame.ycc_quantization_range & 0x3) << 2) | d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1877 (frame.content_type & 0x3); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1878 hdmi_writeb(hdmi, val, HDMI_FC_AVICONF3); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1879 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1880 /* AVI Data Bytes 6-13 */ d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1881 hdmi_writeb(hdmi, frame.top_bar & 0xff, HDMI_FC_AVIETB0); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1882 hdmi_writeb(hdmi, (frame.top_bar >> 8) & 0xff, HDMI_FC_AVIETB1); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1883 hdmi_writeb(hdmi, frame.bottom_bar & 0xff, HDMI_FC_AVISBB0); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1884 hdmi_writeb(hdmi, (frame.bottom_bar >> 8) & 0xff, HDMI_FC_AVISBB1); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1885 hdmi_writeb(hdmi, frame.left_bar & 0xff, HDMI_FC_AVIELB0); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1886 hdmi_writeb(hdmi, (frame.left_bar >> 8) & 0xff, HDMI_FC_AVIELB1); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1887 hdmi_writeb(hdmi, frame.right_bar & 0xff, HDMI_FC_AVISRB0); d4ac4cb69e79e3 drivers/gpu/drm/bridge/dw_hdmi.c Russell King 2015-03-27 1888 hdmi_writeb(hdmi, (frame.right_bar >> 8) & 0xff, HDMI_FC_AVISRB1); 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1889 } 9aaf880ed4ee3c drivers/staging/imx-drm/imx-hdmi.c Fabio Estevam 2013-11-29 1890 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1891 static void hdmi_config_vendor_specific_infoframe(struct dw_hdmi *hdmi, 81980037fb275d drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 1892 const struct drm_connector *connector, 9fbfa320b435e6 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 1893 const struct drm_display_mode *mode) 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1894 { 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1895 struct hdmi_vendor_infoframe frame; 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1896 u8 buffer[10]; 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1897 ssize_t err; 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1898 81980037fb275d drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Laurent Pinchart 2020-05-26 @1899 err = drm_hdmi_vendor_infoframe_from_display_mode(&frame, connector, f1781e9bb2dd23 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Ville Syrjälä 2017-11-13 1900 mode); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1901 if (err < 0) 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1902 /* 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1903 * Going into that statement does not means vendor infoframe 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1904 * fails. It just informed us that vendor infoframe is not 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1905 * needed for the selected mode. Only 4k or stereoscopic 3D 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1906 * mode requires vendor infoframe. So just simply return. 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1907 */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1908 return; 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1909 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1910 err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer)); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1911 if (err < 0) { 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1912 dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n", 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1913 err); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1914 return; 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1915 } 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1916 hdmi_mask_writeb(hdmi, 0, HDMI_FC_DATAUTO0, HDMI_FC_DATAUTO0_VSD_OFFSET, 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1917 HDMI_FC_DATAUTO0_VSD_MASK); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1918 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1919 /* Set the length of HDMI vendor specific InfoFrame payload */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1920 hdmi_writeb(hdmi, buffer[2], HDMI_FC_VSDSIZE); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1921 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1922 /* Set 24bit IEEE Registration Identifier */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1923 hdmi_writeb(hdmi, buffer[4], HDMI_FC_VSDIEEEID0); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1924 hdmi_writeb(hdmi, buffer[5], HDMI_FC_VSDIEEEID1); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1925 hdmi_writeb(hdmi, buffer[6], HDMI_FC_VSDIEEEID2); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1926 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1927 /* Set HDMI_Video_Format and HDMI_VIC/3D_Structure */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1928 hdmi_writeb(hdmi, buffer[7], HDMI_FC_VSDPAYLOAD0); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1929 hdmi_writeb(hdmi, buffer[8], HDMI_FC_VSDPAYLOAD1); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1930 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1931 if (frame.s3d_struct >= HDMI_3D_STRUCTURE_SIDE_BY_SIDE_HALF) 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1932 hdmi_writeb(hdmi, buffer[9], HDMI_FC_VSDPAYLOAD2); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1933 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1934 /* Packet frame interpolation */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1935 hdmi_writeb(hdmi, 1, HDMI_FC_DATAUTO1); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1936 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1937 /* Auto packets per frame and line spacing */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1938 hdmi_writeb(hdmi, 0x11, HDMI_FC_DATAUTO2); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1939 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1940 /* Configures the Frame Composer On RDRB mode */ 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1941 hdmi_mask_writeb(hdmi, 1, HDMI_FC_DATAUTO0, HDMI_FC_DATAUTO0_VSD_OFFSET, 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1942 HDMI_FC_DATAUTO0_VSD_MASK); 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1943 } 9aa1eca095579b drivers/gpu/drm/bridge/synopsys/dw-hdmi.c Nickey Yang 2017-03-21 1944 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-14 9:28 ` [PATCH v3] " Jani Nikula 2023-12-14 20:53 ` kernel test robot @ 2023-12-19 12:12 ` Jani Nikula 2023-12-21 9:35 ` Jani Nikula 1 sibling, 1 reply; 11+ messages in thread From: Jani Nikula @ 2023-12-19 12:12 UTC (permalink / raw) To: Jani Nikula, linux-sound Cc: dri-devel, Jaroslav Kysela, Takashi Iwai, linux-arm-msm hdmi-codec.h does not appear to directly need drm/drm_edid.h for anything. Remove it. There are some files that get drm/edid.h by proxy; include it where needed. v2-v4: Fix build (kernel test robot <lkp@intel.com>) Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- I'm pretty sure I haven't compiled everything that might implicitly depend on the include. However, the right thing to do is to include drm_edid.h where needed, not from somewhat random intermediate headers. I hope this uncovers anything I missed. --- drivers/gpu/drm/bridge/lontium-lt9611.c | 1 + drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 1 + drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + include/sound/hdmi-codec.h | 1 - 6 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index 9663601ce098..b9205d14d943 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -18,6 +18,7 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_edid.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_of.h> #include <drm/drm_print.h> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c index e971b75e90ad..f3f130c1ef0a 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -21,6 +21,7 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_edid.h> #include <drm/drm_mipi_dsi.h> #include <drm/drm_print.h> #include <drm/drm_probe_helper.h> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52d91a0df85e..fa63a21bdd1c 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -31,6 +31,7 @@ #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_edid.h> #include <drm/drm_of.h> #include <drm/drm_print.h> #include <drm/drm_probe_helper.h> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 1b88fb52726f..766c8d01e6b3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -11,6 +11,7 @@ #include <linux/of_irq.h> #include <linux/delay.h> #include <drm/display/drm_dp_aux_bus.h> +#include <drm/drm_edid.h> #include "msm_drv.h" #include "msm_kms.h" diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index f05e2c95a60d..34f807ed1c31 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -35,6 +35,7 @@ #include <drm/display/drm_scdc_helper.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_drv.h> +#include <drm/drm_edid.h> #include <drm/drm_probe_helper.h> #include <drm/drm_simple_kms_helper.h> #include <linux/clk.h> diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h index 9b162ac1e08e..5e1a9eafd10f 100644 --- a/include/sound/hdmi-codec.h +++ b/include/sound/hdmi-codec.h @@ -12,7 +12,6 @@ #include <linux/of_graph.h> #include <linux/hdmi.h> -#include <drm/drm_edid.h> #include <sound/asoundef.h> #include <sound/soc.h> #include <uapi/sound/asound.h> -- 2.39.2 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-19 12:12 ` [PATCH v4] " Jani Nikula @ 2023-12-21 9:35 ` Jani Nikula 2023-12-21 9:48 ` Maxime Ripard 0 siblings, 1 reply; 11+ messages in thread From: Jani Nikula @ 2023-12-21 9:35 UTC (permalink / raw) To: linux-sound, dri-devel Cc: Jaroslav Kysela, Takashi Iwai, linux-arm-msm, Emma Anholt, Maxime Ripard, Andrzej Hajda, Neil Armstrong, Robert Foss, Abhinav Kumar, Dmitry Baryshkov On Tue, 19 Dec 2023, Jani Nikula <jani.nikula@intel.com> wrote: > hdmi-codec.h does not appear to directly need drm/drm_edid.h for > anything. Remove it. > > There are some files that get drm/edid.h by proxy; include it where > needed. > > v2-v4: Fix build (kernel test robot <lkp@intel.com>) > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > --- > > I'm pretty sure I haven't compiled everything that might implicitly > depend on the include. However, the right thing to do is to include > drm_edid.h where needed, not from somewhat random intermediate > headers. I hope this uncovers anything I missed. The kernel test robot came back with clean results. Added a bunch more Cc's here. Ack to merge this via drm-misc-next, please? BR, Jani. > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 1 + > drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 1 + > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + > include/sound/hdmi-codec.h | 1 - > 6 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index 9663601ce098..b9205d14d943 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -18,6 +18,7 @@ > > #include <drm/drm_atomic_helper.h> > #include <drm/drm_bridge.h> > +#include <drm/drm_edid.h> > #include <drm/drm_mipi_dsi.h> > #include <drm/drm_of.h> > #include <drm/drm_print.h> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > index e971b75e90ad..f3f130c1ef0a 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > @@ -21,6 +21,7 @@ > > #include <drm/drm_atomic_helper.h> > #include <drm/drm_bridge.h> > +#include <drm/drm_edid.h> > #include <drm/drm_mipi_dsi.h> > #include <drm/drm_print.h> > #include <drm/drm_probe_helper.h> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 52d91a0df85e..fa63a21bdd1c 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -31,6 +31,7 @@ > #include <drm/drm_atomic.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_bridge.h> > +#include <drm/drm_edid.h> > #include <drm/drm_of.h> > #include <drm/drm_print.h> > #include <drm/drm_probe_helper.h> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 1b88fb52726f..766c8d01e6b3 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -11,6 +11,7 @@ > #include <linux/of_irq.h> > #include <linux/delay.h> > #include <drm/display/drm_dp_aux_bus.h> > +#include <drm/drm_edid.h> > > #include "msm_drv.h" > #include "msm_kms.h" > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index f05e2c95a60d..34f807ed1c31 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -35,6 +35,7 @@ > #include <drm/display/drm_scdc_helper.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_drv.h> > +#include <drm/drm_edid.h> > #include <drm/drm_probe_helper.h> > #include <drm/drm_simple_kms_helper.h> > #include <linux/clk.h> > diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h > index 9b162ac1e08e..5e1a9eafd10f 100644 > --- a/include/sound/hdmi-codec.h > +++ b/include/sound/hdmi-codec.h > @@ -12,7 +12,6 @@ > > #include <linux/of_graph.h> > #include <linux/hdmi.h> > -#include <drm/drm_edid.h> > #include <sound/asoundef.h> > #include <sound/soc.h> > #include <uapi/sound/asound.h> -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4] ASoC: hdmi-codec: drop drm/drm_edid.h include 2023-12-21 9:35 ` Jani Nikula @ 2023-12-21 9:48 ` Maxime Ripard 0 siblings, 0 replies; 11+ messages in thread From: Maxime Ripard @ 2023-12-21 9:48 UTC (permalink / raw) To: Jani Nikula Cc: linux-sound, dri-devel, Jaroslav Kysela, Takashi Iwai, linux-arm-msm, Emma Anholt, Andrzej Hajda, Neil Armstrong, Robert Foss, Abhinav Kumar, Dmitry Baryshkov [-- Attachment #1: Type: text/plain, Size: 929 bytes --] On Thu, Dec 21, 2023 at 11:35:42AM +0200, Jani Nikula wrote: > On Tue, 19 Dec 2023, Jani Nikula <jani.nikula@intel.com> wrote: > > hdmi-codec.h does not appear to directly need drm/drm_edid.h for > > anything. Remove it. > > > > There are some files that get drm/edid.h by proxy; include it where > > needed. > > > > v2-v4: Fix build (kernel test robot <lkp@intel.com>) > > > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > > > --- > > > > I'm pretty sure I haven't compiled everything that might implicitly > > depend on the include. However, the right thing to do is to include > > drm_edid.h where needed, not from somewhat random intermediate > > headers. I hope this uncovers anything I missed. > > The kernel test robot came back with clean results. > > Added a bunch more Cc's here. Ack to merge this via drm-misc-next, > please? Acked-by: Maxime Ripard <mripard@kernel.org> Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-12-21 9:48 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-12 14:30 [PATCH] ASoC: hdmi-codec: drop drm/drm_edid.h include Jani Nikula 2023-12-12 18:53 ` kernel test robot 2023-12-13 9:50 ` [PATCH v2] " Jani Nikula 2023-12-13 23:56 ` kernel test robot 2023-12-14 1:56 ` kernel test robot 2023-12-14 6:14 ` kernel test robot 2023-12-14 9:28 ` [PATCH v3] " Jani Nikula 2023-12-14 20:53 ` kernel test robot 2023-12-19 12:12 ` [PATCH v4] " Jani Nikula 2023-12-21 9:35 ` Jani Nikula 2023-12-21 9:48 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox