Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M
@ 2026-11-15 15:00 Geoffrey D. Bennett
  2026-11-15 16:12 ` Shengyu Qu
  2026-11-16 12:18 ` Takashi Iwai
  0 siblings, 2 replies; 3+ messages in thread
From: Geoffrey D. Bennett @ 2026-11-15 15:00 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Jaroslav Kysela, linux-sound, Frank Slotta

The Yamaha MODX M uses a different USB ID for each combination of its
audio mode and MIDI version settings:

  0499:1772  2 stereo, 44.1-96 kHz, MIDI 1.0
  0499:1763  2 stereo, 44.1-96 kHz, MIDI 2.0
  0499:1773  5 stereo, 44.1 kHz, MIDI 1.0
  0499:1764  5 stereo, 44.1 kHz, MIDI 2.0

With 0499:1773 and 0499:1764 playback is silent. With the
always_set_rate quirk flag set for them it plays. 0499:1772 and
0499:1763 play without it.

Tested on a MODX M6 with the quirk_flags module parameter set to
0499:1773:always_set_rate and to 0499:1764:always_set_rate.

Reported-by: Frank Slotta <frank.slotta@posteo.de>
Closes: https://linuxmusicians.com/viewtopic.php?p=186121
Cc: <stable@vger.kernel.org> # 7.3.x
Tested-by: Frank Slotta <frank.slotta@posteo.de>
Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
---
 sound/usb/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 7c581e283903..0a91a67d824f 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2558,6 +2558,10 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
 	DEVICE_FLG(0x0499, 0x1516, /* Yamaha ZG02 */
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x0499, 0x1764, /* Yamaha MODX M, 5 stereo, MIDI 2.0 */
+		   QUIRK_FLAG_ALWAYS_SET_RATE),
+	DEVICE_FLG(0x0499, 0x1773, /* Yamaha MODX M, 5 stereo, MIDI 1.0 */
+		   QUIRK_FLAG_ALWAYS_SET_RATE),
 	DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */
 		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M
  2026-11-15 15:00 [PATCH] ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M Geoffrey D. Bennett
@ 2026-11-15 16:12 ` Shengyu Qu
  2026-11-16 12:18 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Shengyu Qu @ 2026-11-15 16:12 UTC (permalink / raw)
  To: Geoffrey D. Bennett, Takashi Iwai
  Cc: wiagn233, Jaroslav Kysela, linux-sound, Frank Slotta


[-- Attachment #1.1: Type: text/plain, Size: 1898 bytes --]

Hi Geoffrey,

Though won't related to the actual patch but that 96khz mode is actually
1 stereo mode. XD

Best regards,
Shengyu

在 2026/11/15 23:00, Geoffrey D. Bennett 写道:
> The Yamaha MODX M uses a different USB ID for each combination of its
> audio mode and MIDI version settings:
> 
>    0499:1772  2 stereo, 44.1-96 kHz, MIDI 1.0
>    0499:1763  2 stereo, 44.1-96 kHz, MIDI 2.0
>    0499:1773  5 stereo, 44.1 kHz, MIDI 1.0
>    0499:1764  5 stereo, 44.1 kHz, MIDI 2.0
> 
> With 0499:1773 and 0499:1764 playback is silent. With the
> always_set_rate quirk flag set for them it plays. 0499:1772 and
> 0499:1763 play without it.
> 
> Tested on a MODX M6 with the quirk_flags module parameter set to
> 0499:1773:always_set_rate and to 0499:1764:always_set_rate.
> 
> Reported-by: Frank Slotta <frank.slotta@posteo.de>
> Closes: https://linuxmusicians.com/viewtopic.php?p=186121
> Cc: <stable@vger.kernel.org> # 7.3.x
> Tested-by: Frank Slotta <frank.slotta@posteo.de>
> Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
> ---
>   sound/usb/quirks.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 7c581e283903..0a91a67d824f 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2558,6 +2558,10 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>   		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
>   	DEVICE_FLG(0x0499, 0x1516, /* Yamaha ZG02 */
>   		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
> +	DEVICE_FLG(0x0499, 0x1764, /* Yamaha MODX M, 5 stereo, MIDI 2.0 */
> +		   QUIRK_FLAG_ALWAYS_SET_RATE),
> +	DEVICE_FLG(0x0499, 0x1773, /* Yamaha MODX M, 5 stereo, MIDI 1.0 */
> +		   QUIRK_FLAG_ALWAYS_SET_RATE),
>   	DEVICE_FLG(0x0499, 0x3108, /* Yamaha YIT-W12TX */
>   		   QUIRK_FLAG_GET_SAMPLE_RATE),
>   	DEVICE_FLG(0x04d8, 0xfeea, /* Benchmark DAC1 Pre */


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M
  2026-11-15 15:00 [PATCH] ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M Geoffrey D. Bennett
  2026-11-15 16:12 ` Shengyu Qu
@ 2026-11-16 12:18 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2026-11-16 12:18 UTC (permalink / raw)
  To: Geoffrey D. Bennett
  Cc: Takashi Iwai, Jaroslav Kysela, linux-sound, Frank Slotta

On Sun, 15 Nov 2026 16:00:40 +0100,
Geoffrey D. Bennett wrote:
> 
> The Yamaha MODX M uses a different USB ID for each combination of its
> audio mode and MIDI version settings:
> 
>   0499:1772  2 stereo, 44.1-96 kHz, MIDI 1.0
>   0499:1763  2 stereo, 44.1-96 kHz, MIDI 2.0
>   0499:1773  5 stereo, 44.1 kHz, MIDI 1.0
>   0499:1764  5 stereo, 44.1 kHz, MIDI 2.0
> 
> With 0499:1773 and 0499:1764 playback is silent. With the
> always_set_rate quirk flag set for them it plays. 0499:1772 and
> 0499:1763 play without it.
> 
> Tested on a MODX M6 with the quirk_flags module parameter set to
> 0499:1773:always_set_rate and to 0499:1764:always_set_rate.
> 
> Reported-by: Frank Slotta <frank.slotta@posteo.de>
> Closes: https://linuxmusicians.com/viewtopic.php?p=186121
> Cc: <stable@vger.kernel.org> # 7.3.x
> Tested-by: Frank Slotta <frank.slotta@posteo.de>
> Signed-off-by: Geoffrey D. Bennett <g@b4.vu>

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-16 12:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 15:00 [PATCH] ALSA: usb-audio: Add always_set_rate quirk for Yamaha MODX M Geoffrey D. Bennett
2026-11-15 16:12 ` Shengyu Qu
2026-11-16 12:18 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox