* [PATCH] ALSA: line6: add hw monitor volume control to POD HD500X
@ 2024-10-03 11:14 Hans Peter Moller Ebner
2024-10-03 13:59 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Hans Peter Moller Ebner @ 2024-10-03 11:14 UTC (permalink / raw)
To: linux-sound@vger.kernel.org; +Cc: tiwai@suse.com, perex@perex.cz
Add hw monitor volume control for POD HD500X. This is done adding
LINE6_CAP_HWMON_CTL to the capabilities
Signed-off-by: Hans P. Moller <hmoller@uc.cl>
---
sound/usb/line6/podhd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
index ffd8c157a281..70de08635f54 100644
--- a/sound/usb/line6/podhd.c
+++ b/sound/usb/line6/podhd.c
@@ -507,7 +507,7 @@ static const struct line6_properties podhd_properties_table[] = {
[LINE6_PODHD500X] = {
.id = "PODHD500X",
.name = "POD HD500X",
- .capabilities = LINE6_CAP_CONTROL
+ .capabilities = LINE6_CAP_CONTROL | LINE6_CAP_HWMON_CTL
| LINE6_CAP_PCM | LINE6_CAP_HWMON,
.altsetting = 1,
.ep_ctrl_r = 0x81,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: line6: add hw monitor volume control to POD HD500X
2024-10-03 11:14 [PATCH] ALSA: line6: add hw monitor volume control to POD HD500X Hans Peter Moller Ebner
@ 2024-10-03 13:59 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2024-10-03 13:59 UTC (permalink / raw)
To: Hans Peter Moller Ebner
Cc: linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz
On Thu, 03 Oct 2024 13:14:39 +0200,
Hans Peter Moller Ebner wrote:
>
> Add hw monitor volume control for POD HD500X. This is done adding
> LINE6_CAP_HWMON_CTL to the capabilities
>
> Signed-off-by: Hans P. Moller <hmoller@uc.cl>
The patch is unfortunately not applicable cleanly, since your mailer
likely broke spaces and tabs. Could you try to correct the mailer
setup and resubmit (at best via git-send-email)?
Maybe you can try to submit to yourself and test applying it in your
side before submitting to ML, too.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ALSA: line6: add hw monitor volume control to POD HD500X
@ 2024-10-03 23:28 Hans P Moller
2024-10-04 7:05 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Hans P Moller @ 2024-10-03 23:28 UTC (permalink / raw)
To: tiwai, perex, linux-sound, linux-kernel; +Cc: Hans P Moller
Add hw monitor volume control for POD HD500X. This is done adding
LINE6_CAP_HWMON_CTL to the capabilities
Signed-off-by: Hans P. Moller <hmoller@uc.cl>
---
sound/usb/line6/podhd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
index ffd8c157a281..70de08635f54 100644
--- a/sound/usb/line6/podhd.c
+++ b/sound/usb/line6/podhd.c
@@ -507,7 +507,7 @@ static const struct line6_properties podhd_properties_table[] = {
[LINE6_PODHD500X] = {
.id = "PODHD500X",
.name = "POD HD500X",
- .capabilities = LINE6_CAP_CONTROL
+ .capabilities = LINE6_CAP_CONTROL | LINE6_CAP_HWMON_CTL
| LINE6_CAP_PCM | LINE6_CAP_HWMON,
.altsetting = 1,
.ep_ctrl_r = 0x81,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: line6: add hw monitor volume control to POD HD500X
2024-10-03 23:28 Hans P Moller
@ 2024-10-04 7:05 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2024-10-04 7:05 UTC (permalink / raw)
To: Hans P Moller; +Cc: tiwai, perex, linux-sound, linux-kernel
On Fri, 04 Oct 2024 01:28:28 +0200,
Hans P Moller wrote:
>
> Add hw monitor volume control for POD HD500X. This is done adding
> LINE6_CAP_HWMON_CTL to the capabilities
>
> Signed-off-by: Hans P. Moller <hmoller@uc.cl>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-04 7:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-03 11:14 [PATCH] ALSA: line6: add hw monitor volume control to POD HD500X Hans Peter Moller Ebner
2024-10-03 13:59 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2024-10-03 23:28 Hans P Moller
2024-10-04 7:05 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox