Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost
@ 2026-07-31 21:13 Sean Rhodes
  2026-07-31 21:13 ` [PATCH 2/2] ALSA: hda/realtek: Add StarFighter HDA SSID Sean Rhodes
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Sean Rhodes @ 2026-07-31 21:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jaroslav Kysela, Takashi Iwai, Zhang Heng, Kailang Yang,
	Damien Dagorn, Sean Rhodes, Chris Chiu, Lei Huang, Eric Naim,
	linux-sound

The 30 dB internal mic boost is too high for laptops, especially with fans. Limit Star Labs internal mic boost to 10 dB.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 sound/hda/codecs/realtek/alc269.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 379e1458f4ac..42756a3f3f8e 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4188,6 +4188,7 @@ enum {
 	ALC245_FIXUP_CLEVO_NOISY_MIC,
 	ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
 	ALC233_FIXUP_MEDION_MTL_SPK,
+	ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
 	ALC233_FIXUP_STARLABS_STARFIGHTER,
 	ALC294_FIXUP_BASS_SPEAKER_15,
 	ALC283_FIXUP_DELL_HP_RESUME,
@@ -6725,6 +6726,10 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		},
 	},
+	[ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc269_fixup_limit_int_mic_boost,
+	},
 	[ALC233_FIXUP_STARLABS_STARFIGHTER] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc233_fixup_starlabs_starfighter,
@@ -8099,6 +8104,7 @@ static const struct hda_quirk alc269_fixup_vendor_tbl[] = {
 	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
 	SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo XPAD", ALC269_FIXUP_LENOVO_XPAD_ACPI),
 	SND_PCI_QUIRK_VENDOR(0x19e5, "Huawei Matebook", ALC255_FIXUP_MIC_MUTE_LED),
+	SND_PCI_QUIRK_VENDOR(0x2145, "Star Labs", ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST),
 	{}
 };
 

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ALSA: hda/realtek: Add StarFighter HDA SSID
  2026-07-31 21:13 [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Sean Rhodes
@ 2026-07-31 21:13 ` Sean Rhodes
  2026-08-03  7:03 ` [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Takashi Iwai
  2026-08-03  7:12 ` Eric Naim
  2 siblings, 0 replies; 6+ messages in thread
From: Sean Rhodes @ 2026-07-31 21:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jaroslav Kysela, Takashi Iwai, Zhang Heng, Kailang Yang,
	Damien Dagorn, Sean Rhodes, Chris Chiu, Lei Huang, Eric Naim,
	linux-sound

Support the new StarFighter HDA SSID while keeping the existing SSID chained to the same quirk until the new match reaches backports.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 sound/hda/codecs/realtek/alc269.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 42756a3f3f8e..4588dbd074ad 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6733,6 +6733,8 @@ static const struct hda_fixup alc269_fixups[] = {
 	[ALC233_FIXUP_STARLABS_STARFIGHTER] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc233_fixup_starlabs_starfighter,
+		.chained = true,
+		.chain_id = ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
 	},
 	[ALC294_FIXUP_BASS_SPEAKER_15] = {
 		.type = HDA_FIXUP_FUNC,
@@ -8022,6 +8024,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1f66, 0x0105, "Ayaneo Portable Game Player", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x2014, 0x800a, "Positivo ARN50", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x2039, 0x0001, "Inspur S14-G1", ALC295_FIXUP_CHROME_BOOK),
+	SND_PCI_QUIRK(0x2145, 0x0001, "Star Labs StarFighter", ALC233_FIXUP_STARLABS_STARFIGHTER),
 	SND_PCI_QUIRK(0x2782, 0x0214, "VAIO VJFE-CL", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x2782, 0x0228, "Infinix ZERO BOOK 13", ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13),
 	SND_PCI_QUIRK(0x2782, 0x0232, "CHUWI CoreBook XPro", ALC269VB_FIXUP_CHUWI_COREBOOK_XPRO),

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost
  2026-07-31 21:13 [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Sean Rhodes
  2026-07-31 21:13 ` [PATCH 2/2] ALSA: hda/realtek: Add StarFighter HDA SSID Sean Rhodes
@ 2026-08-03  7:03 ` Takashi Iwai
  2026-08-03  7:12 ` Eric Naim
  2 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2026-08-03  7:03 UTC (permalink / raw)
  To: Sean Rhodes
  Cc: linux-kernel, Jaroslav Kysela, Takashi Iwai, Zhang Heng,
	Kailang Yang, Damien Dagorn, Chris Chiu, Lei Huang, Eric Naim,
	linux-sound

On Fri, 31 Jul 2026 23:13:08 +0200,
Sean Rhodes wrote:
> 
> The 30 dB internal mic boost is too high for laptops, especially with fans. Limit Star Labs internal mic boost to 10 dB.
> 
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>

Applied both patches to for-next branch now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost
  2026-07-31 21:13 [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Sean Rhodes
  2026-07-31 21:13 ` [PATCH 2/2] ALSA: hda/realtek: Add StarFighter HDA SSID Sean Rhodes
  2026-08-03  7:03 ` [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Takashi Iwai
@ 2026-08-03  7:12 ` Eric Naim
  2026-08-03  7:24   ` Eric Naim
  2 siblings, 1 reply; 6+ messages in thread
From: Eric Naim @ 2026-08-03  7:12 UTC (permalink / raw)
  To: Sean Rhodes, linux-kernel
  Cc: Jaroslav Kysela, Takashi Iwai, Zhang Heng, Kailang Yang,
	Damien Dagorn, Chris Chiu, Lei Huang, linux-sound

Hi Sean,

On 8/1/26 4:13 AM, Sean Rhodes wrote:
> The 30 dB internal mic boost is too high for laptops, especially with fans. Limit Star Labs internal mic boost to 10 dB.
> 
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
>  sound/hda/codecs/realtek/alc269.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 379e1458f4ac..42756a3f3f8e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -4188,6 +4188,7 @@ enum {
>  	ALC245_FIXUP_CLEVO_NOISY_MIC,
>  	ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
>  	ALC233_FIXUP_MEDION_MTL_SPK,
> +	ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
>  	ALC233_FIXUP_STARLABS_STARFIGHTER,
>  	ALC294_FIXUP_BASS_SPEAKER_15,
>  	ALC283_FIXUP_DELL_HP_RESUME,
> @@ -6725,6 +6726,10 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ }
>  		},
>  	},
> +	[ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc269_fixup_limit_int_mic_boost,
> +	},

I guess the reason you're creating a new quirk is because the existing
ALC269_FIXUP_LIMIT_INT_MIC_BOOST is chained to ALC269_FIXUP_THINKPAD_ACPI.
This makes the quirk identical to ALC269_FIXUP_THINKPAD_ACPI. Would it be
worth reworking the existing ALC_269_FIXUP_LIMIT_INT_MIC_BOOST to not be
chained and then create a new ALC269_FIXUP_THINKPAD_LIMIT (or similar) for
whichever devices that need it?

--
Regards,
  Eric

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost
  2026-08-03  7:12 ` Eric Naim
@ 2026-08-03  7:24   ` Eric Naim
  2026-08-03  7:28     ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: Eric Naim @ 2026-08-03  7:24 UTC (permalink / raw)
  To: Sean Rhodes, linux-kernel
  Cc: Jaroslav Kysela, Takashi Iwai, Zhang Heng, Kailang Yang,
	Damien Dagorn, Chris Chiu, Lei Huang, linux-sound

On 8/3/26 2:12 PM, Eric Naim wrote:
> Hi Sean,
> 
> On 8/1/26 4:13 AM, Sean Rhodes wrote:
>> The 30 dB internal mic boost is too high for laptops, especially with fans. Limit Star Labs internal mic boost to 10 dB.
>>
>> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
>> ---
>>  sound/hda/codecs/realtek/alc269.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
>> index 379e1458f4ac..42756a3f3f8e 100644
>> --- a/sound/hda/codecs/realtek/alc269.c
>> +++ b/sound/hda/codecs/realtek/alc269.c
>> @@ -4188,6 +4188,7 @@ enum {
>>  	ALC245_FIXUP_CLEVO_NOISY_MIC,
>>  	ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
>>  	ALC233_FIXUP_MEDION_MTL_SPK,
>> +	ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
>>  	ALC233_FIXUP_STARLABS_STARFIGHTER,
>>  	ALC294_FIXUP_BASS_SPEAKER_15,
>>  	ALC283_FIXUP_DELL_HP_RESUME,
>> @@ -6725,6 +6726,10 @@ static const struct hda_fixup alc269_fixups[] = {
>>  			{ }
>>  		},
>>  	},
>> +	[ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST] = {
>> +		.type = HDA_FIXUP_FUNC,
>> +		.v.func = alc269_fixup_limit_int_mic_boost,
>> +	},
> 
> I guess the reason you're creating a new quirk is because the existing
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST is chained to ALC269_FIXUP_THINKPAD_ACPI.
> This makes the quirk identical to ALC269_FIXUP_THINKPAD_ACPI. Would it be

                    s/ALC269_FIXUP_THINKPAD_ACPI/ALC233_FIXUP_INTEL_NUC8_BOOST

> worth reworking the existing ALC_269_FIXUP_LIMIT_INT_MIC_BOOST to not be
> chained and then create a new ALC269_FIXUP_THINKPAD_LIMIT (or similar) for
> whichever devices that need it?
> 
> --
> Regards,
>   Eric

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost
  2026-08-03  7:24   ` Eric Naim
@ 2026-08-03  7:28     ` Takashi Iwai
  0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2026-08-03  7:28 UTC (permalink / raw)
  To: Eric Naim
  Cc: Sean Rhodes, linux-kernel, Jaroslav Kysela, Takashi Iwai,
	Zhang Heng, Kailang Yang, Damien Dagorn, Chris Chiu, Lei Huang,
	linux-sound

On Mon, 03 Aug 2026 09:24:00 +0200,
Eric Naim wrote:
> 
> On 8/3/26 2:12 PM, Eric Naim wrote:
> > Hi Sean,
> > 
> > On 8/1/26 4:13 AM, Sean Rhodes wrote:
> >> The 30 dB internal mic boost is too high for laptops, especially with fans. Limit Star Labs internal mic boost to 10 dB.
> >>
> >> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> >> ---
> >>  sound/hda/codecs/realtek/alc269.c | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> >> index 379e1458f4ac..42756a3f3f8e 100644
> >> --- a/sound/hda/codecs/realtek/alc269.c
> >> +++ b/sound/hda/codecs/realtek/alc269.c
> >> @@ -4188,6 +4188,7 @@ enum {
> >>  	ALC245_FIXUP_CLEVO_NOISY_MIC,
> >>  	ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
> >>  	ALC233_FIXUP_MEDION_MTL_SPK,
> >> +	ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
> >>  	ALC233_FIXUP_STARLABS_STARFIGHTER,
> >>  	ALC294_FIXUP_BASS_SPEAKER_15,
> >>  	ALC283_FIXUP_DELL_HP_RESUME,
> >> @@ -6725,6 +6726,10 @@ static const struct hda_fixup alc269_fixups[] = {
> >>  			{ }
> >>  		},
> >>  	},
> >> +	[ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST] = {
> >> +		.type = HDA_FIXUP_FUNC,
> >> +		.v.func = alc269_fixup_limit_int_mic_boost,
> >> +	},
> > 
> > I guess the reason you're creating a new quirk is because the existing
> > ALC269_FIXUP_LIMIT_INT_MIC_BOOST is chained to ALC269_FIXUP_THINKPAD_ACPI.
> > This makes the quirk identical to ALC269_FIXUP_THINKPAD_ACPI. Would it be
> 
>                     s/ALC269_FIXUP_THINKPAD_ACPI/ALC233_FIXUP_INTEL_NUC8_BOOST
> 
> > worth reworking the existing ALC_269_FIXUP_LIMIT_INT_MIC_BOOST to not be
> > chained and then create a new ALC269_FIXUP_THINKPAD_LIMIT (or similar) for
> > whichever devices that need it?

A good point. If you come up with a new change, try to make a patch on
top of the latest sound git tree for-next branch.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-08-03  7:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 21:13 [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Sean Rhodes
2026-07-31 21:13 ` [PATCH 2/2] ALSA: hda/realtek: Add StarFighter HDA SSID Sean Rhodes
2026-08-03  7:03 ` [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost Takashi Iwai
2026-08-03  7:12 ` Eric Naim
2026-08-03  7:24   ` Eric Naim
2026-08-03  7:28     ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox