* [PATCH v2] ALSA: hda: Fix the wrong register was used for DVC of TAS2770
@ 2025-07-29 14:58 Baojun Xu
2025-07-29 15:49 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Baojun Xu @ 2025-07-29 14:58 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding,
13916275206, linux-sound, linux-kernel, baojun.xu
The wrong register was used for digital volume control of TAS2770,
The definition was changed, and usage was also updated.
Fixes: ab29b3460c5c ("ALSA: hda: Add TAS2770 support")
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
v2
- Correct number from -1000 to -10000 for DVC.
---
include/sound/tas2770-tlv.h | 4 ++--
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/sound/tas2770-tlv.h b/include/sound/tas2770-tlv.h
index c0bd495b4a07..c7380925417a 100644
--- a/include/sound/tas2770-tlv.h
+++ b/include/sound/tas2770-tlv.h
@@ -14,10 +14,10 @@
#ifndef __TAS2770_TLV_H__
#define __TAS2770_TLV_H__
-#define TAS2770_DVC_LEVEL TASDEVICE_REG(0x0, 0x0, 0x17)
+#define TAS2770_DVC_LEVEL TASDEVICE_REG(0x0, 0x0, 0x05)
#define TAS2770_AMP_LEVEL TASDEVICE_REG(0x0, 0x0, 0x03)
-static const __maybe_unused DECLARE_TLV_DB_SCALE(tas2770_dvc_tlv, 1650, 50, 0);
+static const __maybe_unused DECLARE_TLV_DB_SCALE(tas2770_dvc_tlv, -10000, 50, 0);
static const __maybe_unused DECLARE_TLV_DB_SCALE(tas2770_amp_tlv, 1100, 50, 0);
#endif
diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
index a0b132681804..45ac5e41bd4f 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
@@ -260,7 +260,7 @@ static const struct snd_kcontrol_new tas2770_snd_controls[] = {
0, 0, 20, 0, tas2781_amp_getvol,
tas2781_amp_putvol, tas2770_amp_tlv),
ACARD_SINGLE_RANGE_EXT_TLV("Speaker Digital Volume", TAS2770_DVC_LEVEL,
- 0, 0, 31, 0, tas2781_amp_getvol,
+ 0, 0, 200, 1, tas2781_amp_getvol,
tas2781_amp_putvol, tas2770_dvc_tlv),
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ALSA: hda: Fix the wrong register was used for DVC of TAS2770
2025-07-29 14:58 [PATCH v2] ALSA: hda: Fix the wrong register was used for DVC of TAS2770 Baojun Xu
@ 2025-07-29 15:49 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-07-29 15:49 UTC (permalink / raw)
To: Baojun Xu
Cc: broonie, andriy.shevchenko, alsa-devel, shenghao-ding,
13916275206, linux-sound, linux-kernel
On Tue, 29 Jul 2025 16:58:49 +0200,
Baojun Xu wrote:
>
> The wrong register was used for digital volume control of TAS2770,
> The definition was changed, and usage was also updated.
>
> Fixes: ab29b3460c5c ("ALSA: hda: Add TAS2770 support")
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-29 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 14:58 [PATCH v2] ALSA: hda: Fix the wrong register was used for DVC of TAS2770 Baojun Xu
2025-07-29 15:49 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox