From: Takashi Iwai <tiwai@suse.de>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: generic: Remove obsolete call to ledtrig_audio_get
Date: Mon, 15 Jan 2024 12:43:25 +0100 [thread overview]
Message-ID: <877ckayg82.wl-tiwai@suse.de> (raw)
In-Reply-To: <3dc9167d-fb33-43a6-baa6-dbef8b5da7b9@gmail.com>
On Sat, 13 Jan 2024 17:08:54 +0100,
Heiner Kallweit wrote:
>
> Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to
> ensure the initial brightness is set") the audio triggers have an
> activate callback which sets the LED brightness as soon as the
> (default) trigger is bound to the LED device. So we can remove the
> call to ledtrig_audio_get.
>
> Positive side effect: We have no code dependency to ledtrig-audio any
> longer, therefore, if built as module, it's no longer loaded if not
> needed.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2024-01-15 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 16:08 [PATCH] ALSA: hda: generic: Remove obsolete call to ledtrig_audio_get Heiner Kallweit
2024-01-15 11:43 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ckayg82.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=hkallweit1@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox