Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Andrea Di Pietro <andreadipietro084@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable mute LEDs for HP OmniBook 7 14-hg0xxx
Date: Sun, 22 Nov 2026 09:18:40 +0100	[thread overview]
Message-ID: <878q2l6zz3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261121174326.16369-1-andreadipietro084@gmail.com>

On Sat, 21 Nov 2026 18:43:26 +0100,
Andrea Di Pietro wrote:
> 
> Use ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS for PCI SSID 103c:8f07
> (HP OmniBook 7 Laptop 14-hg0xxx) so both mute and mic-mute LEDs
> work alongside the dual CS35L41 I2C amplifiers.
> 
> Signed-off-by: Andrea Di Pietro <andreadipietro084@gmail.com>
> ---
>  sound/hda/codecs/realtek/alc269.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Notes for maintainers:
> 
> PCI SSID 103c:8f07 was previously listed as "HP Agusta G7KX" using
> ALC287_FIXUP_CS35L41_I2C_2. On my HP OmniBook 7 Laptop 14-hg0xxx
> (DMI: "HP HP OmniBook 7 Laptop 14-hg0xxx/8F07"), dmesg shows the CS35L41
> DSP firmware path referencing "HP_Consumer\CY25\Agusta\Official_release",
> confirming that "Agusta" is the internal codename for this platform.
> 
> Switching to ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS keeps the dual
> CS35L41 I2C initialization intact while chaining
> ALC245_FIXUP_HP_X360_MUTE_LEDS, which exposes and drives both
> hda::mute and hda::micmute properly on this hardware.
> 
> Please confirm whether updating the existing 103c:8f07 entry in-place
> is safe across any other variants sharing this SSID.

This should be fine, as it's a code name as you guessed.

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-11-22  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 17:43 [PATCH] ALSA: hda/realtek: Enable mute LEDs for HP OmniBook 7 14-hg0xxx Andrea Di Pietro
2026-11-22  8:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878q2l6zz3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=andreadipietro084@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox