Linux Sound subsystem development
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Enable mute LEDs for HP OmniBook 7 14-hg0xxx
@ 2026-11-21 17:43 Andrea Di Pietro
  2026-11-22  8:18 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Andrea Di Pietro @ 2026-11-21 17:43 UTC (permalink / raw)
  To: tiwai, perex; +Cc: linux-sound, Andrea Di Pietro

Use ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS for PCI SSID 103c:8f07
(HP OmniBook 7 Laptop 14-hg0xxx) so both mute and mic-mute LEDs
work alongside the dual CS35L41 I2C amplifiers.

Signed-off-by: Andrea Di Pietro <andreadipietro084@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Notes for maintainers:

PCI SSID 103c:8f07 was previously listed as "HP Agusta G7KX" using
ALC287_FIXUP_CS35L41_I2C_2. On my HP OmniBook 7 Laptop 14-hg0xxx
(DMI: "HP HP OmniBook 7 Laptop 14-hg0xxx/8F07"), dmesg shows the CS35L41
DSP firmware path referencing "HP_Consumer\CY25\Agusta\Official_release",
confirming that "Agusta" is the internal codename for this platform.

Switching to ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS keeps the dual
CS35L41 I2C initialization intact while chaining
ALC245_FIXUP_HP_X360_MUTE_LEDS, which exposes and drives both
hda::mute and hda::micmute properly on this hardware.

Please confirm whether updating the existing 103c:8f07 entry in-place
is safe across any other variants sharing this SSID.

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index d38be4d500b..c746aa3a5c1 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8145,7 +8145,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8ee4, "HP Bantie A6U", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO),
 	SND_PCI_QUIRK(0x103c, 0x8ee5, "HP Bantie A6U", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO),
 	SND_PCI_QUIRK(0x103c, 0x8ee7, "HP Abe A6U", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO),
-	SND_PCI_QUIRK(0x103c, 0x8f07, "HP Agusta G7KX", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x103c, 0x8f07, "HP OmniBook 7 Laptop 14-hg0xxx", ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8f0c, "HP ZBook X G2i 16W", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8f0e, "HP ZBook X G2i 16W", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8f2d, "HP Auster 14", ALC287_FIXUP_CS35L41_I2C_2),
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Enable mute LEDs for HP OmniBook 7 14-hg0xxx
  2026-11-21 17:43 [PATCH] ALSA: hda/realtek: Enable mute LEDs for HP OmniBook 7 14-hg0xxx Andrea Di Pietro
@ 2026-11-22  8:18 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-11-22  8:18 UTC (permalink / raw)
  To: Andrea Di Pietro; +Cc: tiwai, perex, linux-sound

On Sat, 21 Nov 2026 18:43:26 +0100,
Andrea Di Pietro wrote:
> 
> Use ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS for PCI SSID 103c:8f07
> (HP OmniBook 7 Laptop 14-hg0xxx) so both mute and mic-mute LEDs
> work alongside the dual CS35L41 I2C amplifiers.
> 
> Signed-off-by: Andrea Di Pietro <andreadipietro084@gmail.com>
> ---
>  sound/hda/codecs/realtek/alc269.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Notes for maintainers:
> 
> PCI SSID 103c:8f07 was previously listed as "HP Agusta G7KX" using
> ALC287_FIXUP_CS35L41_I2C_2. On my HP OmniBook 7 Laptop 14-hg0xxx
> (DMI: "HP HP OmniBook 7 Laptop 14-hg0xxx/8F07"), dmesg shows the CS35L41
> DSP firmware path referencing "HP_Consumer\CY25\Agusta\Official_release",
> confirming that "Agusta" is the internal codename for this platform.
> 
> Switching to ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS keeps the dual
> CS35L41 I2C initialization intact while chaining
> ALC245_FIXUP_HP_X360_MUTE_LEDS, which exposes and drives both
> hda::mute and hda::micmute properly on this hardware.
> 
> Please confirm whether updating the existing 103c:8f07 entry in-place
> is safe across any other variants sharing this SSID.

This should be fine, as it's a code name as you guessed.

Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-22  8:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 17:43 [PATCH] ALSA: hda/realtek: Enable mute LEDs for HP OmniBook 7 14-hg0xxx Andrea Di Pietro
2026-11-22  8:18 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox